Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specialize STORE_SUBSCR #89772

Closed
sweeneyde opened this issue Oct 26, 2021 · 3 comments
Closed

Specialize STORE_SUBSCR #89772

sweeneyde opened this issue Oct 26, 2021 · 3 comments
Labels
3.11 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage

Comments

@sweeneyde
Copy link
Member

BPO 45609
Nosy @markshannon, @sweeneyde
PRs
  • bpo-45609: Specialize STORE_SUBSCR #29221
  • bpo-45609: Specialize STORE_SUBSCR (alternate) #29242
  • bpo-45609: More specialization stats for STORE_SUBSCR #30193
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2021-11-20.18:31:08.506>
created_at = <Date 2021-10-26.00:42:26.024>
labels = ['interpreter-core', '3.11', 'performance']
title = 'Specialize STORE_SUBSCR'
updated_at = <Date 2022-01-04.18:05:28.152>
user = 'https://github.com/sweeneyde'

    bugs.python.org fields:

    activity = <Date 2022-01-04.18:05:28.152>
actor = 'Mark.Shannon'
assignee = 'none'
closed = True
closed_date = <Date 2021-11-20.18:31:08.506>
closer = 'pablogsal'
components = ['Interpreter Core']
creation = <Date 2021-10-26.00:42:26.024>
creator = 'Dennis Sweeney'
dependencies = []
files = []
hgrepos = []
issue_num = 45609
keywords = ['patch']
message_count = 3.0
messages = ['405015', '406577', '409695']
nosy_count = 2.0
nosy_names = ['Mark.Shannon', 'Dennis Sweeney']
pr_nums = ['29221', '29242', '30193']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'performance'
url = 'https://bugs.python.org/issue45609'
versions = ['Python 3.11']
    @sweeneyde
    Copy link
    Member Author

    See the issue here for lots of data from before specializing: faster-cpython/ideas#105

    See https://gist.github.com/sweeneyde/91855e50feb9992b604ddda2d4f1511e for specialization data, pyperformance benchmarks, and microbenchmarks.

    Right now the PR draft specializes list[int], dict[str], and bytearray[int], although I don't if the bytearray opcode should be kept. I considered specializing dict[object], but I figured the overhead of PyDict_SetItem isn't that much less than PyObject_SetItem.

    @sweeneyde sweeneyde added 3.11 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage labels Oct 26, 2021
    @markshannon
    Copy link
    Member

    New changeset 036fead by Dennis Sweeney in branch 'main':
    bpo-45609: Specialize STORE_SUBSCR (GH-29242)
    036fead

    @markshannon
    Copy link
    Member

    New changeset 7537f60 by Dennis Sweeney in branch 'main':
    bpo-45609: More specialization stats for STORE_SUBSCR (GH-30193)
    7537f60

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.11 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @markshannon @pablogsal @sweeneyde