Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules/makesetup uses wrong CFLAGS for *shared* #89734

Closed
tiran opened this issue Oct 22, 2021 · 4 comments
Closed

Modules/makesetup uses wrong CFLAGS for *shared* #89734

tiran opened this issue Oct 22, 2021 · 4 comments
Labels
3.9 only security fixes 3.10 only security fixes 3.11 bug and security fixes build The build process and cross-build type-bug An unexpected behavior, bug, or error

Comments

@tiran
Copy link
Member

tiran commented Oct 22, 2021

BPO 45571
Nosy @Yhg1s, @brettcannon, @vstinner, @tiran, @miss-islington
PRs
  • bpo-45571: use PY_CFLAGS_NODIST for shared Modules/Setup (GH-29161) #29161
  • [3.10] bpo-45571: use PY_CFLAGS_NODIST for shared Modules/Setup (GH-29161) #29168
  • [3.9] bpo-45571: use PY_CFLAGS_NODIST for shared Modules/Setup (GH-29161) #29169
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2021-10-22.19:12:54.170>
    created_at = <Date 2021-10-22.13:21:54.015>
    labels = ['3.10', 'type-bug', '3.9', 'build', '3.11']
    title = 'Modules/makesetup uses wrong CFLAGS for *shared*'
    updated_at = <Date 2021-10-22.19:12:54.170>
    user = 'https://github.com/tiran'

    bugs.python.org fields:

    activity = <Date 2021-10-22.19:12:54.170>
    actor = 'christian.heimes'
    assignee = 'none'
    closed = True
    closed_date = <Date 2021-10-22.19:12:54.170>
    closer = 'christian.heimes'
    components = ['Build']
    creation = <Date 2021-10-22.13:21:54.015>
    creator = 'christian.heimes'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 45571
    keywords = ['patch']
    message_count = 4.0
    messages = ['404766', '404804', '404807', '404810']
    nosy_count = 5.0
    nosy_names = ['twouters', 'brett.cannon', 'vstinner', 'christian.heimes', 'miss-islington']
    pr_nums = ['29161', '29168', '29169']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue45571'
    versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

    @tiran
    Copy link
    Member Author

    tiran commented Oct 22, 2021

    I think that makesetup uses the wrong CFLAGS variable for shared modules. The script uses PY_CFLAGS:

    no)     cc="$cc \$(CCSHARED) \$(PY_CFLAGS) \$(PY_CPPFLAGS)";;
    
    while setup.py uses PY_CFLAGS_NODIST:
    
        set_compiler_flags('CFLAGS', 'PY_CFLAGS_NODIST')

    The flags are similar but not equal. Amongst others PY_CFLAGS does not include Include/internal while PY_CFLAGS_NODIST has -I./Include/internal.

    @tiran tiran added 3.9 only security fixes 3.10 only security fixes 3.11 bug and security fixes build The build process and cross-build type-bug An unexpected behavior, bug, or error labels Oct 22, 2021
    @tiran
    Copy link
    Member Author

    tiran commented Oct 22, 2021

    New changeset f6e8b80 by Christian Heimes in branch 'main':
    bpo-45571: use PY_CFLAGS_NODIST for shared Modules/Setup (GH-29161)
    f6e8b80

    @miss-islington
    Copy link
    Contributor

    New changeset 1990308 by Miss Islington (bot) in branch '3.10':
    bpo-45571: use PY_CFLAGS_NODIST for shared Modules/Setup (GH-29161)
    1990308

    @miss-islington
    Copy link
    Contributor

    New changeset 269bf56 by Miss Islington (bot) in branch '3.9':
    bpo-45571: use PY_CFLAGS_NODIST for shared Modules/Setup (GH-29161)
    269bf56

    @tiran tiran closed this as completed Oct 22, 2021
    @tiran tiran closed this as completed Oct 22, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.9 only security fixes 3.10 only security fixes 3.11 bug and security fixes build The build process and cross-build type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants