Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dataclasses’s test_frozen_pickle does not use all possible pickle protocols #89729

Closed
sobolevn opened this issue Oct 22, 2021 · 3 comments
Closed

dataclasses’s test_frozen_pickle does not use all possible pickle protocols #89729

sobolevn opened this issue Oct 22, 2021 · 3 comments
Labels
3.10 only security fixes 3.11 only security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member

BPO 45566
Nosy @miss-islington, @sobolevn
PRs
  • bpo-45566: test_frozen_pickle checks all pickle protocols #29150
  • [3.10] bpo-45566: test_frozen_pickle checks all pickle protocols (GH-29150) #29201
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2021-10-24.19:42:31.236>
created_at = <Date 2021-10-22.08:39:07.043>
labels = ['type-bug', 'tests', '3.10', '3.11']
title = 'dataclasses\xe2\x80\x99s `test_frozen_pickle` does not use all possible `pickle` protocols'
updated_at = <Date 2021-10-24.19:42:31.235>
user = 'https://github.com/sobolevn'

    bugs.python.org fields:

    activity = <Date 2021-10-24.19:42:31.235>
actor = 'eric.smith'
assignee = 'none'
closed = True
closed_date = <Date 2021-10-24.19:42:31.236>
closer = 'eric.smith'
components = ['Tests']
creation = <Date 2021-10-22.08:39:07.043>
creator = 'sobolevn'
dependencies = []
files = []
hgrepos = []
issue_num = 45566
keywords = ['patch']
message_count = 3.0
messages = ['404728', '404928', '404931']
nosy_count = 2.0
nosy_names = ['miss-islington', 'sobolevn']
pr_nums = ['29150', '29201']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue45566'
versions = ['Python 3.10', 'Python 3.11']
    @sobolevn
    Copy link
    Member Author

    While working on #29147 I've noticed that test_frozen_pickle does not use all possible pickle protocols:

    cpython/Lib/test/test_dataclasses.py

    Line 2862 in 276468d

    def test_frozen_pickle(self):

    I will add for and self.subTest for each unique pickle protocol.
    After that it would be in sync with 3.9 branch.

    @sobolevn sobolevn added 3.10 only security fixes 3.11 only security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error labels Oct 22, 2021
    @ericvsmith ericvsmith changed the title test_frozen_pickle does not use all possible pickle protocols dataclasses test_frozen_pickle does not use all possible pickle protocols Oct 23, 2021
    @ericvsmith ericvsmith changed the title test_frozen_pickle does not use all possible pickle protocols dataclasses test_frozen_pickle does not use all possible pickle protocols Oct 23, 2021
    @ericvsmith ericvsmith changed the title dataclasses test_frozen_pickle does not use all possible pickle protocols dataclasses’s test_frozen_pickle does not use all possible pickle protocols Oct 23, 2021
    @ericvsmith ericvsmith changed the title dataclasses test_frozen_pickle does not use all possible pickle protocols dataclasses’s test_frozen_pickle does not use all possible pickle protocols Oct 23, 2021
    @miss-islington
    Copy link
    Contributor

    New changeset 07236d5 by Nikita Sobolev in branch 'main':
    bpo-45566: test_frozen_pickle checks all pickle protocols (GH-29150)
    07236d5

    @miss-islington
    Copy link
    Contributor

    New changeset 36971fd by Miss Islington (bot) in branch '3.10':
    bpo-45566: test_frozen_pickle checks all pickle protocols (GH-29150)
    36971fd

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.10 only security fixes 3.11 only security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @ericvsmith @sobolevn @miss-islington