Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for ssl.load_default_certs is outdated #89620

Closed
LincolnPuzey mannequin opened this issue Oct 13, 2021 · 5 comments
Closed

Documentation for ssl.load_default_certs is outdated #89620

LincolnPuzey mannequin opened this issue Oct 13, 2021 · 5 comments
Assignees
@tiran
Labels
3.9 only security fixes 3.10 only security fixes 3.11 only security fixes docs Documentation in the Doc dir topic-SSL type-feature A feature request or enhancement

Comments

@LincolnPuzey
Copy link
Mannequin

LincolnPuzey mannequin commented Oct 13, 2021

BPO 45457
Nosy @tiran, @ambv, @miss-islington, @LincolnPuzey
PRs
  • bpo-45457: Minor fix to documentation for SSLContext.load_default_certs. #28947
  • [3.10] bpo-45457: Minor fix to documentation for SSLContext.load_default_certs. (GH-28947) #29373
  • [3.9] bpo-45457: Minor fix to documentation for SSLContext.load_default_certs. (GH-28947) #29374
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/tiran'
closed_at = <Date 2021-11-02.21:54:17.730>
created_at = <Date 2021-10-13.07:01:17.420>
labels = ['expert-SSL', '3.9', '3.10', '3.11', 'type-feature', 'docs']
title = 'Documentation for ssl.load_default_certs is outdated'
updated_at = <Date 2021-11-02.21:54:17.729>
user = 'https://github.com/LincolnPuzey'

    bugs.python.org fields:

    activity = <Date 2021-11-02.21:54:17.729>
actor = 'lukasz.langa'
assignee = 'christian.heimes'
closed = True
closed_date = <Date 2021-11-02.21:54:17.730>
closer = 'lukasz.langa'
components = ['Documentation', 'SSL']
creation = <Date 2021-10-13.07:01:17.420>
creator = 'LincolnPuzey'
dependencies = []
files = []
hgrepos = []
issue_num = 45457
keywords = ['patch']
message_count = 5.0
messages = ['403806', '405554', '405556', '405558', '405559']
nosy_count = 5.0
nosy_names = ['christian.heimes', 'lukasz.langa', 'miss-islington', 'jerrylikerice1s', 'LincolnPuzey']
pr_nums = ['28947', '29373', '29374']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue45457'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']
    @LincolnPuzey
    Copy link
    Mannequin Author

    LincolnPuzey mannequin commented Oct 13, 2021

    The behavior of ssl.load_default_certs() was changed in https://bugs.python.org/issue22449

    The new behavior is that ssl.set_default_verify_paths() is now called on all systems.

    The documentation still says that ssl.set_default_verify_paths() is only called on systems OTHER than Windows.

    @LincolnPuzey LincolnPuzey mannequin assigned tiran Oct 13, 2021
    @LincolnPuzey LincolnPuzey mannequin added the topic-SSL label Oct 13, 2021
    @LincolnPuzey LincolnPuzey mannequin assigned tiran Oct 13, 2021
    @LincolnPuzey LincolnPuzey mannequin added the topic-SSL label Oct 13, 2021
    @tiran tiran added 3.9 only security fixes 3.10 only security fixes 3.11 only security fixes docs Documentation in the Doc dir type-feature A feature request or enhancement labels Oct 13, 2021
    @ambv
    Copy link
    Contributor

    ambv commented Nov 2, 2021

    New changeset 3551bf1 by LincolnPuzey in branch 'main':
    bpo-45457: Minor fix to documentation for SSLContext.load_default_certs. (GH-28947)
    3551bf1

    @ambv
    Copy link
    Contributor

    ambv commented Nov 2, 2021

    New changeset 71f602b by Miss Islington (bot) in branch '3.10':
    bpo-45457: Minor fix to documentation for SSLContext.load_default_certs. (GH-28947) (GH-29373)
    71f602b

    @ambv
    Copy link
    Contributor

    ambv commented Nov 2, 2021

    New changeset 4ab6e52 by Miss Islington (bot) in branch '3.9':
    bpo-45457: Minor fix to documentation for SSLContext.load_default_certs. (GH-28947) (GH-29374)
    4ab6e52

    @ambv
    Copy link
    Contributor

    ambv commented Nov 2, 2021

    Thanks, Lincoln! ✨ 🍰 ✨

    @ambv ambv closed this as completed Nov 2, 2021
    @ambv ambv closed this as completed Nov 2, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @tiran tiran

    Labels
    3.9 only security fixes 3.10 only security fixes 3.11 only security fixes docs Documentation in the Doc dir topic-SSL type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @ambv @tiran