Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_binascii fails on windows #48792

Closed
amauryfa opened this issue Dec 5, 2008 · 2 comments
Closed

test_binascii fails on windows #48792

amauryfa opened this issue Dec 5, 2008 · 2 comments
Labels
easy OS-windows

Comments

@amauryfa
Copy link
Member

amauryfa commented Dec 5, 2008

BPO 4542
Nosy @amauryfa

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2008-12-05.01:42:16.005>
created_at = <Date 2008-12-05.01:36:53.650>
labels = ['easy', 'OS-windows']
title = 'test_binascii fails on windows'
updated_at = <Date 2008-12-05.01:42:16.003>
user = 'https://github.com/amauryfa'

bugs.python.org fields:

activity = <Date 2008-12-05.01:42:16.003>
actor = 'amaury.forgeotdarc'
assignee = 'none'
closed = True
closed_date = <Date 2008-12-05.01:42:16.005>
closer = 'amaury.forgeotdarc'
components = ['Windows']
creation = <Date 2008-12-05.01:36:53.650>
creator = 'amaury.forgeotdarc'
dependencies = []
files = []
hgrepos = []
issue_num = 4542
keywords = ['patch', 'easy']
message_count = 2.0
messages = ['76963', '76964']
nosy_count = 1.0
nosy_names = ['amaury.forgeotdarc']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue4542'
versions = ['Python 3.0']
@amauryfa
Copy link
Member Author

amauryfa commented Dec 5, 2008

issue bpo-4387 (67472) changed binascii and added tests, but the windows
specific implementation was not changed. Change is trivial:

Index: Modules/binascii.c
===================================================================

--- Modules/binascii.c  (revision 67538)
+++ Modules/binascii.c  (working copy)
@@ -1019,7 +1019,7 @@
        Py_ssize_t len;
        unsigned int result;
-       if ( !PyArg_ParseTuple(args, "s*|I:crc32", &pbin, &crc) )
+       if ( !PyArg_ParseTuple(args, "y*|I:crc32", &pbin, &crc) )
                return NULL;
        bin_data = pbin.buf;
        len = pbin.len;

@amauryfa
Copy link
Member Author

amauryfa commented Dec 5, 2008

Fixed in r67541 (py3k) and r67542 (release30-maint)

@amauryfa amauryfa closed this as completed Dec 5, 2008
@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy OS-windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@amauryfa