Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mimetypes for Subtitle Files #89574

Open
Josephine-Marie mannequin opened this issue Oct 8, 2021 · 6 comments
Open

Add Mimetypes for Subtitle Files #89574

Josephine-Marie mannequin opened this issue Oct 8, 2021 · 6 comments
Labels
3.9 only security fixes 3.10 only security fixes 3.11 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@Josephine-Marie
Copy link
Mannequin

Josephine-Marie mannequin commented Oct 8, 2021

BPO 45411
Nosy @merwok, @serhiy-storchaka, @JulienPalard, @Josephine-Marie
PRs
  • bpo-45411: Update mimetypes.py #28792
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2021-10-08.11:25:40.955>
labels = ['type-feature', 'library', '3.9', '3.10', '3.11']
title = 'Add Mimetypes for Subtitle Files'
updated_at = <Date 2021-10-12.15:36:05.746>
user = 'https://github.com/Josephine-Marie'

    bugs.python.org fields:

    activity = <Date 2021-10-12.15:36:05.746>
actor = 'eric.araujo'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2021-10-08.11:25:40.955>
creator = 'Josephine-Marie'
dependencies = []
files = []
hgrepos = []
issue_num = 45411
keywords = []
message_count = 6.0
messages = ['403468', '403469', '403470', '403478', '403650', '403739']
nosy_count = 4.0
nosy_names = ['eric.araujo', 'serhiy.storchaka', 'mdk', 'Josephine-Marie']
pr_nums = ['28792']
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue45411'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']
    @Josephine-Marie
    Copy link
    Mannequin Author

    Josephine-Marie mannequin commented Oct 8, 2021

    Since Python is used for webdevelopment, it would be very beneficial for developers to have subtitle files as default mimetypes.

    @Josephine-Marie Josephine-Marie mannequin added 3.7 (EOL) end of life 3.8 only security fixes 3.10 only security fixes 3.11 only security fixes 3.9 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Oct 8, 2021
    @serhiy-storchaka
    Copy link
    Member

    What standard specifies these MIME types?

    @Josephine-Marie
    Copy link
    Mannequin Author

    Josephine-Marie mannequin commented Oct 8, 2021

    text/vtt is has IANA registration
    https://www.iana.org/assignments/media-types/text/vtt
    and .srt is plain/text https://www.matroska.org/technical/subtitles.html#srt-subtitles

    @JulienPalard
    Copy link
    Member

    Those two looks legit to me.

    @JulienPalard
    Copy link
    Member

    New changeset d74da9e by Josephine-Marie in branch 'main':
    bpo-45411: Update mimetypes.py (GH-28792)
    d74da9e

    @merwok
    Copy link
    Member

    merwok commented Oct 12, 2021

    Additions to mimetypes have been backported in the past, with the thought that these are not new behaviour added but only entries in a registry (and bringing the python module in line with external data sources) so there’s value and no risk in releasing these additions in point releases.

    I don’t have a link to the discussion about that, and looking at 4 or 5 recent PRs to mimetype I see that backports haven’t been consistent. So maybe another ticket would be to synchronize the dicts in active branches + record the backport policy somewhere (not sure a comment would be enough, easy to miss at the top of a long dict).

    @merwok merwok removed 3.7 (EOL) end of life 3.8 only security fixes labels Oct 12, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.9 only security fixes 3.10 only security fixes 3.11 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @JulienPalard @merwok @serhiy-storchaka