Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reference leak from descr_check #89548

Closed
corona10 opened this issue Oct 6, 2021 · 5 comments
Closed

Fix reference leak from descr_check #89548

corona10 opened this issue Oct 6, 2021 · 5 comments
Labels
3.9 only security fixes 3.10 only security fixes 3.11 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement

Comments

@corona10
Copy link
Member

corona10 commented Oct 6, 2021

BPO 45385
Nosy @vstinner, @corona10, @miss-islington, @Fidget-Spinner
PRs
  • bpo-45385: Fix reference leak from descr_check #28719
  • [3.10] bpo-45385: Fix reference leak from descr_check (GH-28719) #28779
  • [3.9] bpo-45385: Fix reference leak from descr_check (GH-28719) #28780
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2021-10-07.02:10:47.580>
created_at = <Date 2021-10-06.00:42:57.975>
labels = ['interpreter-core', 'type-feature', '3.9', '3.10', '3.11']
title = 'Fix reference leak from descr_check'
updated_at = <Date 2021-10-07.07:48:15.915>
user = 'https://github.com/corona10'

    bugs.python.org fields:

    activity = <Date 2021-10-07.07:48:15.915>
actor = 'corona10'
assignee = 'none'
closed = True
closed_date = <Date 2021-10-07.02:10:47.580>
closer = 'corona10'
components = ['Interpreter Core']
creation = <Date 2021-10-06.00:42:57.975>
creator = 'corona10'
dependencies = []
files = []
hgrepos = []
issue_num = 45385
keywords = ['patch']
message_count = 5.0
messages = ['403282', '403306', '403342', '403345', '403355']
nosy_count = 4.0
nosy_names = ['vstinner', 'corona10', 'miss-islington', 'kj']
pr_nums = ['28719', '28779', '28780']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue45385'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']
    @corona10
    Copy link
    Member Author

    corona10 commented Oct 6, 2021

    Report from @kj: #28719 (comment)

    @corona10 corona10 added 3.9 only security fixes 3.10 only security fixes 3.11 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement labels Oct 6, 2021
    @corona10
    Copy link
    Member Author

    corona10 commented Oct 6, 2021

    Compiler warnings from PR 28572:

    Objects/descrobject.c#L183
    ‘res’ may be used uninitialized in this function [-Wmaybe-uninitialized]

    Objects/descrobject.c#L201
    ‘res’ may be used uninitialized in this function [-Wmaybe-uninitialized]

    Objects/descrobject.c#L217
    ‘res’ may be used uninitialized in this function [-Wmaybe-uninitialized]

    @corona10 corona10 changed the title Fix possible reference leak from descr_check Fix reference leak from descr_check Oct 6, 2021
    @corona10 corona10 changed the title Fix possible reference leak from descr_check Fix reference leak from descr_check Oct 6, 2021
    @corona10
    Copy link
    Member Author

    corona10 commented Oct 7, 2021

    New changeset e6ff4eb by Dong-hee Na in branch 'main':
    bpo-45385: Fix reference leak from descr_check (bpo-28719)
    e6ff4eb

    @corona10
    Copy link
    Member Author

    corona10 commented Oct 7, 2021

    New changeset 660718d by Dong-hee Na in branch '3.9':
    [3.9] bpo-45385: Fix reference leak from descr_check (GH-28719) (GH-28780)
    660718d

    @corona10 corona10 closed this as completed Oct 7, 2021
    @corona10 corona10 closed this as completed Oct 7, 2021
    @corona10
    Copy link
    Member Author

    corona10 commented Oct 7, 2021

    New changeset 35d4857 by Miss Islington (bot) in branch '3.10':
    bpo-45385: Fix reference leak from descr_check (GH-28719) (GH-28779)
    35d4857

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.9 only security fixes 3.10 only security fixes 3.11 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @corona10