Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors #89383

Closed
sobolevn opened this issue Sep 16, 2021 · 25 comments
Labels
3.9 only security fixes 3.10 only security fixes 3.11 only security fixes build The build process and cross-build OS-windows

Comments

@sobolevn
Copy link
Member

BPO 45220
Nosy @pfmoore, @vstinner, @tjguk, @ambv, @ericsnowcurrently, @zware, @serhiy-storchaka, @eryksun, @zooba, @miss-islington, @sobolevn
PRs
  • bpo-45220: Avoid automatically selecting the Windows 11 SDK preview when building. #28393
  • [3.10] bpo-45220: Avoid automatically selecting the Windows 11 SDK preview when building (GH-28393) #28394
  • [3.9] bpo-45220: Avoid automatically selecting the Windows 11 SDK preview when building (GH-28393) #28395
  • [3.8] bpo-45220: Avoid automatically selecting the Windows 11 SDK preview when building (GH-28393) #28622
  • bpo-45220: Remove invalid include from resource definition files on Windows #29396
  • [3.9] bpo-45220: Remove invalid include from resource definition files on Windows (GH-29396) #29405
  • [3.10] bpo-45220: Remove invalid include from resource definition files on Windows (GH-29396) #29406
  • bpo-45220: Ensure RT_MANIFEST is defined when compiling Windows resource files #29501
  • [3.9] bpo-45220: Ensure RT_MANIFEST is defined when compiling Windows resource files (GH-29501) #29503
  • [3.10] bpo-45220: Ensure RT_MANIFEST is defined when compiling Windows resource files (GH-29501) #29504
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2021-09-16.20:30:10.454>
    created_at = <Date 2021-09-16.14:45:16.501>
    labels = ['3.10', 'build', '3.9', 'OS-windows', '3.11']
    title = 'Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors'
    updated_at = <Date 2022-01-31.15:57:49.949>
    user = 'https://github.com/sobolevn'

    bugs.python.org fields:

    activity = <Date 2022-01-31.15:57:49.949>
    actor = 'steve.dower'
    assignee = 'none'
    closed = True
    closed_date = <Date 2021-09-16.20:30:10.454>
    closer = 'steve.dower'
    components = ['Build', 'Windows']
    creation = <Date 2021-09-16.14:45:16.501>
    creator = 'sobolevn'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 45220
    keywords = ['patch']
    message_count = 25.0
    messages = ['401948', '401952', '401953', '401962', '401963', '401965', '401967', '401968', '401973', '401974', '401978', '401980', '401984', '402874', '405736', '405737', '405749', '406049', '406050', '406070', '406071', '406356', '406359', '412107', '412207']
    nosy_count = 12.0
    nosy_names = ['paul.moore', 'vstinner', 'tim.golden', 'lukasz.langa', 'eric.snow', 'zach.ware', 'serhiy.storchaka', 'eryksun', 'steve.dower', 'miss-islington', 'sobolevn', 'ntrischi']
    pr_nums = ['28393', '28394', '28395', '28622', '29396', '29405', '29406', '29501', '29503', '29504']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'compile error'
    url = 'https://bugs.python.org/issue45220'
    versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

    @sobolevn
    Copy link
    Member Author

    I've started to notice that CPython's builds on Windows now simetimes fail with something like this:

    (both Azure and Github Actions are affected)

    Using "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin\msbuild.exe" (found in the Visual Studio installation)
    Using py -3.9 (found 3.9 with py.exe)
    
    D:\a\cpython\cpython>"C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin\msbuild.exe" "D:\a\cpython\cpython\PCbuild\pcbuild.proj" /t:Build /m /nologo /v:m /clp:summary /p:Configuration=Release /p:Platform=Win32 /p:IncludeExternals=true /p:IncludeCTypes=true /p:IncludeSSL=true /p:IncludeTkinter=true /p:UseTestMarker= /p:GIT="C:\Program Files\Git\bin\git.exe"          
      _freeze_module.c
      config_minimal.c
      atexitmodule.c
      faulthandler.c
      gcmodule.c
      getbuildinfo.c
      posixmodule.c
      signalmodule.c
      _tracemalloc.c
      _iomodule.c
      bufferedio.c
      bytesio.c
      fileio.c
      iobase.c
      stringio.c
      textio.c
      winconsoleio.c
      abstract.c
      accu.c
      boolobject.c
      Compiling...
      bytearrayobject.c
      bytes_methods.c
      bytesobject.c
      call.c
      capsule.c
      cellobject.c
      classobject.c
      codeobject.c
      complexobject.c
      descrobject.c
      dictobject.c
      enumobject.c
      exceptions.c
      fileobject.c
      floatobject.c
      frameobject.c
      funcobject.c
      genericaliasobject.c
      genobject.c
      interpreteridobject.c
      Compiling...
      iterobject.c
      listobject.c
      longobject.c
      memoryobject.c
      methodobject.c
      moduleobject.c
      namespaceobject.c
      object.c
      obmalloc.c
      odictobject.c
      picklebufobject.c
      rangeobject.c
      setobject.c
      sliceobject.c
      structseq.c
      tupleobject.c
      typeobject.c
      unicodectype.c
      unicodeobject.c
      unionobject.c
      Compiling...
      weakrefobject.c
      myreadline.c
      parser.c
      peg_api.c
      pegen.c
      string_parser.c
      token.c
      tokenizer.c
      getpathp.c
      invalid_parameter_handler.c
      msvcrtmodule.c
      winreg.c
      _warnings.c
      asdl.c
      ast.c
      ast_opt.c
      ast_unparse.c
      bltinmodule.c
      bootstrap_hash.c
      ceval.c
    D:\a\cpython\cpython\Python\ceval.c(3669,13): warning C4018: '>=': signed/unsigned mismatch [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]
    D:\a\cpython\cpython\Python\ceval.c(3777,13): warning C4018: '>=': signed/unsigned mismatch [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]
      Compiling...
      codecs.c
      compile.c
      context.c
      dtoa.c
      dynamic_annotations.c
      dynload_win.c
      errors.c
      fileutils.c
      formatter_unicode.c
      frame.c
      future.c
      getargs.c
      getcompiler.c
      getcopyright.c
      getopt.c
      getplatform.c
      getversion.c
      hamt.c
      hashtable.c
      import.c
      Compiling...
      importdl.c
      initconfig.c
      marshal.c
      modsupport.c
      mysnprintf.c
      mystrtoul.c
      pathconfig.c
      preconfig.c
      pyarena.c
      pyctype.c
      pyfpe.c
      pyhash.c
      pylifecycle.c
      pymath.c
      pystate.c
      pystrcmp.c
      pystrhex.c
      pystrtod.c
      Python-ast.c
      pythonrun.c
      Compiling...
      Python-tokenize.c
      pytime.c
      specialize.c
      structmember.c
      suggestions.c
      symtable.c
      sysmodule.c
      thread.c
      traceback.c
         Creating library D:\a\cpython\cpython\PCbuild\win32\_freeze_module.lib and object D:\a\cpython\cpython\PCbuild\win32\_freeze_module.exp
      Generating code
      Finished generating code
      _freeze_module.vcxproj -> D:\a\cpython\cpython\PCbuild\win32\_freeze_module.exe
      Updated files: __hello__.h
      Killing any running python.exe instances...
      Regenerate pycore_ast.h pycore_ast_state.h Python-ast.c
      D:\a\cpython\cpython\Python\Python-ast.c, D:\a\cpython\cpython\Include\internal\pycore_ast.h, D:\a\cpython\cpython\Include\internal\pycore_ast_state.h regenerated.
      Regenerate opcode.h opcode_targets.h
      Include\opcode.h regenerated from Lib\opcode.py
      Jump table written into Python\opcode_targets.h
      Regenerate token-list.inc token.h token.c token.py
      Generated sources are up to date
      Getting build info from "C:\Program Files\Git\bin\git.exe"
      Building heads/main-dirty:7dacb70 main
      _abc.c
      _bisectmodule.c
      blake2module.c
      blake2b_impl.c
      blake2s_impl.c
      _codecsmodule.c
      _collectionsmodule.c
      _contextvarsmodule.c
      _csv.c
      _functoolsmodule.c
      _heapqmodule.c
      _json.c
      _localemodule.c
      _lsprof.c
      _math.c
      _pickle.c
      _randommodule.c
      sha3module.c
      _sre.c
      _stat.c
      Compiling...
      _struct.c
      _weakref.c
      arraymodule.c
      atexitmodule.c
      audioop.c
      binascii.c
      cmathmodule.c
      _datetimemodule.c
      errnomodule.c
      faulthandler.c
      gcmodule.c
      itertoolsmodule.c
      main.c
      mathmodule.c
      md5module.c
      mmapmodule.c
      _opcode.c
      _operator.c
      posixmodule.c
      rotatingtree.c
      Compiling...
      sha1module.c
      sha256module.c
      sha512module.c
      signalmodule.c
      _statisticsmodule.c
      symtablemodule.c
      _threadmodule.c
      _tracemalloc.c
      _typingmodule.c
      timemodule.c
      xxsubtype.c
      _xxsubinterpretersmodule.c
      fileio.c
      bytesio.c
      stringio.c
      bufferedio.c
      iobase.c
      textio.c
      winconsoleio.c
      _iomodule.c
      Compiling...
      _codecs_cn.c
      _codecs_hk.c
      _codecs_iso2022.c
      _codecs_jp.c
      _codecs_kr.c
      _codecs_tw.c
      multibytecodec.c
      _winapi.c
      abstract.c
      accu.c
      boolobject.c
      bytearrayobject.c
      bytes_methods.c
      bytesobject.c
      call.c
      capsule.c
      cellobject.c
      classobject.c
      codeobject.c
      complexobject.c
      Compiling...
      descrobject.c
      dictobject.c
      enumobject.c
      exceptions.c
      fileobject.c
      floatobject.c
      frameobject.c
      funcobject.c
      genericaliasobject.c
      genobject.c
      interpreteridobject.c
      iterobject.c
      listobject.c
      longobject.c
      memoryobject.c
      methodobject.c
      moduleobject.c
      namespaceobject.c
      object.c
      obmalloc.c
      Compiling...
      odictobject.c
      picklebufobject.c
      rangeobject.c
      setobject.c
      sliceobject.c
      structseq.c
      tupleobject.c
      typeobject.c
      unicodectype.c
      unicodeobject.c
      unionobject.c
      weakrefobject.c
      myreadline.c
      tokenizer.c
      token.c
      pegen.c
      parser.c
      string_parser.c
      peg_api.c
      invalid_parameter_handler.c
      Compiling...
      winreg.c
      config.c
      getpathp.c
      msvcrtmodule.c
      pyhash.c
      _warnings.c
      asdl.c
      ast.c
      ast_opt.c
      ast_unparse.c
      bltinmodule.c
      bootstrap_hash.c
      ceval.c
    D:\a\cpython\cpython\Python\ceval.c(3669,13): warning C4018: '>=': signed/unsigned mismatch [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]
    D:\a\cpython\cpython\Python\ceval.c(3777,13): warning C4018: '>=': signed/unsigned mismatch [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]
      codecs.c
      compile.c
      context.c
      dynamic_annotations.c
      dynload_win.c
      errors.c
      fileutils.c
      Compiling...
      formatter_unicode.c
      frame.c
      frozen.c
      future.c
      getargs.c
      getcompiler.c
      getcopyright.c
      getopt.c
      getplatform.c
      getversion.c
      hamt.c
      hashtable.c
      import.c
      importdl.c
      initconfig.c
      marshal.c
      modsupport.c
      mysnprintf.c
      mystrtoul.c
      pathconfig.c
      Compiling...
      preconfig.c
      pyarena.c
      pyctype.c
      pyfpe.c
      pylifecycle.c
      pymath.c
      pytime.c
      pystate.c
      pystrcmp.c
      pystrhex.c
      pystrtod.c
      dtoa.c
      Python-ast.c
      Python-tokenize.c
      pythonrun.c
      specialize.c
      suggestions.c
      structmember.c
      symtable.c
      sysmodule.c
      Compiling...
      thread.c
      traceback.c
      zlibmodule.c
      adler32.c
      compress.c
      crc32.c
      deflate.c
      infback.c
      inffast.c
      inflate.c
      inftrees.c
      trees.c
      uncompr.c
      zutil.c
      dl_nt.c
      getbuildinfo.c
    C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\um\winnt.h(253): error RC2188: D:\a\cpython\cpython\PCbuild\obj\311win32_Release\pythoncore\RCa05056(47) : fatal error RC1116: RC terminating after preprocessor errors [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]
      
    
    Build FAILED.
    
    D:\a\cpython\cpython\Python\ceval.c(3669,13): warning C4018: '>=': signed/unsigned mismatch [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]
    D:\a\cpython\cpython\Python\ceval.c(3777,13): warning C4018: '>=': signed/unsigned mismatch [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]
    D:\a\cpython\cpython\Python\ceval.c(3669,13): warning C4018: '>=': signed/unsigned mismatch [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]
    D:\a\cpython\cpython\Python\ceval.c(3777,13): warning C4018: '>=': signed/unsigned mismatch [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]
    C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\um\winnt.h(253): error RC2188: D:\a\cpython\cpython\PCbuild\obj\311win32_Release\pythoncore\RCa05056(47) : fatal error RC1116: RC terminating after preprocessor errors [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]
        4 Warning(s)
        1 Error(s)
    

    Links:

    @sobolevn sobolevn added 3.11 only security fixes build The build process and cross-build labels Sep 16, 2021
    @vstinner
    Copy link
    Member

    It also fails on the 3.9 and 3.10 on the Windows jobs of GitHub Action.

    @vstinner vstinner added 3.9 only security fixes 3.10 only security fixes labels Sep 16, 2021
    @vstinner vstinner changed the title Windows builds sometimes fail on main branch Windows builds sometimes fail on main branch: fatal error RC1116: RC terminating after preprocessor errors Sep 16, 2021
    @vstinner vstinner changed the title Windows builds sometimes fail on main branch Windows builds sometimes fail on main branch: fatal error RC1116: RC terminating after preprocessor errors Sep 16, 2021
    @vstinner vstinner changed the title Windows builds sometimes fail on main branch: fatal error RC1116: RC terminating after preprocessor errors Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors Sep 16, 2021
    @vstinner vstinner changed the title Windows builds sometimes fail on main branch: fatal error RC1116: RC terminating after preprocessor errors Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors Sep 16, 2021
    @vstinner
    Copy link
    Member

    It may be related to bpo-45020 which recently got a change:

    New changeset 9fd87a5 by Eric Snow in branch 'main':
    bpo-45020: Revert "Drop the frozen .h files from the repo." (gh-28380)
    9fd87a5

    @ericsnowcurrently
    Copy link
    Member

    This is more likely to relate to bpo-45188, "De-couple the Windows builds from freezing modules.", for which the PR was merged yesterday:

    New changeset 09b4ad1 by Steve Dower in branch 'main':
    bpo-45188: Windows now regenerates frozen modules at the start of build instead of late (GH-28322)
    09b4ad1

    (#28322)

    @ericsnowcurrently
    Copy link
    Member

    Of course, it might also be unrelated.

    @vstinner
    Copy link
    Member

    C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\um\winnt.h(253): error RC2188: D:\a\cpython\cpython\PCbuild\obj\311win32_Release\pythoncore\RCa05056(47) : fatal error RC1116: RC terminating after preprocessor errors [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]

    Let's split it into sub-parts:

    • C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\um\winnt.h(253): error RC2188
    • D:\a\cpython\cpython\PCbuild\obj\311win32_Release\pythoncore\RCa05056(47)
    • fatal error RC1116: RC terminating after preprocessor errors
    • [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]

    RCxxxx errors are generated by the resource compiler

    C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\um\winnt.h(253)

    What is the code at line 253?

    error RC2188

    What is this error?

    311win32_Release\pythoncore\RCa05056(47)

    Is this a directory with a generated name, or is it an error code?

    fatal error RC1116

    What is this error?

    --

    Python contains the following .rc files:

    PC/pylauncher.rc
    PC/pyshellext.rc
    PC/python_exe.rc
    PC/python_nt.rc
    PC/pythonw_exe.rc
    PC/sqlite3.rc

    None of these files include winnt.h.

    In fact, "winnt.h" cannot be found in any file of the Python source code.

    PC/python_nt.rc includes PC/python_ver_rc.h which contains 3 includes:

    I'm not sure why modsupport.h is included.

    --

    I found one page mentioning RC2188 *and* RC1116 error codes together:

    https://social.msdn.microsoft.com/Forums/vstudio/en-US/7ba8eb72-12e9-4c78-af68-7f50c170040f/warning-rc4011-and-error-rc2188?forum=vclanguage

    "RCxxxx errors are generated by the resource compiler. One of your .rc files includes directly or indirectly headers that RC can't understand so you'll have to check that and remove the #includes."

    @vstinner
    Copy link
    Member

    bpo-45188: Windows now regenerates frozen modules at the start of build instead of late (GH-28322)

    Maybe the resource compiler needs a header file which is not generated yet, and so the build fails.

    In msg401948 logs, I don't see when header files are generated. This build step seems to be fully quiet.

    @vstinner
    Copy link
    Member

    This issue is serious: it prevents to merge many pull requests, it blocks the Python development workflow.

    @zooba
    Copy link
    Member

    zooba commented Sep 16, 2021

    The build order change was not backported (and should not be), so it's unrelated to the failures on 3.9 and 3.10.

    More likely this is either a problematic compiler update, or some additional data leaking into the build information (e.g. I could see this happening if someone added a UTF-8 copyright symbol somewhere instead of an escaped version).

    @zooba
    Copy link
    Member

    zooba commented Sep 16, 2021

    C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\um\winnt.h

    This appears to be the Windows 11 preview SDK, so most likely it's a bug in that. We'll obviously need some logic to not automatically upgrade to this SDK on build.

    @zooba
    Copy link
    Member

    zooba commented Sep 16, 2021

    New changeset f4b94b1 by Steve Dower in branch 'main':
    bpo-45220: Avoid automatically selecting the Windows 11 SDK preview when building (GH-28393)
    f4b94b1

    @miss-islington
    Copy link
    Contributor

    New changeset 7ad07ee by Miss Islington (bot) in branch '3.9':
    bpo-45220: Avoid automatically selecting the Windows 11 SDK preview when building (GH-28393)
    7ad07ee

    @serhiy-storchaka
    Copy link
    Member

    New changeset f798cef by Miss Islington (bot) in branch '3.10':
    bpo-45220: Avoid automatically selecting the Windows 11 SDK preview when building (GH-28393) (GH-28394)
    f798cef

    @zooba zooba closed this as completed Sep 16, 2021
    @zooba zooba closed this as completed Sep 16, 2021
    @ambv
    Copy link
    Contributor

    ambv commented Sep 29, 2021

    New changeset 456d6d9 by Miss Islington (bot) in branch '3.8':
    bpo-45220: Avoid automatically selecting the Windows 11 SDK preview when building (GH-28393) (GH-28622)
    456d6d9

    @zooba
    Copy link
    Member

    zooba commented Nov 4, 2021

    New changeset fd0c84d by Steve Dower in branch 'main':
    bpo-45220: Remove invalid include from resource definition files on Windows (GH-29396)
    fd0c84d

    @miss-islington
    Copy link
    Contributor

    New changeset 1a44d27 by Miss Islington (bot) in branch '3.9':
    bpo-45220: Remove invalid include from resource definition files on Windows (GH-29396)
    1a44d27

    @ambv
    Copy link
    Contributor

    ambv commented Nov 4, 2021

    New changeset c0f3281 by Miss Islington (bot) in branch '3.10':
    bpo-45220: Remove invalid include from resource definition files on Windows (GH-29396) (GH-29406)
    c0f3281

    @zooba
    Copy link
    Member

    zooba commented Nov 9, 2021

    New changeset a56fbad by Steve Dower in branch 'main':
    bpo-45220: Ensure RT_MANIFEST is defined when compiling Windows resource files (GH-29501)
    a56fbad

    @miss-islington
    Copy link
    Contributor

    New changeset d29f591 by Miss Islington (bot) in branch '3.10':
    bpo-45220: Ensure RT_MANIFEST is defined when compiling Windows resource files (GH-29501)
    d29f591

    @eryksun
    Copy link
    Contributor

    eryksun commented Nov 10, 2021

    Steve, instead of manually defining RT_MANIFEST, try including "winresrc.h" in the resource definition files. This SDK header includes "winuser.rh" (note the ".rh" extension), which, among other things, includes the following RC_INVOKED definitions from "winuser.h":

        #ifdef RC_INVOKED
        #define RT_MANIFEST                        24
        #define CREATEPROCESS_MANIFEST_RESOURCE_ID  1
        #define ISOLATIONAWARE_MANIFEST_RESOURCE_ID 2
        #define ISOLATIONAWARE_NOSTATICIMPORT_MANIFEST_RESOURCE_ID 3
        #define ISOLATIONPOLICY_MANIFEST_RESOURCE_ID 4
        #define ISOLATIONPOLICY_BROWSER_MANIFEST_RESOURCE_ID 5
        #define MINIMUM_RESERVED_MANIFEST_RESOURCE_ID 1   /* inclusive */
        #define MAXIMUM_RESERVED_MANIFEST_RESOURCE_ID 16  /* inclusive */
    

    @eryksun
    Copy link
    Contributor

    eryksun commented Nov 10, 2021

    Also, I suggest using CREATEPROCESS_MANIFEST_RESOURCE_ID (1) and ISOLATIONAWARE_MANIFEST_RESOURCE_ID (2) instead of hard-coded resource IDs.

    @zooba
    Copy link
    Member

    zooba commented Nov 15, 2021

    New changeset 32d14b2 by Miss Islington (bot) in branch '3.9':
    bpo-45220: Ensure RT_MANIFEST is defined when compiling Windows resource files (GH-29501)
    32d14b2

    @zooba
    Copy link
    Member

    zooba commented Nov 15, 2021

    instead of manually defining RT_MANIFEST, try including "winresrc.h" in the resource definition files

    I just wish it were documented... we can keep it in mind if another one of these pops up.

    @ntrischi
    Copy link
    Mannequin

    ntrischi mannequin commented Jan 29, 2022

    Compiling Python3.8.9 from source on Windows 10 with VS2019. Running PCBuild\build.bat, I'm getting the following issue:

    C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\um\winnt.h(253): error RC2188: C:\Python-3.8.9\PCbuild\obj\38amd64_Release\pythoncore\RCa09752(53) : fatal error RC1116: RC terminating after preprocessor errors [C:\Python-3.8.9\PCbuild\pythoncore.vcxproj]

    I noticed this issue is closed but it doesn't seem to be resolved.

    @ntrischi ntrischi mannequin added 3.8 only security fixes labels Jan 29, 2022
    @zooba
    Copy link
    Member

    zooba commented Jan 31, 2022

    It was not backported to 3.8 because that's in security fix only mode.

    @zooba zooba removed 3.8 only security fixes labels Jan 31, 2022
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.9 only security fixes 3.10 only security fixes 3.11 only security fixes build The build process and cross-build OS-windows
    Projects
    None yet
    Development

    No branches or pull requests

    9 participants