Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Haiku build fix #89326

Closed
devnexen mannequin opened this issue Sep 10, 2021 · 3 comments
Closed

Haiku build fix #89326

devnexen mannequin opened this issue Sep 10, 2021 · 3 comments
Labels
3.11 only security fixes build The build process and cross-build release-blocker stdlib Python modules in the Lib dir

Comments

@devnexen
Copy link
Mannequin

devnexen mannequin commented Sep 10, 2021

BPO 45163
Nosy @ned-deily, @serhiy-storchaka, @pablogsal, @devnexen
PRs
  • bpo-45163: haiku build fix proposal. #28269
  • bpo-45163: Restrict added libnetwork check to builds on Haiku. #28729
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2021-10-05.10:03:12.738>
created_at = <Date 2021-09-10.11:30:29.477>
labels = ['build', 'library', 'release-blocker', '3.11']
title = 'Haiku build fix'
updated_at = <Date 2021-10-05.10:03:12.737>
user = 'https://github.com/devnexen'

    bugs.python.org fields:

    activity = <Date 2021-10-05.10:03:12.737>
actor = 'pablogsal'
assignee = 'none'
closed = True
closed_date = <Date 2021-10-05.10:03:12.738>
closer = 'pablogsal'
components = ['Build', 'Library (Lib)']
creation = <Date 2021-09-10.11:30:29.477>
creator = 'devnexen'
dependencies = []
files = []
hgrepos = []
issue_num = 45163
keywords = []
message_count = 3.0
messages = ['401633', '403195', '403218']
nosy_count = 4.0
nosy_names = ['ned.deily', 'serhiy.storchaka', 'pablogsal', 'devnexen']
pr_nums = ['28269', '28729']
priority = 'release blocker'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue45163'
versions = ['Python 3.11']
    @devnexen devnexen mannequin added 3.11 only security fixes stdlib Python modules in the Lib dir build The build process and cross-build labels Sep 10, 2021
    @serhiy-storchaka
    Copy link
    Member

    New changeset 5f5b7d0 by David CARLIER in branch 'main':
    bpo-45163: Haiku build fix. (GH-28269)
    5f5b7d0

    @ned-deily
    Copy link
    Member

    Thanks for the PR. However, it did introduce a breakage in certain builds due to unconditionally adding a check for libnetwork. For example, on older releases of macOS there is no libnetwork but building on newer systems it creates a dynamic load reference to a spurious and unrelated libnetworking library which causes multi-version binaries built on newer releases, like those of the python.org macOS installers, to fail to load on older systems. PR 28729 adds a Haiku-only guard around the added configure check.

    @ned-deily ned-deily added the build The build process and cross-build label Oct 5, 2021
    @ned-deily ned-deily reopened this Oct 5, 2021
    @ned-deily ned-deily added release-blocker build The build process and cross-build labels Oct 5, 2021
    @ned-deily ned-deily reopened this Oct 5, 2021
    @pablogsal
    Copy link
    Member

    New changeset 0af08f3 by Ned Deily in branch 'main':
    bpo-45163: Restrict added libnetwork check to builds on Haiku. (GH-28729)
    0af08f3

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.11 only security fixes build The build process and cross-build release-blocker stdlib Python modules in the Lib dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @serhiy-storchaka @ned-deily @pablogsal