Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old deprecated unittest features #89325

Closed
serhiy-storchaka opened this issue Sep 10, 2021 · 6 comments · Fixed by #92556
Closed

Remove old deprecated unittest features #89325

serhiy-storchaka opened this issue Sep 10, 2021 · 6 comments · Fixed by #92556
Labels
3.12 bugs and security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@serhiy-storchaka
Copy link
Member

BPO 45162
Nosy @gpshead, @rbtcollins, @ezio-melotti, @voidspace, @serhiy-storchaka
PRs
  • bpo-45162: Remove many old deprecated unittest features #28268
  • bpo-45162: Revert "Remove many old deprecated unittest features" #30935
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2021-09-10.10:15:06.032>
labels = ['deferred-blocker', 'type-bug', 'library', '3.11']
title = 'Remove old deprecated unittest features'
updated_at = <Date 2022-01-27.04:40:24.789>
user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2022-01-27.04:40:24.789>
actor = 'gregory.p.smith'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2021-09-10.10:15:06.032>
creator = 'serhiy.storchaka'
dependencies = []
files = []
hgrepos = []
issue_num = 45162
keywords = ['patch']
message_count = 4.0
messages = ['401568', '402033', '411808', '411838']
nosy_count = 5.0
nosy_names = ['gregory.p.smith', 'rbcollins', 'ezio.melotti', 'michael.foord', 'serhiy.storchaka']
pr_nums = ['28268', '30935']
priority = 'deferred blocker'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue45162'
versions = ['Python 3.11']
    @serhiy-storchaka
    Copy link
    Member Author

    The proposed PR removes the following unittest features:

    • "fail*" and "assert*" aliases of TestCase methods.
    • Broken from start TestCase method assertDictContainsSubset().
    • Ignored TestLoader.loadTestsFromModule() parameter use_load_tests.
    • Old alias _TextTestResult of TextTestResult.

    Most features were deprecated in 3.2, "fail*" methods in 3.1, assertNotRegexpMatches in 3.5. They were kept mostly for compatibility with 2.7 (although some of them were new in Python 3 and not compatible with 2.7).

    Using deprecated assertEquals instead of assertEqual is a common error which we need to fix regularly, so removing deprecated features will not only make the current code clearer, but save as from future errors.

    @serhiy-storchaka serhiy-storchaka added type-feature A feature request or enhancement 3.11 only security fixes stdlib Python modules in the Lib dir labels Sep 10, 2021
    @serhiy-storchaka
    Copy link
    Member Author

    New changeset b0a6ede by Serhiy Storchaka in branch 'main':
    bpo-45162: Remove many old deprecated unittest features (GH-28268)
    b0a6ede

    @gpshead
    Copy link
    Member

    gpshead commented Jan 26, 2022

    Per https://mail.python.org/archives/list/python-dev@python.org/thread/GJTREADEXYAETECE5JDTPYWK4WMTKYGR/ we want to revert this change for 3.11 as it causes adoption pain for little benefit.

    To determine if we should proceed with this in 3.12 or future versions, run a stable Python with this change applied on the test suites of external projects to find regressions. (many will have been addressed by then thanks to the work by RedHat)

    and remember that those are only open source projects. Peoples internal codebases are full of use of these names and this will prevent upgrading until they take the time to address those.

    There are targeted pieces of this change that may make sense to go forward with individually. But it is easier to reason about after a rollback and consider new PRs to move those forward.

    @gpshead gpshead reopened this Jan 26, 2022
    @gpshead gpshead added deferred-blocker type-bug An unexpected behavior, bug, or error and removed type-feature A feature request or enhancement labels Jan 26, 2022
    @gpshead gpshead reopened this Jan 26, 2022
    @gpshead gpshead added deferred-blocker type-bug An unexpected behavior, bug, or error and removed type-feature A feature request or enhancement labels Jan 26, 2022
    @gpshead
    Copy link
    Member

    gpshead commented Jan 27, 2022

    New changeset b50322d by Gregory P. Smith in branch 'main':
    bpo-45162: Revert "Remove many old deprecated unittest features" (GH-30935)
    b50322d

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @serhiy-storchaka serhiy-storchaka mentioned this issue May 9, 2022
    Merged
    @pablogsal
    Copy link
    Member

    ⚠️ This issue has been updated from 'deferred-blocker' to 'release blocker' as we are past beta1. This issue will block the next release (Python 3.11.0 beta 2). ⚠️

    @serhiy-storchaka serhiy-storchaka added 3.12 bugs and security fixes and removed 3.11 only security fixes labels May 9, 2022
    @serhiy-storchaka
    Copy link
    Member Author

    It is not a blocker at all. The changes were moved from 3.11 to 3.12.

    @hugovk hugovk mentioned this issue Nov 16, 2022
    Open
    hroncok added a commit to hroncok/eventlet that referenced this issue May 17, 2023
    @hroncok
    Update unittest asserts to support Python 3.12+
    44ee235 
    Related to python/cpython#89325
    arkamar added a commit to arkamar/testresources that referenced this issue May 31, 2023
    @arkamar
    Refactor failIf to assertFalse for Python 3.12 Compatibility
    7bb62a1 
    This commit replaces deprecated failIf calls with assertFalse in the
test_resourced_test_case.py file. The failIf method was removed in
Python 3.12 [1-3].

[1] https://docs.python.org/3.12/whatsnew/3.12.html#removed
[2] python/cpython#89325
[3] python/cpython#28268

Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
    @arkamar arkamar mentioned this issue May 31, 2023
    Merged
    4383 pushed a commit to eventlet/eventlet that referenced this issue Dec 15, 2023
    @nat-goodspeed @hroncok
    @vstinner @itamarst @pythonspeed
    Fixes Python 3.12 compatilibity #817
    e51f72a 
    * Update unittest asserts to support Python 3.12+

Related to python/cpython#89325

* Update green.http.client for changes in Python 3.12

Related to python/cpython@f0b234e

Co-Authored-By: Victor Stinner <vstinner@python.org>

* Set green.thred.daemon_threads_allowed for Python 3.12+ support

Related to python/cpython@4702552

* Python 3.12+ only: Adjust for removal of ssl.wrap_socket()

Related to python/cpython@00464bb

* Python 3.12 fixes by hroncok

This PR attempts to add compatibility for older Python versions.

We draw the line at Python versions that predate ssl.SSLContext, though. The
remaining Python 2.7 documentation doesn't even mention the version at which
that was introduced.

* Allow access to global __ssl within class definition.

* Remember whether original ssl module has wrap_socket() function.

* Replace a few assertTrue() calls with assert statements.

* In GreenSSLSocket.__new__(), use cls, not self.

* Add 3.12

* Add newer versions

* Warnings don't mean the test should fail

* Fix syntax error

* Style fixes

* Simplify given we only support 3.8+

* Document 3.12 support

---------

Co-authored-by: Miro Hrončok <miro@hroncok.cz>
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Itamar Turner-Trauring <itamar@itamarst.org>
Co-authored-by: Itamar Turner-Trauring <itamar@pythonspeed.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.12 bugs and security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    Unittest issues
    Status: Done
    Milestone
    No milestone
    Development

    Successfully merging a pull request may close this issue.

    Revert "bpo-45162: Revert "Remove many old deprecated unittest features"" python/cpython
    3 participants
    @gpshead @serhiy-storchaka @pablogsal