Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyAiter_Check & PyObject_GetAiter issues #89286

Closed
1st1 opened this issue Sep 7, 2021 · 3 comments
Closed

PyAiter_Check & PyObject_GetAiter issues #89286

1st1 opened this issue Sep 7, 2021 · 3 comments
Labels
3.10 only security fixes 3.11 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) release-blocker type-bug An unexpected behavior, bug, or error

Comments

@1st1
Copy link
Member

1st1 commented Sep 7, 2021

BPO 45123
Nosy @1st1, @pablogsal, @miss-islington
PRs
  • bpo-45123: PyAiter_Check and PyObject_GetAiter fix & rename. #28194
  • [3.10] bpo-45123: PyAiter_Check and PyObject_GetAiter fix & rename. (GH-28194) #28199
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2021-09-07.11:46:00.441>
created_at = <Date 2021-09-07.04:50:40.085>
labels = ['interpreter-core', 'type-bug', 'release-blocker', '3.10', '3.11']
title = 'PyAiter_Check & PyObject_GetAiter issues'
updated_at = <Date 2021-09-07.11:46:00.441>
user = 'https://github.com/1st1'

    bugs.python.org fields:

    activity = <Date 2021-09-07.11:46:00.441>
actor = 'pablogsal'
assignee = 'none'
closed = True
closed_date = <Date 2021-09-07.11:46:00.441>
closer = 'pablogsal'
components = ['Interpreter Core']
creation = <Date 2021-09-07.04:50:40.085>
creator = 'yselivanov'
dependencies = []
files = []
hgrepos = []
issue_num = 45123
keywords = ['patch']
message_count = 3.0
messages = ['401206', '401232', '401244']
nosy_count = 3.0
nosy_names = ['yselivanov', 'pablogsal', 'miss-islington']
pr_nums = ['28194', '28199']
priority = 'release blocker'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue45123'
versions = ['Python 3.10', 'Python 3.11']
    @1st1
    Copy link
    Member Author

    1st1 commented Sep 7, 2021

    Per discussion on python-dev (also see the linked email), PyAiter_Check should only check for __anext__ existence (and not for __aiter__) to be consistent with Py_IterCheck.

    While there, I'd like to rename PyAiter_Check to PyAIter_Check and PyObject_GetAiter to PyObject_GetAIter (i -> I). First, we should apply CamelCase convention correctly, here "async" and "iter" are separate words; second, "Aiter" is marked as invalid spelling by spell checkers in IDEs which is annoying.

    See https://mail.python.org/archives/list/python-dev@python.org/message/BRHMOFPEKGQCCKEKEEKGSYDR6NOPMRCC/ for more details.

    @1st1 1st1 added 3.10 only security fixes 3.11 only security fixes release-blocker interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error labels Sep 7, 2021
    @pablogsal
    Copy link
    Member

    New changeset 2c3474a by Yury Selivanov in branch 'main':
    bpo-45123: PyAiter_Check and PyObject_GetAiter fix & rename. (GH-28194)
    2c3474a

    @pablogsal
    Copy link
    Member

    New changeset 53257cf by Miss Islington (bot) in branch '3.10':
    bpo-45123: PyAiter_Check and PyObject_GetAiter fix & rename. (GH-28194) (GH-28199)
    53257cf

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.10 only security fixes 3.11 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) release-blocker type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @1st1 @pablogsal