Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify RegressionTestResult #89220

Closed
serhiy-storchaka opened this issue Aug 31, 2021 · 5 comments
Closed

Simplify RegressionTestResult #89220

serhiy-storchaka opened this issue Aug 31, 2021 · 5 comments
Labels
3.9 only security fixes 3.10 only security fixes 3.11 only security fixes tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@serhiy-storchaka
Copy link
Member

BPO 45057
Nosy @vstinner, @rbtcollins, @ezio-melotti, @voidspace, @serhiy-storchaka, @zooba, @miss-islington
PRs
  • bpo-45057: Simplify RegressionTestResult #28081
  • [3.10] bpo-45057: Simplify RegressionTestResult (GH-28081) #28101
  • [3.9] bpo-45057: Simplify RegressionTestResult (GH-28081) #28103
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2021-09-01.06:52:03.454>
created_at = <Date 2021-08-31.07:24:28.886>
labels = ['type-feature', 'tests', '3.9', '3.10', '3.11']
title = 'Simplify RegressionTestResult'
updated_at = <Date 2021-09-01.06:52:03.454>
user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2021-09-01.06:52:03.454>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2021-09-01.06:52:03.454>
closer = 'serhiy.storchaka'
components = ['Tests']
creation = <Date 2021-08-31.07:24:28.886>
creator = 'serhiy.storchaka'
dependencies = []
files = []
hgrepos = []
issue_num = 45057
keywords = ['patch']
message_count = 5.0
messages = ['400697', '400698', '400761', '400813', '400814']
nosy_count = 7.0
nosy_names = ['vstinner', 'rbcollins', 'ezio.melotti', 'michael.foord', 'serhiy.storchaka', 'steve.dower', 'miss-islington']
pr_nums = ['28081', '28101', '28103']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue45057'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']
    @serhiy-storchaka
    Copy link
    Member Author

    RegressionTestResult is a subclass of TextTestResult, but it completely ignores the TextTestResult function of outputting results and re-implements it. The problem of this is not only duplicating the code, but that if TextTestResult is changed (for example to fix bpo-25894) the corresponding changes should be re-implemented in RegressionTestResult. And since implementations that produce the same result are different (somewhere in subtle way), it adds much work and is errorprone.

    The proposed PR removes any text output code from RegressionTestResult and allows to use TextTestResult for output.

    @serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir type-feature A feature request or enhancement labels Aug 31, 2021
    @serhiy-storchaka
    Copy link
    Member Author

    RegressionTestResult was introduced in bpo-34582.

    @serhiy-storchaka serhiy-storchaka added 3.9 only security fixes 3.10 only security fixes 3.11 only security fixes labels Aug 31, 2021
    @serhiy-storchaka
    Copy link
    Member Author

    New changeset 2b76a53 by Serhiy Storchaka in branch 'main':
    bpo-45057: Simplify RegressionTestResult (GH-28081)
    2b76a53

    @serhiy-storchaka
    Copy link
    Member Author

    New changeset e527f79 by Serhiy Storchaka in branch '3.9':
    [3.9] bpo-45057: Simplify RegressionTestResult (GH-28081) (GH-28103)
    e527f79

    @serhiy-storchaka
    Copy link
    Member Author

    New changeset 3d56272 by Miss Islington (bot) in branch '3.10':
    bpo-45057: Simplify RegressionTestResult (GH-28081) (GH-28101)
    3d56272

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.9 only security fixes 3.10 only security fixes 3.11 only security fixes tests Tests in the Lib/test dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @serhiy-storchaka