Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests fail when using pure-python instead of _asyncio #89174

Closed
mattip opened this issue Aug 26, 2021 · 5 comments
Closed

tests fail when using pure-python instead of _asyncio #89174

mattip opened this issue Aug 26, 2021 · 5 comments
Labels
3.9 only security fixes 3.10 only security fixes 3.11 bug and security fixes release-blocker topic-asyncio type-bug An unexpected behavior, bug, or error

Comments

@mattip
Copy link
Contributor

mattip commented Aug 26, 2021

BPO 45011
Nosy @asvetlov, @ambv, @serhiy-storchaka, @mattip, @1st1, @pablogsal, @miss-islington
PRs
  • bpo-45011: Fix test_asyncio without C module _asyncio #27968
  • [3.10] bpo-45011: Fix test_asyncio without C module _asyncio (GH-27968) #27969
  • [3.9] bpo-45011: Fix test_asyncio without C module _asyncio (GH-27968) #27970
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2021-08-26.18:06:38.989>
    created_at = <Date 2021-08-26.08:34:05.218>
    labels = ['type-bug', '3.9', '3.10', '3.11', 'release-blocker', 'expert-asyncio']
    title = 'tests fail when using pure-python instead of _asyncio'
    updated_at = <Date 2021-08-26.18:06:38.988>
    user = 'https://github.com/mattip'

    bugs.python.org fields:

    activity = <Date 2021-08-26.18:06:38.988>
    actor = 'lukasz.langa'
    assignee = 'none'
    closed = True
    closed_date = <Date 2021-08-26.18:06:38.989>
    closer = 'lukasz.langa'
    components = ['asyncio']
    creation = <Date 2021-08-26.08:34:05.218>
    creator = 'mattip'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 45011
    keywords = ['patch']
    message_count = 5.0
    messages = ['400322', '400333', '400343', '400345', '400361']
    nosy_count = 7.0
    nosy_names = ['asvetlov', 'lukasz.langa', 'serhiy.storchaka', 'mattip', 'yselivanov', 'pablogsal', 'miss-islington']
    pr_nums = ['27968', '27969', '27970']
    priority = 'release blocker'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue45011'
    versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

    @mattip
    Copy link
    Contributor Author

    mattip commented Aug 26, 2021

    PyPy has no asyncio c-extension module _asyncio. I see stdlib test failures when running the tests in test/test_asyncio/*.py. If I disable _asyncio in Lib/asyncio/events.py (at the end of the file) I see similar failures in CPython3.8 on Ubuntu 20.04 in

    test_buffered_proto.py test_buffered_proto_create_connection

    test_sslproto.py test_create_connection_memory_leak, test_handshake_timeout, test_start_tls_client_buf_proto_1,

    Also this test depends on _CFuture
    test_futures.py

    @serhiy-storchaka serhiy-storchaka changed the title tests fail when using pure-python instead of _asycio tests fail when using pure-python instead of _asyncio Aug 26, 2021
    @serhiy-storchaka serhiy-storchaka changed the title tests fail when using pure-python instead of _asycio tests fail when using pure-python instead of _asyncio Aug 26, 2021
    @serhiy-storchaka
    Copy link
    Member

    I do not know why asyncio.events._get_running_loop was patched in FunctionalTestCaseMixin.

    @serhiy-storchaka serhiy-storchaka added 3.9 only security fixes 3.10 only security fixes 3.11 bug and security fixes release-blocker type-bug An unexpected behavior, bug, or error labels Aug 26, 2021
    @ambv
    Copy link
    Contributor

    ambv commented Aug 26, 2021

    New changeset 7dc505b by Serhiy Storchaka in branch 'main':
    bpo-45011: Fix test_asyncio without C module _asyncio (GH-27968)
    7dc505b

    @miss-islington
    Copy link
    Contributor

    New changeset 9f814be by Miss Islington (bot) in branch '3.10':
    bpo-45011: Fix test_asyncio without C module _asyncio (GH-27968)
    9f814be

    @ambv
    Copy link
    Contributor

    ambv commented Aug 26, 2021

    New changeset 970533e by Miss Islington (bot) in branch '3.9':
    [3.9] bpo-45011: Fix test_asyncio without C module _asyncio (GH-27968) (GH-27970)
    970533e

    @ambv ambv closed this as completed Aug 26, 2021
    @ambv ambv closed this as completed Aug 26, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.9 only security fixes 3.10 only security fixes 3.11 bug and security fixes release-blocker topic-asyncio type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    4 participants