Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vectorcall on operator.itemgetter and attrgetter objects #89116

Closed
sweeneyde opened this issue Aug 19, 2021 · 3 comments
Closed

Add vectorcall on operator.itemgetter and attrgetter objects #89116

sweeneyde opened this issue Aug 19, 2021 · 3 comments
Labels
3.11 only security fixes performance Performance or resource usage stdlib Python modules in the Lib dir

Comments

@sweeneyde
Copy link
Member

BPO 44953
Nosy @sweeneyde
PRs
  • bpo-44953: Add vectorcall for itemgetter and attrgetter #27828
  • bpo-44953: Add newline at end of NEWS entry #31265
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2022-02-11.16:16:33.894>
created_at = <Date 2021-08-19.09:23:49.517>
labels = ['3.11', 'library', 'performance']
title = 'Add vectorcall on operator.itemgetter and attrgetter objects'
updated_at = <Date 2022-02-11.16:16:33.894>
user = 'https://github.com/sweeneyde'

    bugs.python.org fields:

    activity = <Date 2022-02-11.16:16:33.894>
actor = 'Dennis Sweeney'
assignee = 'none'
closed = True
closed_date = <Date 2022-02-11.16:16:33.894>
closer = 'Dennis Sweeney'
components = ['Library (Lib)']
creation = <Date 2021-08-19.09:23:49.517>
creator = 'Dennis Sweeney'
dependencies = []
files = []
hgrepos = []
issue_num = 44953
keywords = ['patch']
message_count = 3.0
messages = ['399900', '413026', '413027']
nosy_count = 1.0
nosy_names = ['Dennis Sweeney']
pr_nums = ['27828', '31265']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'performance'
url = 'https://bugs.python.org/issue44953'
versions = ['Python 3.11']
    @sweeneyde
    Copy link
    Member Author

    ## Below are my benchmarks for this change.

    from operator import itemgetter, attrgetter
from pyperf import Runner

class MyClass:
    __slots__ = "a", "b"

namespace = {'itemgetter': itemgetter,
             'attrgetter': attrgetter,
             'MyClass': MyClass,
             }

runner = Runner()
runner.timeit(
    name="itemgetter",
    setup="f = itemgetter(1); x = (1, 2, 3)",
    stmt="f(x)",
    globals=namespace
)
runner.timeit(
    name="attrgetter",
    setup="f = attrgetter('b'); x = MyClass(); x.a = x.b = 1",
    stmt="f(x)",
    globals=namespace
)

    ##### Results #####
    # itemgetter: Mean +- std dev: [operator_main] 45.3 ns +- 1.3 ns -> [operator_vec] 29.5 ns +- 0.7 ns: 1.54x faster
    # attrgetter: Mean +- std dev: [operator_main] 61.6 ns +- 1.7 ns -> [operator_vec] 43.8 ns +- 0.9 ns: 1.41x faster

    @sweeneyde sweeneyde added 3.11 only security fixes stdlib Python modules in the Lib dir performance Performance or resource usage labels Aug 19, 2021
    @sweeneyde
    Copy link
    Member Author

    New changeset 0a14506 by Dennis Sweeney in branch 'main':
    bpo-44953: Add vectorcall for itemgetter and attrgetter instances (GH-27828)
    0a14506

    @sweeneyde
    Copy link
    Member Author

    New changeset 035414a by Dennis Sweeney in branch 'main':
    bpo-44953: Add newline at end of NEWS entry (GH-31265)
    035414a

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.11 only security fixes performance Performance or resource usage stdlib Python modules in the Lib dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @sweeneyde