Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specialize BINARY_ADD using PEP 659 machinery. #89108

Closed
markshannon opened this issue Aug 18, 2021 · 2 comments
Closed

Specialize BINARY_ADD using PEP 659 machinery. #89108

markshannon opened this issue Aug 18, 2021 · 2 comments

Comments

@markshannon
Copy link
Member

BPO 44945
Nosy @markshannon
PRs
  • bpo-44945: Specialize BINARY_ADD #27967
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2021-08-27.08:57:30.218>
created_at = <Date 2021-08-18.10:11:48.404>
labels = []
title = 'Specialize BINARY_ADD using PEP 659 machinery.'
updated_at = <Date 2021-08-27.09:57:14.818>
user = 'https://github.com/markshannon'

    bugs.python.org fields:

    activity = <Date 2021-08-27.09:57:14.818>
actor = 'Mark.Shannon'
assignee = 'none'
closed = True
closed_date = <Date 2021-08-27.08:57:30.218>
closer = 'Mark.Shannon'
components = []
creation = <Date 2021-08-18.10:11:48.404>
creator = 'Mark.Shannon'
dependencies = []
files = []
hgrepos = []
issue_num = 44945
keywords = ['patch']
message_count = 2.0
messages = ['399830', '400402']
nosy_count = 1.0
nosy_names = ['Mark.Shannon']
pr_nums = ['27967']
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue44945'
versions = []
    @markshannon
    Copy link
    Member Author

    Specializing BINARY_ADD is worthwhile for two reasons:

    Specializing for ints, floats and strings may give us some small speedup.

    It removes the complex checks for the special case of extending a string, s = s + ... from the normal instruction to a specialized form.

    @markshannon
    Copy link
    Member Author

    New changeset d3eaf0c by Mark Shannon in branch 'main':
    bpo-44945: Specialize BINARY_ADD (GH-27967)
    d3eaf0c

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @markshannon