Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 2.6 fails to build with Py_NO_ENABLE_SHARED #48744

Closed
snaury mannequin opened this issue Dec 2, 2008 · 2 comments
Closed

Python 2.6 fails to build with Py_NO_ENABLE_SHARED #48744

snaury mannequin opened this issue Dec 2, 2008 · 2 comments
Assignees
@loewis
Labels
build The build process and cross-build OS-windows

Comments

@snaury
Copy link
Mannequin

snaury mannequin commented Dec 2, 2008

BPO 4494
Nosy @loewis
Files
  • python-2.6-static.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/loewis'
closed_at = <Date 2009-02-02.15:34:26.756>
created_at = <Date 2008-12-02.20:46:50.065>
labels = ['build', 'OS-windows']
title = 'Python 2.6 fails to build with Py_NO_ENABLE_SHARED'
updated_at = <Date 2009-02-02.15:34:26.755>
user = 'https://bugs.python.org/snaury'

    bugs.python.org fields:

    activity = <Date 2009-02-02.15:34:26.755>
actor = 'loewis'
assignee = 'loewis'
closed = True
closed_date = <Date 2009-02-02.15:34:26.756>
closer = 'loewis'
components = ['Windows']
creation = <Date 2008-12-02.20:46:50.065>
creator = 'snaury'
dependencies = []
files = ['12203']
hgrepos = []
issue_num = 4494
keywords = ['patch']
message_count = 2.0
messages = ['76778', '80942']
nosy_count = 2.0
nosy_names = ['loewis', 'snaury']
pr_nums = []
priority = 'high'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue4494'
versions = ['Python 2.6']
    @snaury
    Copy link
    Mannequin Author

    snaury mannequin commented Dec 2, 2008

    When building python 2.6 with Py_NO_ENABLE_SHARED compilation fails on
    PC/getpathp.c, because it uses PyWin_DLLVersionString and
    PyWin_DLLhModule unconditionally, which are implemented in PC/dl_nt.c
    only when Py_ENABLE_SHARED is defined. The attached patch fixes the
    problem by wrapping dependent parts in if #ifdef Py_ENABLE_SHARED/#endif.

    @snaury snaury mannequin added OS-windows build The build process and cross-build labels Dec 2, 2008
    @loewis loewis mannequin self-assigned this Dec 2, 2008
    @loewis
    Copy link
    Mannequin

    loewis mannequin commented Feb 2, 2009

    Thanks for the patch. Committed as r69205, r69206, r69207, r69208.

    @loewis loewis mannequin closed this as completed Feb 2, 2009
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @loewis loewis

    Labels
    build The build process and cross-build OS-windows
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    0 participants