Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable specialization stats collection when in Py_DEBUG #89053

Closed
iritkatriel opened this issue Aug 11, 2021 · 3 comments
Closed

Enable specialization stats collection when in Py_DEBUG #89053

iritkatriel opened this issue Aug 11, 2021 · 3 comments
Labels
3.11 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement

Comments

@iritkatriel
Copy link
Member

BPO 44890
Nosy @markshannon, @iritkatriel
PRs
  • bpo-44890: collect specialization stats if Py_DEBUG #27731
  • bpo-44890: Fix AMD build error #27740
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2021-08-12.11:18:06.367>
created_at = <Date 2021-08-11.15:32:36.174>
labels = ['interpreter-core', 'type-feature', '3.11']
title = 'Enable specialization stats collection when in Py_DEBUG'
updated_at = <Date 2021-08-12.14:20:48.701>
user = 'https://github.com/iritkatriel'

    bugs.python.org fields:

    activity = <Date 2021-08-12.14:20:48.701>
actor = 'iritkatriel'
assignee = 'none'
closed = True
closed_date = <Date 2021-08-12.11:18:06.367>
closer = 'iritkatriel'
components = ['Interpreter Core']
creation = <Date 2021-08-11.15:32:36.174>
creator = 'iritkatriel'
dependencies = []
files = []
hgrepos = []
issue_num = 44890
keywords = ['patch']
message_count = 3.0
messages = ['399401', '399442', '399454']
nosy_count = 2.0
nosy_names = ['Mark.Shannon', 'iritkatriel']
pr_nums = ['27731', '27740']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue44890'
versions = ['Python 3.11']
    @iritkatriel
    Copy link
    Member Author

    Always collect stats under Py_Debug, which makes them available through the python api. Printing at interpreter exit is still disabled by default.

    @iritkatriel iritkatriel added 3.11 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement labels Aug 11, 2021
    @iritkatriel iritkatriel changed the title Enable serialisation stats collection when Py_Debug Enable specialization stats collection when Py_Debug Aug 11, 2021
    @iritkatriel iritkatriel changed the title Enable serialisation stats collection when Py_Debug Enable specialization stats collection when Py_Debug Aug 11, 2021
    @iritkatriel iritkatriel changed the title Enable specialization stats collection when Py_Debug Enable specialization stats collection when in Py_DEBUG Aug 11, 2021
    @iritkatriel iritkatriel changed the title Enable specialization stats collection when Py_Debug Enable specialization stats collection when in Py_DEBUG Aug 11, 2021
    @markshannon
    Copy link
    Member

    New changeset 8ac0886 by Irit Katriel in branch 'main':
    bpo-44890: collect specialization stats if Py_DEBUG (GH-27731)
    8ac0886

    @iritkatriel
    Copy link
    Member Author

    New changeset 789a6af by Irit Katriel in branch 'main':
    bpo-44890: Fix AMD build error (GH-27740)
    789a6af

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.11 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @iritkatriel @markshannon