Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bdist_msi and bdist_wininst are missing an uninstaller icon #48730

Closed
malemburg opened this issue Dec 1, 2008 · 9 comments
Closed

bdist_msi and bdist_wininst are missing an uninstaller icon #48730

malemburg opened this issue Dec 1, 2008 · 9 comments
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@malemburg
Copy link
Member

BPO 4480
Nosy @malemburg, @loewis, @vstinner, @tarekziade, @merwok

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2021-01-11.12:51:47.311>
created_at = <Date 2008-12-01.09:05:42.867>
labels = ['type-feature', 'library']
title = 'bdist_msi and bdist_wininst are missing an uninstaller icon'
updated_at = <Date 2021-01-11.12:51:47.310>
user = 'https://github.com/malemburg'

bugs.python.org fields:

activity = <Date 2021-01-11.12:51:47.310>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2021-01-11.12:51:47.311>
closer = 'vstinner'
components = ['Distutils']
creation = <Date 2008-12-01.09:05:42.867>
creator = 'lemburg'
dependencies = []
files = []
hgrepos = []
issue_num = 4480
keywords = []
message_count = 9.0
messages = ['76680', '76692', '76693', '76694', '76695', '76702', '76706', '76712', '384823']
nosy_count = 6.0
nosy_names = ['lemburg', 'loewis', 'vstinner', 'tarek', 'eric.araujo', 'Retro']
pr_nums = []
priority = 'normal'
resolution = 'wont fix'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue4480'
versions = ['Python 3.5']
@malemburg
Copy link
Member Author

Now that bpo-4389 is fixed, it would be nice if the bdist_msi and
bdist_wininst created installers could use the same Python icon for
their uninstallers.

Note that both commands create installers that are prefixed with the
Python version, so there already is a tight binding between the Python
interpreter itself and the extensions installed using those installers.

Alternatively, perhaps we could add a way to set the icon via command
options.

@malemburg malemburg added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Dec 1, 2008
@Retro
Copy link
Mannequin

Retro mannequin commented Dec 1, 2008

Marc-Andre, why haven't you selected the version 'Python 3.0' as well? I
think it's still time to fix this for the much-anticipated Python 3.0.
The final release is coming soon, but I think it's still time. Martin v.
Löwis, please fix this bug for Python 3.0 as well. Appreciate it. Thanks.

@malemburg
Copy link
Member Author

On 2008-12-01 14:52, Retro wrote:

Retro <vinetouu@gmail.com> added the comment:

Marc-Andre, why haven't you selected the version 'Python 3.0' as well? I
think it's still time to fix this for the much-anticipated Python 3.0.
The final release is coming soon, but I think it's still time. Martin v.
Löwis, please fix this bug for Python 3.0 as well. Appreciate it. Thanks.

It's too late for new features in Python 3.0. Those will have to wait
until 3.1 gets released.

@Retro
Copy link
Mannequin

Retro mannequin commented Dec 1, 2008

Martin, I hope you have the time to fix this. I would very much
appreciate this fix.

@Retro
Copy link
Mannequin

Retro mannequin commented Dec 1, 2008

Oh, Python 3.0 is in feature freeze. I see. Too bad. Well, at least
we'll have those icons in the next release. When do you think that'll be
released? Talking about Python 3.1 of course.

@loewis
Copy link
Mannequin

loewis mannequin commented Dec 1, 2008

Retro: please don't add people to the nosy list. I don't plan to do
anything about this issue in the near future, except perhaps to review
patches that get contributed (and even that may take many months).

@Retro
Copy link
Mannequin

Retro mannequin commented Dec 1, 2008

So you are saying you won't create the icons for bdist_msi and
bdist_wininst even for future versions (2.7 and 3.1) of the Python
interpreter?

@loewis
Copy link
Mannequin

loewis mannequin commented Dec 1, 2008

So you are saying you won't create the icons for bdist_msi and
bdist_wininst even for future versions (2.7 and 3.1) of the Python
interpreter?

Yes, exactly so. I'm -1 on using the Python icon for that by default,
I'm +0 on giving the package a choice of icons (i.e. I could live
with it if it is opt-in, but I won't spend time on writing patches in
this respect).

@akitada akitada mannequin added the OS-windows label Mar 1, 2009
@akitada akitada mannequin assigned tarekziade Mar 1, 2009
@merwok merwok added OS-windows and removed stdlib Python modules in the Lib dir OS-windows labels Oct 19, 2010
@merwok merwok added stdlib Python modules in the Lib dir and removed OS-windows labels Mar 13, 2014
@vstinner
Copy link
Member

The distutils bdist_wininst command has been removed in Python 3.10: see bpo-42802.

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vstinner @merwok @malemburg