New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IMAP4 missing support for starttls #48721
Comments
In the enclosed patch, there are three changes:
|
the needed changes to library documentation if the patch is accepted |
Same comments than issue bpo-4473:
Oh, another comment:
|
As in bpo-4473: if needed, I'll redo the patch into a small As for the shutdown before close, it's needed to let the server know You don't usually configure maildrop servers to limit the number/rate of As for the last comment, I'll gladly look at your changes and try to |
As requested, I've split the patch into three parts: the first one does |
Lorenzo, do we have test cases for this? I think you should try to add |
Thanks for following-up, Bill. While I fully understand the need for unit-testing, I don't have the I tested my changes on a couple of servers I manage, one running |
For network tests like this where it is useful to test against external imap.gmail.com:993 for instance? (i don't know enough about imap to Picking another host or two from other big ISPs would also be wise in Once that is done, the tests that connect to external servers should be |
I just found out that the gmail servers don't support connections on I'm unsure if cmu.edu anonymous imap server admin's would be happy with I think I could cook-up something. |
As the tests are new, I hope sending the real file is the right way to |
Why can't we use python.org for tests? Do we need IMAP/POP servers |
I brought this up on pydotorg, and Barry suggests that someone put |
I've committed some of the remote tests in r86380, which also helped me fix a bug in login() in 3.x. |
The shutdown change was committed in r86383. |
Here is an updated STARTTLS patch for py3k. |
The starttls patch has been committed in r86431. Thank you very much for writing the initial patch. |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: