Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sqlite3] Remove ASCII limitation from sqlite3.Connection.create_collation() #88854

Closed
erlend-aasland opened this issue Jul 20, 2021 · 2 comments
Closed

[sqlite3] Remove ASCII limitation from sqlite3.Connection.create_collation() #88854

erlend-aasland opened this issue Jul 20, 2021 · 2 comments
Assignees
@erlend-aasland
Labels
3.11 only security fixes extension-modules C modules in the Modules dir topic-sqlite3 type-feature A feature request or enhancement

Comments

@erlend-aasland
Copy link
Contributor

BPO 44688
Nosy @encukou, @erlend-aasland
PRs
  • bpo-44688: Remove ASCII limitation from sqlite3 collation names #27395
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/erlend-aasland'
closed_at = <Date 2021-07-29.10:59:01.188>
created_at = <Date 2021-07-20.21:13:58.992>
labels = ['extension-modules', 'type-feature', '3.11']
title = '[sqlite3] Remove ASCII limitation from sqlite3.Connection.create_collation()'
updated_at = <Date 2021-07-29.10:59:01.187>
user = 'https://github.com/erlend-aasland'

    bugs.python.org fields:

    activity = <Date 2021-07-29.10:59:01.187>
actor = 'erlendaasland'
assignee = 'erlendaasland'
closed = True
closed_date = <Date 2021-07-29.10:59:01.188>
closer = 'erlendaasland'
components = ['Extension Modules']
creation = <Date 2021-07-20.21:13:58.992>
creator = 'erlendaasland'
dependencies = []
files = []
hgrepos = []
issue_num = 44688
keywords = ['patch']
message_count = 2.0
messages = ['397912', '398465']
nosy_count = 2.0
nosy_names = ['petr.viktorin', 'erlendaasland']
pr_nums = ['27395']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue44688'
versions = ['Python 3.11']
    @erlend-aasland
    Copy link
    Contributor Author

    The sqlite3.Connection.create_collation() function limits collation names to ASCII characters only. As sqlite3_create_collation_v2() (and sqlite3_create_collation()) support UTF8, there is no need for this limitation anymore.

    See #27156 (comment)

    @erlend-aasland erlend-aasland added the 3.11 only security fixes label Jul 20, 2021
    @erlend-aasland erlend-aasland self-assigned this Jul 20, 2021
    @erlend-aasland erlend-aasland added extension-modules C modules in the Modules dir type-feature A feature request or enhancement 3.11 only security fixes labels Jul 20, 2021
    @erlend-aasland erlend-aasland self-assigned this Jul 20, 2021
    @erlend-aasland erlend-aasland added extension-modules C modules in the Modules dir type-feature A feature request or enhancement labels Jul 20, 2021
    @encukou
    Copy link
    Member

    encukou commented Jul 29, 2021

    New changeset 5269c09 by Erlend Egeberg Aasland in branch 'main':
    bpo-44688: Remove ASCII limitation from sqlite3 collation names (GH-27395)
    5269c09

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @erlend-aasland erlend-aasland

    Labels
    3.11 only security fixes extension-modules C modules in the Modules dir topic-sqlite3 type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @encukou @erlend-aasland