Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pdb commands allows to add commands to invalid breakpoint #88848

Closed
akulakov opened this issue Jul 20, 2021 · 4 comments
Closed

Pdb commands allows to add commands to invalid breakpoint #88848

akulakov opened this issue Jul 20, 2021 · 4 comments
Labels
3.11 only security fixes stdlib Python modules in the Lib dir

Comments

@akulakov
Copy link
Contributor

BPO 44682
Nosy @ambv, @iritkatriel, @akulakov
PRs
  • bpo-44682: Handle invalid arg to pdb's "commands" directive #27252
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2021-07-28.16:56:30.745>
created_at = <Date 2021-07-20.04:09:05.361>
labels = ['library', '3.11']
title = 'Pdb commands allows to add commands to invalid breakpoint'
updated_at = <Date 2021-07-28.16:56:30.744>
user = 'https://github.com/akulakov'

    bugs.python.org fields:

    activity = <Date 2021-07-28.16:56:30.744>
actor = 'lukasz.langa'
assignee = 'none'
closed = True
closed_date = <Date 2021-07-28.16:56:30.745>
closer = 'lukasz.langa'
components = ['Library (Lib)']
creation = <Date 2021-07-20.04:09:05.361>
creator = 'andrei.avk'
dependencies = []
files = []
hgrepos = []
issue_num = 44682
keywords = ['patch']
message_count = 4.0
messages = ['397852', '398230', '398231', '398401']
nosy_count = 3.0
nosy_names = ['lukasz.langa', 'iritkatriel', 'andrei.avk']
pr_nums = ['27252']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue44682'
versions = ['Python 3.11']
    @akulakov
    Copy link
    Contributor Author

    breakpoint 5 does not exist:

    (Pdb) commands 5
    (com) p x
    (com)
    (com) end

    @akulakov akulakov added 3.9 only security fixes 3.10 only security fixes 3.11 only security fixes stdlib Python modules in the Lib dir labels Jul 20, 2021
    @iritkatriel
    Copy link
    Member

    Silently ignoring errors is not exactly a bug, and this change might break some scripts. So I think we should not backport it.

    @iritkatriel iritkatriel removed 3.9 only security fixes 3.10 only security fixes labels Jul 26, 2021
    @akulakov
    Copy link
    Contributor Author

    I agree not backporting is most likely fine; just want to add that the issue here is that it allows you to enter command for an invalid breakpoint, creating a strong impression both that bpoint is valid and that command will be active.

    @ambv
    Copy link
    Contributor

    ambv commented Jul 28, 2021

    New changeset 53b9458 by andrei kulakov in branch 'main':
    bpo-44682: Handle invalid arg to pdb's "commands" directive (bpo-27252)
    53b9458

    @ambv ambv closed this as completed Jul 28, 2021
    @ambv ambv closed this as completed Jul 28, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.11 only security fixes stdlib Python modules in the Lib dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @ambv @akulakov @iritkatriel