Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interpreter can execute quickened opcodes in tracing mode #88747

Closed
markshannon opened this issue Jul 7, 2021 · 2 comments
Closed

Interpreter can execute quickened opcodes in tracing mode #88747

markshannon opened this issue Jul 7, 2021 · 2 comments
Assignees
@markshannon
Labels
3.11 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Comments

@markshannon
Copy link
Member

BPO 44581
Nosy @markshannon, @Fidget-Spinner
PRs
  • bpo-44581: Dont execute quickened instructions if tracing #27064
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/markshannon'
closed_at = <Date 2021-07-15.09:00:50.674>
created_at = <Date 2021-07-07.14:31:57.019>
labels = ['interpreter-core', 'type-bug', '3.11']
title = 'Interpreter can execute quickened opcodes in tracing mode'
updated_at = <Date 2021-07-15.09:00:50.674>
user = 'https://github.com/markshannon'

    bugs.python.org fields:

    activity = <Date 2021-07-15.09:00:50.674>
actor = 'Mark.Shannon'
assignee = 'Mark.Shannon'
closed = True
closed_date = <Date 2021-07-15.09:00:50.674>
closer = 'Mark.Shannon'
components = ['Interpreter Core']
creation = <Date 2021-07-07.14:31:57.019>
creator = 'Mark.Shannon'
dependencies = []
files = []
hgrepos = []
issue_num = 44581
keywords = ['patch']
message_count = 2.0
messages = ['397090', '397137']
nosy_count = 2.0
nosy_names = ['Mark.Shannon', 'kj']
pr_nums = ['27064']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue44581'
versions = ['Python 3.11']
    @markshannon
    Copy link
    Member Author

    This breaks a key invariant of PEP-659.

    Inserting assert(cframe.use_tracing == 0); at the top of all quickened instructions results in several failures when running the test suite.

    @markshannon markshannon added the 3.11 only security fixes label Jul 7, 2021
    @markshannon markshannon self-assigned this Jul 7, 2021
    @markshannon markshannon added interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error 3.11 only security fixes labels Jul 7, 2021
    @markshannon markshannon self-assigned this Jul 7, 2021
    @markshannon markshannon added interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error labels Jul 7, 2021
    @markshannon
    Copy link
    Member Author

    New changeset 514f76b by Mark Shannon in branch 'main':
    bpo-44581: Don't execute quickened instructions if tracing is on (GH-27064)
    514f76b

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @markshannon markshannon

    Labels
    3.11 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @markshannon