Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot build in VS 2022 #88701

Closed
zooba opened this issue Jun 29, 2021 · 4 comments
Closed

Cannot build in VS 2022 #88701

zooba opened this issue Jun 29, 2021 · 4 comments
Assignees
Labels
3.9 only security fixes 3.10 only security fixes 3.11 bug and security fixes build The build process and cross-build OS-windows

Comments

@zooba
Copy link
Member

zooba commented Jun 29, 2021

BPO 44535
Nosy @pfmoore, @tjguk, @zware, @zooba, @miss-islington
PRs
  • bpo-44535: Enable building with Visual Studio 2022 on Windows #26962
  • [3.9] bpo-44535: Enable building with Visual Studio 2022 on Windows (GH-26962) #26975
  • [3.10] bpo-44535: Enable building with Visual Studio 2022 on Windows (GH-26962) #26976
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zooba'
    closed_at = <Date 2021-06-30.19:38:30.141>
    created_at = <Date 2021-06-29.12:44:02.606>
    labels = ['3.10', 'build', '3.9', 'OS-windows', '3.11']
    title = 'Cannot build in VS 2022'
    updated_at = <Date 2021-06-30.19:38:30.141>
    user = 'https://github.com/zooba'

    bugs.python.org fields:

    activity = <Date 2021-06-30.19:38:30.141>
    actor = 'steve.dower'
    assignee = 'steve.dower'
    closed = True
    closed_date = <Date 2021-06-30.19:38:30.141>
    closer = 'steve.dower'
    components = ['Build', 'Windows']
    creation = <Date 2021-06-29.12:44:02.606>
    creator = 'steve.dower'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 44535
    keywords = ['patch']
    message_count = 4.0
    messages = ['396723', '396791', '396794', '396795']
    nosy_count = 5.0
    nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'steve.dower', 'miss-islington']
    pr_nums = ['26962', '26975', '26976']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'compile error'
    url = 'https://bugs.python.org/issue44535'
    versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

    @zooba
    Copy link
    Member Author

    zooba commented Jun 29, 2021

    The project files require an additional check in PCbuild/python.props to select the right toolset for VisualStudioVersion=17.0. Without this, everything will refuse to build.

    The toolset is still v142, so there should be not compatibility issues. The problem is in detection, not use.

    @zooba zooba added 3.9 only security fixes 3.10 only security fixes 3.11 bug and security fixes labels Jun 29, 2021
    @zooba zooba self-assigned this Jun 29, 2021
    @zooba zooba added build The build process and cross-build OS-windows 3.9 only security fixes 3.10 only security fixes 3.11 bug and security fixes labels Jun 29, 2021
    @zooba zooba self-assigned this Jun 29, 2021
    @zooba zooba added build The build process and cross-build OS-windows labels Jun 29, 2021
    @zooba
    Copy link
    Member Author

    zooba commented Jun 30, 2021

    New changeset d3a95c1 by Steve Dower in branch 'main':
    bpo-44535: Enable building with Visual Studio 2022 on Windows (GH-26962)
    d3a95c1

    @miss-islington
    Copy link
    Contributor

    New changeset 6843a3b by Miss Islington (bot) in branch '3.10':
    bpo-44535: Enable building with Visual Studio 2022 on Windows (GH-26962)
    6843a3b

    @miss-islington
    Copy link
    Contributor

    New changeset 67e3945 by Miss Islington (bot) in branch '3.9':
    bpo-44535: Enable building with Visual Studio 2022 on Windows (GH-26962)
    67e3945

    @zooba zooba closed this as completed Jun 30, 2021
    @zooba zooba closed this as completed Jun 30, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.9 only security fixes 3.10 only security fixes 3.11 bug and security fixes build The build process and cross-build OS-windows
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants