Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port LOAD_ATTR to adaptive interpreter #88503

Closed
markshannon opened this issue Jun 7, 2021 · 6 comments
Closed

Port LOAD_ATTR to adaptive interpreter #88503

markshannon opened this issue Jun 7, 2021 · 6 comments

Comments

@markshannon
Copy link
Member

BPO 44337
Nosy @gvanrossum, @markshannon, @brandtbucher, @isidentical
PRs
  • bpo-44337: Port LOAD_ATTR to PEP 659 adaptive interpreter #26595
  • bpo-44337: Remove accidentally duplicated STAT_INC #26718
  • bpo-44337: Improve LOAD_ATTR specialization #26759
  • bpo-44337: Shrink the LOAD_ATTR/STORE_ATTR caches #31517
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2021-06-10.08:38:00.603>
created_at = <Date 2021-06-07.18:03:40.390>
labels = []
title = 'Port LOAD_ATTR to adaptive interpreter'
updated_at = <Date 2022-02-23.18:53:33.400>
user = 'https://github.com/markshannon'

    bugs.python.org fields:

    activity = <Date 2022-02-23.18:53:33.400>
actor = 'brandtbucher'
assignee = 'none'
closed = True
closed_date = <Date 2021-06-10.08:38:00.603>
closer = 'Mark.Shannon'
components = []
creation = <Date 2021-06-07.18:03:40.390>
creator = 'Mark.Shannon'
dependencies = []
files = []
hgrepos = []
issue_num = 44337
keywords = ['patch']
message_count = 6.0
messages = ['395271', '395346', '395513', '396150', '396225', '413846']
nosy_count = 4.0
nosy_names = ['gvanrossum', 'Mark.Shannon', 'brandtbucher', 'BTaskaya']
pr_nums = ['26595', '26718', '26759', '31517']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue44337'
versions = []
    @markshannon
    Copy link
    Member Author

    Port the implementation of LOAD_ATTR to the new adaptive interpreter

    @isidentical
    Copy link
    Sponsor Member

    Mark would you mind sharing your opinions on this: https://bugs.python.org/issue44313 (should we still keep generating LOAD_METHOD/CALL_METHOD for potential objects imported through from x import y, or they also generate LOAD_ATTR/CALL_FUNCTION).

    @markshannon
    Copy link
    Member Author

    New changeset e117c02 by Mark Shannon in branch 'main':
    bpo-44337: Port LOAD_ATTR to PEP-659 adaptive interpreter (GH-26595)
    e117c02

    @gvanrossum
    Copy link
    Member

    (That pull request doesn't have anything to do with this issue, but while testing it I did find a crash bug that I've bisected to this issue. See #26749 (comment).)

    @markshannon
    Copy link
    Member Author

    New changeset fb68791 by Mark Shannon in branch 'main':
    bpo-44337: Improve LOAD_ATTR specialization (GH-26759)
    fb68791

    @brandtbucher
    Copy link
    Member

    New changeset 281ea9c by Brandt Bucher in branch 'main':
    bpo-44337: Shrink the LOAD_ATTR/STORE_ATTR caches (GH-31517)
    281ea9c

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    4 participants
    @gvanrossum @markshannon @brandtbucher @isidentical