Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[subinterpreters] Replace static string caches with subinterpreter-compatible alternatives #88322

Closed
Fidget-Spinner opened this issue May 17, 2021 · 3 comments
Closed

[subinterpreters] Replace static string caches with subinterpreter-compatible alternatives #88322

Fidget-Spinner opened this issue May 17, 2021 · 3 comments
Labels
3.11 only security fixes topic-subinterpreters

Comments

@Fidget-Spinner
Copy link
Member

BPO 44156
Nosy @vstinner, @ericsnowcurrently, @Fidget-Spinner
PRs
  • bpo-44156: Make cached string constants in compile.c subinterpreter compatible #26161
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2021-10-20.16:03:49.237>
created_at = <Date 2021-05-17.09:34:25.240>
labels = ['expert-subinterpreters', '3.11']
title = '[subinterpreters] Replace static string caches with subinterpreter-compatible alternatives'
updated_at = <Date 2021-10-20.16:03:49.236>
user = 'https://github.com/Fidget-Spinner'

    bugs.python.org fields:

    activity = <Date 2021-10-20.16:03:49.236>
actor = 'kj'
assignee = 'none'
closed = True
closed_date = <Date 2021-10-20.16:03:49.237>
closer = 'kj'
components = ['Subinterpreters']
creation = <Date 2021-05-17.09:34:25.240>
creator = 'kj'
dependencies = []
files = []
hgrepos = []
issue_num = 44156
keywords = ['patch']
message_count = 3.0
messages = ['393800', '394352', '404483']
nosy_count = 3.0
nosy_names = ['vstinner', 'eric.snow', 'kj']
pr_nums = ['26161']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue44156'
versions = ['Python 3.11']
    @Fidget-Spinner
    Copy link
    Member Author

    Hello, this is a meta issue for replacing cached string constants in various places with alternatives compatible with subinterpreters such as _Py_IDENTIFIER.

    Ideally the replacements should not cause any performance regression. But to be safe I would recommend starting in places that aren't "hot".

    A list of such caches can be found via a tool created by Eric: https://www.github.com/python/cpython/tree/main/Tools%2Fc-analyzer.

    Thanks everyone!

    @Fidget-Spinner Fidget-Spinner added 3.11 only security fixes labels May 17, 2021
    @vstinner
    Copy link
    Member

    New changeset 2966924 by Ken Jin in branch 'main':
    bpo-44156: Make cached string constants in compile.c subinterpreter compatible (GH-26161)
    2966924

    @Fidget-Spinner
    Copy link
    Member Author

    I'll open separate issues for other similar changes.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.11 only security fixes topic-subinterpreters
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @vstinner @Fidget-Spinner