Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hmac.update is not releasing the GIL when openssl's hmac is used #88311

Closed
gpshead opened this issue May 16, 2021 · 3 comments
Closed

hmac.update is not releasing the GIL when openssl's hmac is used #88311

gpshead opened this issue May 16, 2021 · 3 comments
Assignees
Labels
3.9 only security fixes 3.10 only security fixes 3.11 bug and security fixes extension-modules C modules in the Modules dir performance Performance or resource usage

Comments

@gpshead
Copy link
Member

gpshead commented May 16, 2021

BPO 44145
Nosy @gpshead, @tiran, @miss-islington
PRs
  • bpo-44145: Release the GIL around HMAC_Update. #26157
  • [3.10] bpo-44145: Release the GIL around HMAC_Update. (GH-26157) #26187
  • [3.9] bpo-44145: Release the GIL around HMAC_Update. (GH-26157) #26188
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/gpshead'
    closed_at = <Date 2021-07-07.15:47:58.628>
    created_at = <Date 2021-05-16.06:54:04.365>
    labels = ['extension-modules', '3.11', '3.9', '3.10', 'performance']
    title = "hmac.update is not releasing the GIL when openssl's hmac is used"
    updated_at = <Date 2021-07-07.15:47:58.627>
    user = 'https://github.com/gpshead'

    bugs.python.org fields:

    activity = <Date 2021-07-07.15:47:58.627>
    actor = 'gregory.p.smith'
    assignee = 'gregory.p.smith'
    closed = True
    closed_date = <Date 2021-07-07.15:47:58.628>
    closer = 'gregory.p.smith'
    components = ['Extension Modules']
    creation = <Date 2021-05-16.06:54:04.365>
    creator = 'gregory.p.smith'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 44145
    keywords = ['patch', '3.9regression']
    message_count = 3.0
    messages = ['393733', '393791', '393792']
    nosy_count = 3.0
    nosy_names = ['gregory.p.smith', 'christian.heimes', 'miss-islington']
    pr_nums = ['26157', '26187', '26188']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'commit review'
    status = 'closed'
    superseder = None
    type = 'performance'
    url = 'https://bugs.python.org/issue44145'
    versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

    @gpshead
    Copy link
    Member Author

    gpshead commented May 16, 2021

    This prevents parallel hmac computations.

    see michaelforney's comment left on #20129
    where the problem was introduced when adding support for using OpenSSL's HMAC implementations.

    easy fix. PR coming.

    We don't really have a way to unittest for regressions on things like this.

    @gpshead gpshead added 3.9 only security fixes 3.10 only security fixes 3.11 bug and security fixes labels May 16, 2021
    @gpshead gpshead self-assigned this May 16, 2021
    @gpshead gpshead added extension-modules C modules in the Modules dir performance Performance or resource usage 3.9 only security fixes 3.10 only security fixes 3.11 bug and security fixes labels May 16, 2021
    @gpshead gpshead self-assigned this May 16, 2021
    @gpshead gpshead added extension-modules C modules in the Modules dir performance Performance or resource usage labels May 16, 2021
    @miss-islington
    Copy link
    Contributor

    New changeset 60fa8b3 by Miss Islington (bot) in branch '3.10':
    bpo-44145: Release the GIL around HMAC_Update. (GH-26157)
    60fa8b3

    @miss-islington
    Copy link
    Contributor

    New changeset 2057ce8 by Miss Islington (bot) in branch '3.9':
    [3.9] bpo-44145: Release the GIL around HMAC_Update. (GH-26157) (GH-26188)
    2057ce8

    @gpshead gpshead closed this as completed Jul 7, 2021
    @gpshead gpshead closed this as completed Jul 7, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.9 only security fixes 3.10 only security fixes 3.11 bug and security fixes extension-modules C modules in the Modules dir performance Performance or resource usage
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants