Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In Lib\tkinter\filedialog.py, class Directory define loss a"_" #48656

Closed
lionguo mannequin opened this issue Nov 24, 2008 · 6 comments
Closed

In Lib\tkinter\filedialog.py, class Directory define loss a"_" #48656

lionguo mannequin opened this issue Nov 24, 2008 · 6 comments
Labels
release-blocker topic-tkinter

Comments

@lionguo
Copy link
Mannequin

lionguo mannequin commented Nov 24, 2008

BPO 4406
Nosy @benjaminp
Files
  • Directory_fix_subclass.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2008-12-31.14:51:32.169>
created_at = <Date 2008-11-24.09:14:38.916>
labels = ['expert-tkinter', 'release-blocker']
title = 'In Lib\\tkinter\\filedialog.py, class Directory define loss a"_"'
updated_at = <Date 2008-12-31.14:51:32.162>
user = 'https://bugs.python.org/lionguo'

    bugs.python.org fields:

    activity = <Date 2008-12-31.14:51:32.162>
actor = 'benjamin.peterson'
assignee = 'none'
closed = True
closed_date = <Date 2008-12-31.14:51:32.169>
closer = 'benjamin.peterson'
components = ['Tkinter']
creation = <Date 2008-11-24.09:14:38.916>
creator = 'lion.guo'
dependencies = []
files = ['12118']
hgrepos = []
issue_num = 4406
keywords = ['patch']
message_count = 6.0
messages = ['76312', '76317', '76319', '77285', '78607', '78610']
nosy_count = 3.0
nosy_names = ['benjamin.peterson', 'gpolo', 'lion.guo']
pr_nums = []
priority = 'release blocker'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue4406'
versions = ['Python 3.0']
    @lionguo
    Copy link
    Mannequin Author

    lionguo mannequin commented Nov 24, 2008

    In Lib\tkinter\filedialog.py, class Directory

    "class Directory(Dialog):"
    should be

    "class Directory(_Dialog):"

    @lionguo lionguo mannequin added tests Tests in the Lib/test dir stdlib Python modules in the Lib dir build The build process and cross-build and removed tests Tests in the Lib/test dir labels Nov 24, 2008
    @gpolo
    Copy link
    Mannequin

    gpolo mannequin commented Nov 24, 2008

    Actually it should be commondialog.Dialog

    @gpolo
    Copy link
    Mannequin

    gpolo mannequin commented Nov 24, 2008

    It is important to commit this actually, since right now
    tkinter.filedialog.Directory is pretty broken but also very simple to fix.

    @gpolo gpolo mannequin added topic-tkinter and removed stdlib Python modules in the Lib dir build The build process and cross-build labels Nov 24, 2008
    @lionguo
    Copy link
    Mannequin Author

    lionguo mannequin commented Dec 8, 2008

    Why didn't include this patch in python 3.0 ????

    @gpolo
    Copy link
    Mannequin

    gpolo mannequin commented Dec 31, 2008

    I'm moving this to release blocker since it went unnoticed in the 3.0
    release.

    @gpolo gpolo mannequin added the release-blocker label Dec 31, 2008
    @benjaminp
    Copy link
    Contributor

    Fixed in r68103.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    release-blocker topic-tkinter
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @benjaminp