Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SerenityOS Browser in webbrowser module #88225

Closed
linusg mannequin opened this issue May 6, 2021 · 4 comments
Closed

Support SerenityOS Browser in webbrowser module #88225

linusg mannequin opened this issue May 6, 2021 · 4 comments
Assignees
@gpshead
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@linusg
Copy link
Mannequin

linusg mannequin commented May 6, 2021

BPO 44059
Nosy @gpshead, @linusg, @miss-islington
PRs
  • bpo-44059: Register the SerenityOS Browser in the webbrowser module #25947
  • [3.10] bpo-44059: Register the SerenityOS Browser in the webbrowser module (GH-25947) #25950
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/gpshead'
closed_at = <Date 2021-05-06.23:34:37.767>
created_at = <Date 2021-05-06.14:44:55.052>
labels = ['type-feature', 'library']
title = 'Support SerenityOS Browser in webbrowser module'
updated_at = <Date 2021-05-06.23:34:37.766>
user = 'https://github.com/linusg'

    bugs.python.org fields:

    activity = <Date 2021-05-06.23:34:37.766>
actor = 'gregory.p.smith'
assignee = 'gregory.p.smith'
closed = True
closed_date = <Date 2021-05-06.23:34:37.767>
closer = 'gregory.p.smith'
components = ['Library (Lib)']
creation = <Date 2021-05-06.14:44:55.052>
creator = 'linusg'
dependencies = []
files = []
hgrepos = []
issue_num = 44059
keywords = ['patch']
message_count = 4.0
messages = ['393095', '393131', '393141', '393155']
nosy_count = 3.0
nosy_names = ['gregory.p.smith', 'linusg', 'miss-islington']
pr_nums = ['25947', '25950']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue44059'
versions = []
    @linusg
    Copy link
    Mannequin Author

    linusg mannequin commented May 6, 2021

    SerenityOS [1] maintains its own port of Python (currently 3.9.5) [2], with increasingly fewer custom patches. It has its own webbrowser (called "Browser") [3][4], which is the only browser installed by default - as a result, webbrowser.open() currently does not work out of the box. However, register()'ing the browser was straightforward [5]. The goal of this issue is to get that patch into upstream Python.

    [1] github.com/SerenityOS/serenity
    [2] https://github.com/SerenityOS/serenity/blob/master/Ports/python3
    [3] https://github.com/SerenityOS/serenity/tree/master/Userland/Applications/Browser
    [4] https://github.com/SerenityOS/serenity/blob/master/Documentation/Browser/ProcessArchitecture.md
    [5] SerenityOS/serenity@9f970c3

    @linusg linusg mannequin added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels May 6, 2021
    @gpshead
    Copy link
    Member

    gpshead commented May 6, 2021

    Quite a humorous long list of historical browsers still in the webbrowser module. This can join the list. The PR should automerge after the CI runs complete.

    @gpshead
    Copy link
    Member

    gpshead commented May 6, 2021

    New changeset fbefdaf by Miss Islington (bot) in branch '3.10':
    bpo-44059: Register the SerenityOS Browser in the webbrowser module (GH-25947) (GH-25950)
    fbefdaf

    @gpshead
    Copy link
    Member

    gpshead commented May 6, 2021

    thanks for the PR!

    @gpshead gpshead closed this as completed May 6, 2021
    @gpshead gpshead closed this as completed May 6, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @gpshead gpshead

    Labels
    stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @gpshead