Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_grammar fails if run sequentially #88161

Closed
erlend-aasland opened this issue Apr 30, 2021 · 3 comments
Closed

test_grammar fails if run sequentially #88161

erlend-aasland opened this issue Apr 30, 2021 · 3 comments
Labels
3.10 only security fixes tests Tests in the Lib/test dir

Comments

@erlend-aasland
Copy link
Contributor

BPO 43995
Nosy @pablogsal, @erlend-aasland
PRs
  • bpo-43995: Fix test_grammar #25764
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2021-04-30.23:23:34.610>
created_at = <Date 2021-04-30.22:56:43.811>
labels = ['tests', '3.10']
title = 'test_grammar fails if run sequentially'
updated_at = <Date 2021-04-30.23:23:34.609>
user = 'https://github.com/erlend-aasland'

    bugs.python.org fields:

    activity = <Date 2021-04-30.23:23:34.609>
actor = 'pablogsal'
assignee = 'none'
closed = True
closed_date = <Date 2021-04-30.23:23:34.610>
closer = 'pablogsal'
components = ['Tests']
creation = <Date 2021-04-30.22:56:43.811>
creator = 'erlendaasland'
dependencies = []
files = []
hgrepos = []
issue_num = 43995
keywords = ['patch']
message_count = 3.0
messages = ['392532', '392538', '392539']
nosy_count = 2.0
nosy_names = ['pablogsal', 'erlendaasland']
pr_nums = ['25764']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue43995'
versions = ['Python 3.10']
    @erlend-aasland
    Copy link
    Contributor Author 

    To reproduce:
$ ./python.exe -m test test_typing test_grammar
0:00:00 load avg: 1.95 Run tests sequentially
0:00:00 load avg: 1.95 [1/2] test_typing
0:00:00 load avg: 1.95 [2/2] test_grammar
test test_grammar failed -- Traceback (most recent call last):
  File "/Users/erlendaasland/src/cpython-support/Lib/test/test_grammar.py", line 396, in test_var_annot_in_module
    with self.assertRaises(NameError):
AssertionError: NameError not raised

    test_grammar failed

    == Tests result: FAILURE ==

    1 test OK.

    1 test failed:
    test_grammar

    Total duration: 969 ms
    Tests result: FAILURE

    @erlend-aasland erlend-aasland added 3.10 only security fixes tests Tests in the Lib/test dir labels Apr 30, 2021
    @pablogsal
    Copy link
    Member

    New changeset e467ec4 by Erlend Egeberg Aasland in branch 'master':
    bpo-43995: Fix reference leak in test_grammar (GH-25764)
    e467ec4

    @pablogsal
    Copy link
    Member

    Thanks for the quick fix Erlend!

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.10 only security fixes tests Tests in the Lib/test dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @pablogsal @erlend-aasland