Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that dataclasses.FrozenInstanceError derives from AttributeError #88104

Closed
ericvsmith opened this issue Apr 25, 2021 · 6 comments
Closed
Labels
3.8 only security fixes 3.9 only security fixes 3.10 only security fixes docs Documentation in the Doc dir easy

Comments

@ericvsmith
Copy link
Member

BPO 43938
Nosy @ericvsmith, @miss-islington, @Llandy3d
PRs
  • bpo-43938: improve dataclasses.FrozenInstanceError documentation #25603
  • [3.9] bpo-43938: improve dataclasses.FrozenInstanceError documentation (GH-25603) #25635
  • [3.8] bpo-43938: improve dataclasses.FrozenInstanceError documentation (GH-25603) #25636
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2021-04-26.19:37:02.370>
    created_at = <Date 2021-04-25.16:25:34.649>
    labels = ['easy', '3.8', '3.9', '3.10', 'docs']
    title = 'Document that dataclasses.FrozenInstanceError derives from AttributeError'
    updated_at = <Date 2021-04-26.19:37:02.369>
    user = 'https://github.com/ericvsmith'

    bugs.python.org fields:

    activity = <Date 2021-04-26.19:37:02.369>
    actor = 'eric.smith'
    assignee = 'docs@python'
    closed = True
    closed_date = <Date 2021-04-26.19:37:02.370>
    closer = 'eric.smith'
    components = ['Documentation']
    creation = <Date 2021-04-25.16:25:34.649>
    creator = 'eric.smith'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 43938
    keywords = ['patch', 'easy', 'newcomer friendly']
    message_count = 6.0
    messages = ['391861', '391956', '391966', '391974', '391975', '391976']
    nosy_count = 4.0
    nosy_names = ['eric.smith', 'docs@python', 'miss-islington', 'llandy3d']
    pr_nums = ['25603', '25635', '25636']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue43938'
    versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']

    @ericvsmith
    Copy link
    Member Author

    This is a newcomer friendly issue. The documentation just needs a sentence that FrozenInstanceError is derived from AttributeError.

    @ericvsmith ericvsmith added 3.8 only security fixes 3.9 only security fixes 3.10 only security fixes labels Apr 25, 2021
    @ericvsmith ericvsmith added docs Documentation in the Doc dir easy 3.8 only security fixes 3.9 only security fixes 3.10 only security fixes labels Apr 25, 2021
    @ericvsmith ericvsmith added docs Documentation in the Doc dir easy labels Apr 25, 2021
    @Llandy3d
    Copy link
    Mannequin

    Llandy3d mannequin commented Apr 26, 2021

    The CLA should be correctly signed. Using this message as a test to see if the star appears correctly after the name.

    @ericvsmith
    Copy link
    Member Author

    New changeset 8a307e4 by Llandy Riveron Del Risco in branch 'master':
    bpo-43938: improve dataclasses.FrozenInstanceError documentation (GH-25603)
    8a307e4

    @ericvsmith
    Copy link
    Member Author

    New changeset 081bfe4 by Miss Islington (bot) in branch '3.8':
    bpo-43938: improve dataclasses.FrozenInstanceError documentation (GH-25603) (GH-25636)
    081bfe4

    @ericvsmith
    Copy link
    Member Author

    New changeset c9c1dbd by Miss Islington (bot) in branch '3.9':
    bpo-43938: improve dataclasses.FrozenInstanceError documentation (GH-25603) (GH-25635)
    c9c1dbd

    @ericvsmith
    Copy link
    Member Author

    Thanks for the patch!

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.8 only security fixes 3.9 only security fixes 3.10 only security fixes docs Documentation in the Doc dir easy
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant