Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement support for validation of pattern matching ASTs #88063

Closed
isidentical opened this issue Apr 20, 2021 · 5 comments
Closed

Implement support for validation of pattern matching ASTs #88063

isidentical opened this issue Apr 20, 2021 · 5 comments
Assignees
@isidentical
Labels
3.10 only security fixes

Comments

@isidentical
Copy link
Sponsor Member

BPO 43897
Nosy @ncoghlan, @pablogsal, @miss-islington, @brandtbucher, @isidentical
PRs
  • bpo-43897: Implement AST validation for Pattern Matching #24771
  • [3.10] bpo-43897: ast validation for pattern matching nodes #27074
  • bpo-43897: Reject "_" captures and top-level MatchStar in the AST validator #27432
  • [3.10] bpo-43897: Reject "_" captures and top-level MatchStar in the AST validator (GH-27432) #27435
    		•
    Dependencies
  • bpo-43892: Make match patterns explicit in the AST
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/isidentical'
closed_at = <Date 2021-07-29.01:03:10.257>
created_at = <Date 2021-04-20.19:35:33.527>
labels = ['3.10']
title = 'Implement support for validation of pattern matching ASTs'
updated_at = <Date 2021-07-29.01:03:10.257>
user = 'https://github.com/isidentical'

    bugs.python.org fields:

    activity = <Date 2021-07-29.01:03:10.257>
actor = 'brandtbucher'
assignee = 'BTaskaya'
closed = True
closed_date = <Date 2021-07-29.01:03:10.257>
closer = 'brandtbucher'
components = []
creation = <Date 2021-04-20.19:35:33.527>
creator = 'BTaskaya'
dependencies = ['43892']
files = []
hgrepos = []
issue_num = 43897
keywords = ['patch']
message_count = 5.0
messages = ['391469', '397231', '398402', '398446', '398447']
nosy_count = 5.0
nosy_names = ['ncoghlan', 'pablogsal', 'miss-islington', 'brandtbucher', 'BTaskaya']
pr_nums = ['24771', '27074', '27432', '27435']
priority = 'critical'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue43897'
versions = ['Python 3.10']
    @isidentical
    Copy link
    Sponsor Member Author

    ASTs of case clauses for PEP-636 are not validated through PyAST_Validate right now, which might crash the Python interpreter when compiling some trees that doesn't hold the assumptions of the compiler.

    @isidentical isidentical added the 3.10 only security fixes label Apr 20, 2021
    @isidentical isidentical self-assigned this Apr 20, 2021
    @isidentical isidentical added the 3.10 only security fixes label Apr 20, 2021
    @isidentical isidentical self-assigned this Apr 20, 2021
    @pablogsal
    Copy link
    Member

    New changeset 2f76368 by Batuhan Taskaya in branch '3.10':
    [3.10] bpo-43897: ast validation for pattern matching nodes (GH-27074)
    2f76368

    @brandtbucher
    Copy link
    Member

    New changeset 31bec6f by Batuhan Taskaya in branch 'main':
    bpo-43897: AST validation for pattern matching nodes (GH24771)
    31bec6f

    @brandtbucher
    Copy link
    Member

    New changeset 8d06474 by Brandt Bucher in branch 'main':
    bpo-43897: Reject "_" captures and top-level MatchStar in the AST validator (GH-27432)
    8d06474

    @miss-islington
    Copy link
    Contributor

    New changeset 405f5c5 by Miss Islington (bot) in branch '3.10':
    [3.10] bpo-43897: Reject "_" captures and top-level MatchStar in the AST validator (GH-27432) (GH-27435)
    405f5c5

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @isidentical isidentical

    Labels
    3.10 only security fixes
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    4 participants
    @pablogsal @miss-islington @brandtbucher @isidentical