Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_logging: "OSError: [Errno 9] Bad file descriptor" logged on FreeBSD #88008

Closed
vstinner opened this issue Apr 14, 2021 · 5 comments
Closed

test_logging: "OSError: [Errno 9] Bad file descriptor" logged on FreeBSD #88008

vstinner opened this issue Apr 14, 2021 · 5 comments
Labels
3.8 only security fixes 3.9 only security fixes 3.10 only security fixes tests Tests in the Lib/test dir

Comments

@vstinner
Copy link
Member

BPO 43842
Nosy @vstinner
PRs
  • bpo-43842: Fix race condition in test_logging SMTP test #25436
  • [3.9] bpo-43842: Fix race condition in test_logging SMTP test (GH-25436) #25437
  • [3.8] bpo-43842: Fix race condition in test_logging SMTP test (GH-25436) (GH-25437) #25440
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2021-04-16.14:37:42.297>
created_at = <Date 2021-04-14.11:15:16.829>
labels = ['3.8', 'tests', '3.9', '3.10']
title = 'test_logging: "OSError: [Errno 9] Bad file descriptor" logged on FreeBSD'
updated_at = <Date 2021-04-16.14:37:42.297>
user = 'https://github.com/vstinner'

    bugs.python.org fields:

    activity = <Date 2021-04-16.14:37:42.297>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2021-04-16.14:37:42.297>
closer = 'vstinner'
components = ['Tests']
creation = <Date 2021-04-14.11:15:16.829>
creator = 'vstinner'
dependencies = []
files = []
hgrepos = []
issue_num = 43842
keywords = ['patch']
message_count = 5.0
messages = ['391057', '391186', '391187', '391200', '391204']
nosy_count = 1.0
nosy_names = ['vstinner']
pr_nums = ['25436', '25437', '25440']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue43842'
versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']
    @vstinner
    Copy link
    Member Author

    Random error seen on FreeBSD:

    0:05:54 load avg: 5.75 [340/427/1] test_logging passed -- running: test_pydoc (34.4 sec)

    Exception in thread Thread-25 (serve_forever):
Traceback (most recent call last):
  File "/usr/home/vstinner/python/master/Lib/threading.py", line 990, in _bootstrap_inner
    self.run()
  File "/usr/home/vstinner/python/master/Lib/threading.py", line 928, in run
    self._target(*self._args, **self._kwargs)
  File "/usr/home/vstinner/python/master/Lib/test/test_logging.py", line 863, in serve_forever
    asyncore.loop(poll_interval, map=self._map)
  File "/usr/home/vstinner/python/master/Lib/asyncore.py", line 203, in loop
    poll_fun(timeout, map)
  File "/usr/home/vstinner/python/master/Lib/asyncore.py", line 144, in poll
    r, w, e = select.select(r, w, e, timeout)
OSError: [Errno 9] Bad file descriptor

    @vstinner vstinner added 3.10 only security fixes tests Tests in the Lib/test dir labels Apr 14, 2021
    @vstinner
    Copy link
    Member Author

    There is a race condition. The main thread closes a file descriptor which is part of the asyncore loop "map", a thread polls on the asyncore "map" file descriptors.

    -- Main thread --

    Close a socket:

    File "/usr/home/vstinner/python/master/Lib/test/test_logging.py", line 1072, in test_basic
    server.stop()
    File "/usr/home/vstinner/python/master/Lib/test/test_logging.py", line 870, in stop
    self.close()

    -- TestSMTPServer thread --

    Wait in asyncore.loop():
                      
Exception in thread Thread-1 (serve_forever):                                                                                                                  
Traceback (most recent call last):                                             
  File "/usr/home/vstinner/python/master/Lib/threading.py", line 990, in _bootstrap_inner                                                                      
    self.run()                                                                 
  File "/usr/home/vstinner/python/master/Lib/threading.py", line 928, in run                                                                                   
    self._target(*self._args, **self._kwargs)                                  
  File "/usr/home/vstinner/python/master/Lib/test/test_logging.py", line 863, in serve_forever                                                                 
    asyncore.loop(poll_interval, map=self._map)                                
  File "/usr/home/vstinner/python/master/Lib/asyncore.py", line 211, in loop                                                                                   
    poll_fun(timeout, map)                                                     
  File "/usr/home/vstinner/python/master/Lib/asyncore.py", line 145, in poll                                                                                   
    r, w, e = select.select(r, w, e, timeout)                                  
OSError: [Errno 9] Bad file descriptor

    @vstinner
    Copy link
    Member Author

    New changeset 75ec103 by Victor Stinner in branch 'master':
    bpo-43842: Fix race condition in test_logging SMTP test (GH-25436)
    75ec103

    @vstinner
    Copy link
    Member Author

    New changeset e1903e1 by Victor Stinner in branch '3.9':
    bpo-43842: Fix race condition in test_logging SMTP test (GH-25436) (GH-25437)
    e1903e1

    @vstinner
    Copy link
    Member Author

    New changeset 816da33 by Victor Stinner in branch '3.8':
    bpo-43842: Fix race condition in test_logging SMTP test (GH-25436) (GH-25437) (GH-25440)
    816da33

    @vstinner vstinner added 3.8 only security fixes 3.9 only security fixes labels Apr 16, 2021
    @vstinner vstinner added the 3.9 only security fixes label Apr 16, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes 3.9 only security fixes 3.10 only security fixes tests Tests in the Lib/test dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @vstinner