Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A bug in ncurses.h still exists in FreeBSD 4.9 - 4.11 #48618

Closed
akitada mannequin opened this issue Nov 20, 2008 · 7 comments
Closed

A bug in ncurses.h still exists in FreeBSD 4.9 - 4.11 #48618

akitada mannequin opened this issue Nov 20, 2008 · 7 comments
Labels
build The build process and cross-build release-blocker

Comments

@akitada
Copy link
Mannequin

akitada mannequin commented Nov 20, 2008

BPO 4368
Nosy @loewis, @akitada
Files
  • configure.in.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2008-12-13.14:14:23.974>
created_at = <Date 2008-11-20.17:43:30.978>
labels = ['build', 'release-blocker']
title = 'A bug in ncurses.h still exists in FreeBSD 4.9 - 4.11'
updated_at = <Date 2008-12-13.14:14:23.962>
user = 'https://github.com/akitada'

    bugs.python.org fields:

    activity = <Date 2008-12-13.14:14:23.962>
actor = 'loewis'
assignee = 'none'
closed = True
closed_date = <Date 2008-12-13.14:14:23.974>
closer = 'loewis'
components = ['Build']
creation = <Date 2008-11-20.17:43:30.978>
creator = 'akitada'
dependencies = []
files = ['12077']
hgrepos = []
issue_num = 4368
keywords = ['patch']
message_count = 7.0
messages = ['76121', '76139', '76141', '76194', '76369', '76896', '77732']
nosy_count = 3.0
nosy_names = ['loewis', 'rpetrov', 'akitada']
pr_nums = []
priority = 'release blocker'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue4368'
versions = ['Python 2.5', 'Python 2.5.3']
    @akitada
    Copy link
    Mannequin Author

    akitada mannequin commented Nov 20, 2008

    Excerpt from configure.in

    """
    # On FreeBSD 4.8 and MacOS X 10.2, a bug in ncurses.h means that
    # it craps out if _XOPEN_EXTENDED_SOURCE is defined. Apparently,
    # this is fixed in 10.3, which identifies itself as Darwin/7.*
    # This should hopefully be fixed in FreeBSD 4.9
    FreeBSD/4.8* | Darwin/6* )
    """

    Unfotunately, this bug isn't fixed in FreeBSD 4.9 and even 4.1[01].
    Attached patch fixes this.

    Note that this fix is already included in trunk, 2.6 and 3k branches.
    See also: bpo-4204

    @akitada akitada mannequin added the build The build process and cross-build label Nov 20, 2008
    @akitada akitada mannequin changed the title a bug in ncurses.h still exist in A bug in ncurses.h still exists in FreeBSD 4.9 - 4.11 Nov 20, 2008
    @akitada akitada mannequin added the build The build process and cross-build label Nov 20, 2008
    @rpetrov
    Copy link
    Mannequin

    rpetrov mannequin commented Nov 20, 2008

    You patch is out of date. The current case is for FreeBSD/4.* .

    @rpetrov
    Copy link
    Mannequin

    rpetrov mannequin commented Nov 20, 2008

    missed target version sorry

    @akitada
    Copy link
    Mannequin Author

    akitada mannequin commented Nov 21, 2008

    Yes, that change was not merged into 2.5 branch.
    I Hope it's not yet been too late for 2.5.3.

    I confirmed this fixes the problem on FreeBSD 4.11.

    @akitada
    Copy link
    Mannequin Author

    akitada mannequin commented Nov 24, 2008

    I tested this on FreeBSD 6.3 and it worked. (release25-maint)
    waiting for review.

    @akitada
    Copy link
    Mannequin Author

    akitada mannequin commented Dec 4, 2008

    I think this patch is harmless and also deserve to be merged
    into 2.5.3 release. (As I mentioned earlier, this has been already
    merged into 3.0 and 2.6 branches)

    @loewis loewis mannequin added the release-blocker label Dec 10, 2008
    @loewis
    Copy link
    Mannequin

    loewis mannequin commented Dec 13, 2008

    Thanks for the patch. Committed as r67732.

    @loewis loewis mannequin closed this as completed Dec 13, 2008
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    build The build process and cross-build release-blocker
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    0 participants