Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 597: Fix EncodingWarning warnings in the Python stdlib #87817

Closed
methane opened this issue Mar 29, 2021 · 23 comments
Closed

PEP 597: Fix EncodingWarning warnings in the Python stdlib #87817

methane opened this issue Mar 29, 2021 · 23 comments
Labels
3.10 only security fixes

Comments

@methane
Copy link
Member

methane commented Mar 29, 2021

BPO 43651
Nosy @vstinner, @methane
PRs
  • bpo-43651: Fix EncodingWarning in test_io #25097
  • bpo-43651: Fix EncodingWarning in test_file and test_file_eintr #25109
  • bpo-43651: Fix EncodingWarning in test_warnings #25126
  • bpo-43651: Fix EncodingWarning in lib2to3/pgen2/pgen.py #25127
  • bpo-43651: Fix test_compileall with PEP 597 #25128
  • bpo-43651: PEP 597: Fix EncodingWarning in some tests #25142
  • bpo-43651: PEP 597: Fix EncodingWarning in some tests #25145
  • bpo-43651: PEP 597: Fix EncodingWarning in test_email #25158
  • bpo-43651: PEP 597: Fix EncodingWarning in test_filecmp #25159
  • bpo-43651: PEP 597: Fix EncodingWarning in some tests #25171
  • bpo-43651: PEP 597: Fix EncodingWarning in some tests #25181
  • bpo-43651: PEP 597: Fix EncodingWarning in some tests #25189
  • bpo-43651: PEP 597: Fix EncodingWarning in some tests #25190
  • bpo-43651: Fix EncodingWarning in sysconfig #25192
  • bpo-43651: PEP 597: Fix pdeps used locale encoding. #25204
  • bpo-43651: Fix EncodingWarning in pydoc. #25644
  • bpo-43651: PEP 597: Fix EncodingWarning in socket.makefile() #25645
  • bpo-43651: Fix EncodingWarning in fileinput and its test #25648
  • bpo-43651: Fix EncodingWarning in zipfile #25650
  • bpo-43651: Fix EncodingWarning in os.fdopen() and test_os #25654
  • bpo-43651: Fix EncodingWarning in tests. #25655
  • bpo-43651: Fix test_logging #25715
    		•
    Superseder
  • bpo-43510: PEP 597: Implemente encoding="locale" option and EncodingWarning
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2021-03-29.04:30:27.870>
labels = ['3.10']
title = 'PEP 597: Fix EncodingWarning warnings in the Python stdlib'
updated_at = <Date 2021-04-29.11:37:41.800>
user = 'https://github.com/methane'

    bugs.python.org fields:

    activity = <Date 2021-04-29.11:37:41.800>
actor = 'methane'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = []
creation = <Date 2021-03-29.04:30:27.870>
creator = 'methane'
dependencies = []
files = []
hgrepos = []
issue_num = 43651
keywords = ['patch']
message_count = 22.0
messages = ['389945', '389946', '390019', '390020', '390021', '390033', '390158', '390176', '390220', '390221', '390222', '390268', '390271', '390273', '390293', '392021', '392024', '392030', '392031', '392274', '392275', '392301']
nosy_count = 3.0
nosy_names = ['vstinner', 'methane', 'ttx11529']
pr_nums = ['25097', '25109', '25126', '25127', '25128', '25142', '25145', '25158', '25159', '25171', '25181', '25189', '25190', '25192', '25204', '25644', '25645', '25648', '25650', '25654', '25655', '25715']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = '43510'
type = None
url = 'https://bugs.python.org/issue43651'
versions = ['Python 3.10']
    @methane methane added the 3.10 only security fixes label Mar 29, 2021
    @vstinner vstinner changed the title PEP 597: Fix EncodingError PEP 597: Fix EncodingWarning warnings in the Python stdlib Mar 30, 2021
    @methane
    Copy link
    Member Author

    methane commented Apr 1, 2021

    New changeset 55f31be by Inada Naoki in branch 'master':
    bpo-43651: Fix EncodingWarning in test_file and test_file_eintr (GH-25109)
    55f31be

    @methane
    Copy link
    Member Author

    methane commented Apr 1, 2021

    New changeset 58cffba by Inada Naoki in branch 'master':
    bpo-43651: Fix EncodingWarning in test_io (GH-25097)
    58cffba

    @methane
    Copy link
    Member Author

    methane commented Apr 1, 2021

    New changeset 036fc7d by Inada Naoki in branch 'master':
    bpo-43651: Fix EncodingWarning in test_warnings (GH-25126)
    036fc7d

    @methane
    Copy link
    Member Author

    methane commented Apr 1, 2021

    New changeset c0ec448 by Inada Naoki in branch 'master':
    bpo-43651: Fix EncodingWarning in lib2to3/pgen2/pgen.py (GH-25127)
    c0ec448

    @methane
    Copy link
    Member Author

    methane commented Apr 2, 2021

    New changeset 8001775 by Inada Naoki in branch 'master':
    bpo-43651: Fix test_compileall with PEP-597 (GH-25128)
    8001775

    @methane
    Copy link
    Member Author

    methane commented Apr 2, 2021

    New changeset 8bbfeb3 by Inada Naoki in branch 'master':
    bpo-43651: PEP-597: Fix EncodingWarning in some tests (GH-25142)
    8bbfeb3

    @methane
    Copy link
    Member Author

    methane commented Apr 4, 2021

    New changeset 35715d1 by Inada Naoki in branch 'master':
    bpo-43651: PEP-597: Fix EncodingWarning in some tests (GH-25145)
    35715d1

    @methane
    Copy link
    Member Author

    methane commented Apr 4, 2021

    New changeset 3caea9a by Inada Naoki in branch 'master':
    bpo-43651: PEP-597: Fix EncodingWarning in some tests (GH-25171)
    3caea9a

    @methane
    Copy link
    Member Author

    methane commented Apr 5, 2021

    New changeset de522a8 by Inada Naoki in branch 'master':
    bpo-43651: PEP-597: Fix test_email (GH-25158)
    de522a8

    @methane
    Copy link
    Member Author

    methane commented Apr 5, 2021

    New changeset ee952b5 by Inada Naoki in branch 'master':
    bpo-43651: PEP-597: Fix EncodingWarning in test_filecmp (GH-25159)
    ee952b5

    @methane
    Copy link
    Member Author

    methane commented Apr 5, 2021

    New changeset c8e5eb9 by Inada Naoki in branch 'master':
    bpo-43651: PEP-597: Fix EncodingWarning in some tests (GH-25181)
    c8e5eb9

    @methane
    Copy link
    Member Author

    methane commented Apr 6, 2021

    New changeset 3d4af4a by Inada Naoki in branch 'master':
    bpo-43651: Fix EncodingWarning in sysconfig (GH-25192)
    3d4af4a

    @methane
    Copy link
    Member Author

    methane commented Apr 6, 2021

    New changeset fb78692 by Inada Naoki in branch 'master':
    bpo-43651: PEP-597: Fix EncodingWarning in some tests (GH-25189)
    fb78692

    @methane
    Copy link
    Member Author

    methane commented Apr 6, 2021

    New changeset 4663e5f by Inada Naoki in branch 'master':
    bpo-43651: PEP-597: Fix EncodingWarning in some tests (GH-25190)
    4663e5f

    @methane
    Copy link
    Member Author

    methane commented Apr 6, 2021

    New changeset 489c369 by Inada Naoki in branch 'master':
    bpo-43651: PEP-597: Fix pdeps used locale encoding (GH-25204)
    489c369

    @methane
    Copy link
    Member Author

    methane commented Apr 27, 2021

    New changeset 9dfefbe by Inada Naoki in branch 'master':
    bpo-43651: Fix EncodingWarning in pydoc. (GH-25644)
    9dfefbe

    @methane
    Copy link
    Member Author

    methane commented Apr 27, 2021

    New changeset cfe523b by Inada Naoki in branch 'master':
    bpo-43651: PEP-597: Fix socket.makefile() (GH-25645)
    cfe523b

    @methane
    Copy link
    Member Author

    methane commented Apr 27, 2021

    New changeset caae717 by Inada Naoki in branch 'master':
    bpo-43651: Fix EncodingWarning in zipfile (GH-25650)
    caae717

    @methane
    Copy link
    Member Author

    methane commented Apr 27, 2021

    New changeset 878bc8b by Inada Naoki in branch 'master':
    bpo-43651: Fix EncodingWarning in fileinput and its test (GH-25648)
    878bc8b

    @methane
    Copy link
    Member Author

    methane commented Apr 29, 2021

    New changeset fa51c0c by Inada Naoki in branch 'master':
    bpo-43651: Fix EncodingWarning in tests. (GH-25655)
    fa51c0c

    @methane
    Copy link
    Member Author

    methane commented Apr 29, 2021

    New changeset a692565 by Inada Naoki in branch 'master':
    bpo-43651: Fix EncodingWarning in os.fdopen() and test_os (GH-25654)
    a692565

    @methane
    Copy link
    Member Author

    methane commented Apr 29, 2021

    New changeset 53dd6c9 by Inada Naoki in branch 'master':
    bpo-43651: Fix test_logging (GH-25715)
    53dd6c9

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @methane methane closed this as completed May 6, 2022
    @vstinner
    Copy link
    Member

    vstinner commented May 6, 2022

    @methane methane closed this 5 hours ago

    Well done! That's a great achievement!

    @gpshead gpshead mentioned this issue Jan 19, 2023
    Merged
    gpshead added a commit to gpshead/cpython that referenced this issue Jan 19, 2023
    @gpshead
    pythongh-101144: Allow open and read_text encoding to be positional.
    a4f19a4 
    As was the behavior in 3.9 and earlier.  The fix for
python#87817 introduced an API
regression in 3.10.0b1.
    gpshead added a commit to gpshead/cpython that referenced this issue Jan 19, 2023
    @gpshead
    Explicitly handle encoding as an arg.
    e304094 
    This preserves the intent of
python#87817 while restoring the
ability to pass `encoding` as a positional argument.
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.10 only security fixes
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @vstinner @methane