Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CRT version info in msvcrt module #48615

Closed
cdavid mannequin opened this issue Nov 20, 2008 · 4 comments
Closed

Add CRT version info in msvcrt module #48615

cdavid mannequin opened this issue Nov 20, 2008 · 4 comments
Assignees
@warsaw
Labels
OS-windows release-blocker

Comments

@cdavid
Copy link
Mannequin

cdavid mannequin commented Nov 20, 2008

BPO 4365
Nosy @loewis, @warsaw
Files
  • msvcrt_version_info.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/warsaw'
closed_at = <Date 2008-12-01.04:53:13.353>
created_at = <Date 2008-11-20.15:55:43.734>
labels = ['OS-windows', 'release-blocker']
title = 'Add CRT version info in msvcrt module'
updated_at = <Date 2008-12-01.04:53:13.351>
user = 'https://bugs.python.org/cdavid'

    bugs.python.org fields:

    activity = <Date 2008-12-01.04:53:13.351>
actor = 'loewis'
assignee = 'barry'
closed = True
closed_date = <Date 2008-12-01.04:53:13.353>
closer = 'loewis'
components = ['Windows']
creation = <Date 2008-11-20.15:55:43.734>
creator = 'cdavid'
dependencies = []
files = ['12074']
hgrepos = []
issue_num = 4365
keywords = ['patch']
message_count = 4.0
messages = ['76112', '76654', '76664', '76675']
nosy_count = 3.0
nosy_names = ['loewis', 'barry', 'cdavid']
pr_nums = []
priority = 'release blocker'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue4365'
versions = ['Python 2.7']
    @cdavid
    Copy link
    Mannequin Author

    cdavid mannequin commented Nov 20, 2008

    This patch if the first part to follow discussion on python-list
    concerning problems when using distutils.config.try_run with mingw and
    manifest problems on windows for python 2.6 (or any python built with
    recent VS).

    It simply adds strings constant got the msvcrt module, so that they can
    be queried in distutils to generate manifest on the fly if needed. I
    don't know which approach is best to deal with conditional compilation:
    for now, I simply do not add the constants if the constants are not
    defined at the C level, but this does not strike as a great idea to me.

    @cdavid cdavid mannequin added the OS-windows label Nov 20, 2008
    @loewis
    Copy link
    Mannequin

    loewis mannequin commented Nov 30, 2008

    Thanks for the patch. Committed (with modifications) as r67455.

    Barry, I would like to apply this to both 2.6 and 3.0. Ok?

    @loewis loewis mannequin added the release-blocker label Nov 30, 2008
    @loewis loewis mannequin assigned warsaw Nov 30, 2008
    @warsaw
    Copy link
    Member

    warsaw commented Nov 30, 2008

    Go for it Martin.

    @loewis
    Copy link
    Mannequin

    loewis mannequin commented Dec 1, 2008

    Merged into 2.6 as r67466, Benjamin had already merged it for 3k as r67461.

    @loewis loewis mannequin closed this as completed Dec 1, 2008
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @warsaw warsaw

    Labels
    OS-windows release-blocker
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @warsaw