Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xmlrpc.client.ServerProxy silently drops query string from URI #87811

Closed
kynan mannequin opened this issue Mar 28, 2021 · 1 comment
Closed

xmlrpc.client.ServerProxy silently drops query string from URI #87811

kynan mannequin opened this issue Mar 28, 2021 · 1 comment
Labels
3.9 only security fixes 3.10 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@kynan
Copy link
Mannequin

kynan mannequin commented Mar 28, 2021

BPO 43645
Nosy @tiran, @kynan
Superseder
  • bpo-43433: xmlrpc.client ignores query in URI ("?action=xmlrpc2") since python-3.9
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2021-03-28.09:28:19.788>
created_at = <Date 2021-03-28.09:21:24.375>
labels = ['type-bug', 'library', '3.9', '3.10']
title = 'xmlrpc.client.ServerProxy silently drops query string from URI'
updated_at = <Date 2021-03-28.09:28:19.784>
user = 'https://github.com/kynan'

    bugs.python.org fields:

    activity = <Date 2021-03-28.09:28:19.784>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2021-03-28.09:28:19.788>
closer = 'serhiy.storchaka'
components = ['Library (Lib)']
creation = <Date 2021-03-28.09:21:24.375>
creator = 'kynan'
dependencies = []
files = []
hgrepos = []
issue_num = 43645
keywords = []
message_count = 1.0
messages = ['389632']
nosy_count = 2.0
nosy_names = ['christian.heimes', 'kynan']
pr_nums = []
priority = 'normal'
resolution = 'duplicate'
stage = 'resolved'
status = 'closed'
superseder = '43433'
type = 'behavior'
url = 'https://bugs.python.org/issue43645'
versions = ['Python 3.9', 'Python 3.10']
    @kynan
    Copy link
    Mannequin Author

    kynan mannequin commented Mar 28, 2021

    The change introduced in #15703 (bpo-38038) caused an (I presume unintended) behavior change that breaks some xmlrpc users: previously, the XLMRPC handler was everything after the host part of the URI (https://github.com/python/cpython/blame/32f825393e5836ab71de843596379fa3f9e23c7a/Lib/xmlrpc/client.py#L1428), but now the query string is *discarded* (https://github.com/python/cpython/blame/63298930fb531ba2bb4f23bc3b915dbf1e17e9e1/Lib/xmlrpc/client.py#L1424).

    This is known to break the XMLRPC for DokuWiki (https://www.dokuwiki.org/devel:xmlrpc), which uses query parameters for authentication: kynan/dokuwikixmlrpc#8

    @kynan kynan mannequin added 3.9 only security fixes 3.10 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels Mar 28, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.9 only security fixes 3.10 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @serhiy-storchaka