Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

turtle.textinput window is not transient #87700

Closed
quid256 mannequin opened this issue Mar 18, 2021 · 9 comments
Closed

turtle.textinput window is not transient #87700

quid256 mannequin opened this issue Mar 18, 2021 · 9 comments
Labels
3.8 only security fixes 3.9 only security fixes 3.10 only security fixes topic-tkinter type-bug An unexpected behavior, bug, or error

Comments

@quid256
Copy link
Mannequin

quid256 mannequin commented Mar 18, 2021

BPO 43534
Nosy @orsenthil, @serhiy-storchaka, @miss-islington, @E-Paine, @quid256
PRs
  • bpo-43534: fixes simpledialog not transient to default root #24916
  • bpo-43534: Make dialogs in turtle.textinput() and turtle.numinput() transitient again #24923
  • [3.9] bpo-43534: Make dialogs in turtle.textinput() and turtle.numinput() transitient again (GH-24923) #25589
  • [3.8] bpo-43534: Make dialogs in turtle.textinput() and turtle.numinput() transitient again (GH-24923) #25590
    		•
    Files
  • textinput_test.py
  • textinput.png: difference between 3.9.1 and 3.9.2
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2021-04-25.10:47:27.745>
created_at = <Date 2021-03-18.01:12:16.605>
labels = ['3.8', 'type-bug', 'expert-tkinter', '3.9', '3.10']
title = 'turtle.textinput window is not transient'
updated_at = <Date 2021-04-30.22:13:26.601>
user = 'https://github.com/quid256'

    bugs.python.org fields:

    activity = <Date 2021-04-30.22:13:26.601>
actor = 'terry.reedy'
assignee = 'none'
closed = True
closed_date = <Date 2021-04-25.10:47:27.745>
closer = 'serhiy.storchaka'
components = ['Tkinter']
creation = <Date 2021-03-18.01:12:16.605>
creator = 'quid256'
dependencies = []
files = ['49885', '49886']
hgrepos = []
issue_num = 43534
keywords = ['patch']
message_count = 9.0
messages = ['388980', '388982', '389010', '391848', '391852', '391853', '391858', '391872', '391873']
nosy_count = 6.0
nosy_names = ['orsenthil', 'serhiy.storchaka', 'miss-islington', 'epaine', 'quid256', 'jwmp5051']
pr_nums = ['24916', '24923', '25589', '25590']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue43534'
versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']
    @quid256
    Copy link
    Mannequin Author

    quid256 mannequin commented Mar 18, 2021

    When turtle.textinput is called in Python 3.9.2, the resulting dialog window is not marked as transient. This is not a problem in 3.9.1.

    The offending change seems to come from bpo-42630. Specifically, SimpleDialog.__init__ is being passed parent=None, and because of this self.transient(parent) is not being called.

    A minimal program to reproduce the bug is attached. I'm happy to submit a pull request or something if it would help, but I don't know whether it's more correct to replace parent with master in the aforementioned if statement or something else.

    @quid256 quid256 mannequin added 3.9 only security fixes topic-tkinter type-bug An unexpected behavior, bug, or error labels Mar 18, 2021
    @jwmp5051
    Copy link
    Mannequin

    jwmp5051 mannequin commented Mar 18, 2021

    I am enclosing a PNG showing the difference between 3.9.1 and 3.9.2

    In 3.9.2 the pop-up opens as a new window complete with minimise and maximise buttons, and the position is unrelated to the turtle screen.

    @E-Paine
    Copy link
    Mannequin

    E-Paine mannequin commented Mar 18, 2021

    Thank you for reporting this. The problem appears to be a regression with 3d569fd6 where the dialog tries to be transient to the user-passed parent rather than the default root. I will create a PR to hopefully rectify this.

    @E-Paine E-Paine mannequin added 3.8 only security fixes 3.10 only security fixes labels Mar 18, 2021
    @serhiy-storchaka
    Copy link
    Member

    New changeset b5adc8a by Serhiy Storchaka in branch 'master':
    bpo-43534: Make dialogs in turtle.textinput() and turtle.numinput() transitient again (GH-24923)
    b5adc8a

    @miss-islington
    Copy link
    Contributor

    New changeset 7248ce3 by Miss Islington (bot) in branch '3.9':
    bpo-43534: Make dialogs in turtle.textinput() and turtle.numinput() transitient again (GH-24923)
    7248ce3

    @miss-islington
    Copy link
    Contributor

    New changeset c70f268 by Miss Islington (bot) in branch '3.8':
    bpo-43534: Make dialogs in turtle.textinput() and turtle.numinput() transitient again (GH-24923)
    c70f268

    @serhiy-storchaka
    Copy link
    Member

    New changeset 8af929f by Serhiy Storchaka in branch 'master':
    bpo-43534: Fix the turtle module working with multiple root windows (GH-25591)
    8af929f

    @orsenthil
    Copy link
    Member

    New changeset 9ca20fd by Miss Islington (bot) in branch '3.8':
    bpo-43534: Fix the turtle module working with multiple root windows #69780
    9ca20fd

    @orsenthil
    Copy link
    Member

    New changeset b47f051 by Miss Islington (bot) in branch '3.9':
    bpo-43534: Fix the turtle module working with multiple root windows #69779
    b47f051

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes 3.9 only security fixes 3.10 only security fixes topic-tkinter type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @orsenthil @serhiy-storchaka @miss-islington