Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positives in circular import detection with from-imports #87683

Closed
pitrou opened this issue Mar 16, 2021 · 6 comments
Closed

Fix false positives in circular import detection with from-imports #87683

pitrou opened this issue Mar 16, 2021 · 6 comments
Assignees
@pitrou
Labels
3.9 only security fixes 3.10 only security fixes deferred-blocker stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@pitrou
Copy link
Member

pitrou commented Mar 16, 2021

BPO 43517
Nosy @brettcannon, @gpshead, @ncoghlan, @pitrou, @ericsnowcurrently, @serhiy-storchaka, @miss-islington, @nanjekyejoannah, @cebtenzzre
PRs
  • bpo-43517: Fix false positive in detection of circular imports #24895
  • [3.9] bpo-43517: Fix false positive in detection of circular imports (GH-24895) #24948
  • bpo-43517 (followup): Install additional test directory #24950
  • [3.9] bpo-43517 (followup): Install additional test directory (GH-24950) #24951
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/pitrou'
closed_at = <Date 2021-03-20.21:52:36.447>
created_at = <Date 2021-03-16.16:07:50.206>
labels = ['deferred-blocker', 'type-bug', 'library', '3.9', '3.10']
title = 'Fix false positives in circular import detection with from-imports'
updated_at = <Date 2021-03-20.21:52:36.447>
user = 'https://github.com/pitrou'

    bugs.python.org fields:

    activity = <Date 2021-03-20.21:52:36.447>
actor = 'pitrou'
assignee = 'pitrou'
closed = True
closed_date = <Date 2021-03-20.21:52:36.447>
closer = 'pitrou'
components = ['Library (Lib)']
creation = <Date 2021-03-16.16:07:50.206>
creator = 'pitrou'
dependencies = []
files = []
hgrepos = []
issue_num = 43517
keywords = ['patch']
message_count = 6.0
messages = ['388854', '389172', '389174', '389179', '389183', '389185']
nosy_count = 9.0
nosy_names = ['brett.cannon', 'gregory.p.smith', 'ncoghlan', 'pitrou', 'eric.snow', 'serhiy.storchaka', 'miss-islington', 'nanjekyejoannah', 'cebtenzzre']
pr_nums = ['24895', '24948', '24950', '24951']
priority = 'deferred blocker'
resolution = None
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue43517'
versions = ['Python 3.9', 'Python 3.10']
    @pitrou pitrou added 3.9 only security fixes 3.10 only security fixes deferred-blocker labels Mar 16, 2021
    @pitrou pitrou self-assigned this Mar 16, 2021
    @pitrou pitrou added stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error 3.9 only security fixes 3.10 only security fixes deferred-blocker labels Mar 16, 2021
    @pitrou pitrou self-assigned this Mar 16, 2021
    @pitrou pitrou added stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels Mar 16, 2021
    @pitrou
    Copy link
    Member Author

    pitrou commented Mar 16, 2021

    This seems to be caused by a logic error in the patch for bpo-35943.

    It has been causing multiple issues for multi-threaded and multi-process systems written in Python:

    @pitrou
    Copy link
    Member Author

    pitrou commented Mar 20, 2021

    New changeset 2fd16ef by Antoine Pitrou in branch 'master':
    bpo-43517: Fix false positive in detection of circular imports (bpo-24895)
    2fd16ef

    @miss-islington
    Copy link
    Contributor

    New changeset ac17ed6 by Antoine Pitrou in branch '3.9':
    [3.9] bpo-43517: Fix false positive in detection of circular imports (GH-24895) (GH-24948)
    ac17ed6

    @miss-islington
    Copy link
    Contributor

    New changeset 66c8adf by Antoine Pitrou in branch 'master':
    bpo-43517 (followup): Install additional test directory (GH-24950)
    66c8adf

    @gpshead
    Copy link
    Member

    gpshead commented Mar 20, 2021

    Thanks Antoine!

    @miss-islington
    Copy link
    Contributor

    New changeset 107cf07 by Antoine Pitrou in branch '3.9':
    [3.9] bpo-43517 (followup): Install additional test directory (GH-24950) (GH-24951)
    107cf07

    @pitrou pitrou closed this as completed Mar 20, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @pitrou pitrou

    Labels
    3.9 only security fixes 3.10 only security fixes deferred-blocker stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @gpshead @pitrou @miss-islington