Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to SQLite 3.35.5 in macOS and Windows #87658

Closed
erlend-aasland opened this issue Mar 14, 2021 · 27 comments
Closed

Upgrade to SQLite 3.35.5 in macOS and Windows #87658

erlend-aasland opened this issue Mar 14, 2021 · 27 comments
Labels
3.8 only security fixes 3.9 only security fixes 3.10 only security fixes OS-mac OS-windows type-feature A feature request or enhancement

Comments

@erlend-aasland
Copy link
Contributor

BPO 43492
Nosy @pfmoore, @ronaldoussoren, @tjguk, @ned-deily, @zware, @zooba, @matrixise, @miss-islington, @erlend-aasland, @shreyanavigyan
PRs
  • bpo-43492: Update macOS installer to use SQLite 3.35.5 #25640
  • bpo-43492: Upgrade Windows installer to use SQLite 3.35.5 #25641
  • [3.9] bpo-43492: Update macOS installer to use SQLite 3.35.5 (GH-25640) #25662
  • [3.8] bpo-43492: Update macOS installer to use SQLite 3.35.5 (GH-25640) #25663
  • [3.9] bpo-43492: Upgrade Windows installer to use SQLite 3.35.5 (GH-25641) #25665
  • [3.8] bpo-43492: Upgrade Windows installer to use SQLite 3.35.5 (GH-25641) #25666
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2021-04-27.19:57:52.360>
    created_at = <Date 2021-03-14.20:12:12.238>
    labels = ['OS-mac', '3.8', '3.9', '3.10', 'type-feature', 'OS-windows']
    title = 'Upgrade to SQLite 3.35.5 in macOS and Windows'
    updated_at = <Date 2021-04-27.19:57:52.359>
    user = 'https://github.com/erlend-aasland'

    bugs.python.org fields:

    activity = <Date 2021-04-27.19:57:52.359>
    actor = 'steve.dower'
    assignee = 'none'
    closed = True
    closed_date = <Date 2021-04-27.19:57:52.360>
    closer = 'steve.dower'
    components = ['macOS', 'Windows']
    creation = <Date 2021-03-14.20:12:12.238>
    creator = 'erlendaasland'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 43492
    keywords = ['patch']
    message_count = 27.0
    messages = ['388685', '388776', '389004', '389081', '389341', '389926', '390864', '390869', '390879', '391069', '391088', '391387', '391788', '391790', '391994', '392032', '392033', '392034', '392094', '392099', '392102', '392106', '392110', '392112', '392124', '392125', '392126']
    nosy_count = 11.0
    nosy_names = ['paul.moore', 'ronaldoussoren', 'tim.golden', 'ned.deily', 'zach.ware', 'steve.dower', 'matrixise', 'Big Stone', 'miss-islington', 'erlendaasland', 'shreyanavigyan']
    pr_nums = ['25640', '25641', '25662', '25663', '25665', '25666']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue43492'
    versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']

    @erlend-aasland
    Copy link
    Contributor Author

    SQLite 3.35.0 was released a couple of days ago: https://www.sqlite.org/releaselog/3_35_0.html

    Suggesting to hold off for a week or two, to see if a bug-fix release happens.

    @erlend-aasland erlend-aasland added 3.10 only security fixes OS-mac OS-windows type-feature A feature request or enhancement labels Mar 14, 2021
    @erlend-aasland
    Copy link
    Contributor Author

    Bug-fix release 3.35.1 is out bco. https://sqlite.org/src/info/1c24a659e6d7f3a1

    @erlend-aasland erlend-aasland changed the title Upgrade to SQLite 3.35.0 in macOS and Windows Upgrade to SQLite 3.35.1 in macOS and Windows Mar 15, 2021
    @erlend-aasland erlend-aasland changed the title Upgrade to SQLite 3.35.0 in macOS and Windows Upgrade to SQLite 3.35.1 in macOS and Windows Mar 15, 2021
    @erlend-aasland
    Copy link
    Contributor Author

    Bug-fix release 3.35.2 is out: https://www.sqlite.org/releaselog/3_35_2.html

    Let's wait until end of March before updating the installers.

    @erlend-aasland erlend-aasland changed the title Upgrade to SQLite 3.35.1 in macOS and Windows Upgrade to SQLite 3.35.2 in macOS and Windows Mar 18, 2021
    @erlend-aasland erlend-aasland changed the title Upgrade to SQLite 3.35.1 in macOS and Windows Upgrade to SQLite 3.35.2 in macOS and Windows Mar 18, 2021
    @erlend-aasland
    Copy link
    Contributor Author

    SQLite 3.35.3 is upcoming: https://sqlite.org/forum/forumpost/6e2b05ad62?t=h
    Seems like we'll have to wait a little bit for 3.35 to stabilise.

    @erlend-aasland
    Copy link
    Contributor Author

    FYI: https://www.sqlite.org/cgi/src/info/8de4cb984a4b019f:

    "We anticipate 3.35.3 in a few days. Hopefully there will never be a need for 3.35.4."

    @erlend-aasland erlend-aasland changed the title Upgrade to SQLite 3.35.2 in macOS and Windows Upgrade to SQLite 3.35.3 in macOS and Windows Mar 22, 2021
    @erlend-aasland erlend-aasland changed the title Upgrade to SQLite 3.35.2 in macOS and Windows Upgrade to SQLite 3.35.3 in macOS and Windows Mar 22, 2021
    @erlend-aasland
    Copy link
    Contributor Author

    Quoting Dr. R. Hipp: "There will be a fix called version 3.35.4"

    https://sqlite.org/forum/forumpost/7dbf046041519a07a0a083b8346a7d0ecb7d6fc4eca5ca23605eeb4452109d91

    @erlend-aasland erlend-aasland changed the title Upgrade to SQLite 3.35.3 in macOS and Windows Upgrade to SQLite 3.35.4 in macOS and Windows Mar 31, 2021
    @erlend-aasland erlend-aasland changed the title Upgrade to SQLite 3.35.3 in macOS and Windows Upgrade to SQLite 3.35.4 in macOS and Windows Mar 31, 2021
    @BigStone
    Copy link
    Mannequin

    BigStone mannequin commented Apr 12, 2021

    3.35.4 is there

    @zooba
    Copy link
    Member

    zooba commented Apr 12, 2021

    It's been a busy month for the SQLite team... hope they're doing okay.

    Let's give this one a few weeks, just in case.

    @erlend-aasland
    Copy link
    Contributor Author

    I agree, Steve.

    @erlend-aasland
    Copy link
    Contributor Author

    Looks like there might be a 3.35.5 release in the near future: https://sqlite.org/forum/forumpost/d36426225c?t=h

    @shreyanavigyan
    Copy link
    Mannequin

    shreyanavigyan mannequin commented Apr 14, 2021

    As @steve.dower mentioned that maybe the SQLite team is busy fixing bugs and implementing features in SQLite 3.35. But @erlendaasland, https://sqlite.org/forum/forumpost/d36426225c?t=h has a question related to SQLite 3.35.5 but there was no reply or confirmation from the SQLite team. There maybe a direct SQLite 3.36.0 instead of 3.35.5. Moreover if n o bugs are found in the upcoming SQLite 3.35 release I think it's time to implement that version of SQLite to work with python/cpython or it'll be too late and SQLite 3.36 may be released.

    @erlend-aasland
    Copy link
    Contributor Author

    SQLite 3.35.5 is out today. Let's wait until next weekend and see if fossil and forum is quiet. If they are, I'll open PRs for the installers.

    https://www.sqlite.org/releaselog/3_35_5.html

    @erlend-aasland erlend-aasland changed the title Upgrade to SQLite 3.35.4 in macOS and Windows Upgrade to SQLite 3.35.5 in macOS and Windows Apr 19, 2021
    @erlend-aasland erlend-aasland changed the title Upgrade to SQLite 3.35.4 in macOS and Windows Upgrade to SQLite 3.35.5 in macOS and Windows Apr 19, 2021
    @shreyanavigyan
    Copy link
    Mannequin

    shreyanavigyan mannequin commented Apr 24, 2021

    Do anyone notice any bug in SQLite 3.35.5? If not then I think it's time to upgrade to SQLite 3.35.5.

    @matrixise
    Copy link
    Member

    Hi Shreyan Avigyan,

    For that, you need to follow the forum of SQLite.

    https://www.sqlite.org/forum/forum

    @erlend-aasland
    Copy link
    Contributor Author

    Steve & Ned: It would be nice if we could merge the PR's just before the weekend, so we get up-to-date installers for the beta.

    FYI, the SQLite forum has been quiet, and the fossil branch has not moved.

    @shreyanavigyan
    Copy link
    Mannequin

    shreyanavigyan mannequin commented Apr 27, 2021

    Updating the source. python/cpython-source-deps#24

    @erlend-aasland
    Copy link
    Contributor Author

    Thanks Shreyan, but Steve prefers to update it himself: python/cpython-source-deps#22 (comment)

    Just having the sources in place does not really help; you need a new git tag, which can only be pushed by core devs. Better to wait for the Windows team to fix this (also less noise for them) :)

    @shreyanavigyan
    Copy link
    Mannequin

    shreyanavigyan mannequin commented Apr 27, 2021

    Ok. I'm closing python/cpython-source-deps#24 then.

    @zooba
    Copy link
    Member

    zooba commented Apr 27, 2021

    I've pushed the new sources and retriggered the PR (a bit messily, because I tagged/labelled the wrong version number initially, but it's there now). So if it all passes then we're good from my POV.

    @erlend-aasland
    Copy link
    Contributor Author

    Thank you, Steve!

    @zooba
    Copy link
    Member

    zooba commented Apr 27, 2021

    New changeset bf0c7c0 by Erlend Egeberg Aasland in branch 'master':
    bpo-43492: Upgrade Windows installer to use SQLite 3.35.5 (GH-25641)
    bf0c7c0

    @ned-deily
    Copy link
    Member

    New changeset ce82781 by Erlend Egeberg Aasland in branch 'master':
    bpo-43492: Update macOS installer to use SQLite 3.35.5 (GH-25640)
    ce82781

    @miss-islington
    Copy link
    Contributor

    New changeset e013d8d by Miss Islington (bot) in branch '3.8':
    bpo-43492: Update macOS installer to use SQLite 3.35.5 (GH-25640)
    e013d8d

    @miss-islington
    Copy link
    Contributor

    New changeset bf0736d by Miss Islington (bot) in branch '3.9':
    [3.9] bpo-43492: Update macOS installer to use SQLite 3.35.5 (GH-25640) (GH-25662)
    bf0736d

    @zooba
    Copy link
    Member

    zooba commented Apr 27, 2021

    New changeset 5cadcec by Erlend Egeberg Aasland in branch '3.9':
    [3.9] bpo-43492: Upgrade Windows installer to use SQLite 3.35.5 (GH-25641)
    5cadcec

    @zooba
    Copy link
    Member

    zooba commented Apr 27, 2021

    New changeset 7f7cfc4 by Erlend Egeberg Aasland in branch '3.8':
    [3.8] bpo-43492: Upgrade Windows installer to use SQLite 3.35.5 (GH-25641)
    7f7cfc4

    @zooba
    Copy link
    Member

    zooba commented Apr 27, 2021

    Thanks for the backports!

    @zooba zooba added 3.8 only security fixes 3.9 only security fixes labels Apr 27, 2021
    @zooba zooba closed this as completed Apr 27, 2021
    @zooba zooba added 3.8 only security fixes 3.9 only security fixes labels Apr 27, 2021
    @zooba zooba closed this as completed Apr 27, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.8 only security fixes 3.9 only security fixes 3.10 only security fixes OS-mac OS-windows type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    5 participants