Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked Dialog.py #48583

Closed
gpolo mannequin opened this issue Nov 17, 2008 · 3 comments
Closed

Reworked Dialog.py #48583

gpolo mannequin opened this issue Nov 17, 2008 · 3 comments
Labels
topic-tkinter type-feature A feature request or enhancement

Comments

@gpolo
Copy link
Mannequin

gpolo mannequin commented Nov 17, 2008

BPO 4333
Nosy @asvetlov, @serhiy-storchaka
Files
  • Dialog.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2008-11-17.00:23:24.124>
    labels = ['type-feature', 'expert-tkinter']
    title = 'Reworked Dialog.py'
    updated_at = <Date 2014-02-03.18:42:27.734>
    user = 'https://bugs.python.org/gpolo'

    bugs.python.org fields:

    activity = <Date 2014-02-03.18:42:27.734>
    actor = 'BreamoreBoy'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Tkinter']
    creation = <Date 2008-11-17.00:23:24.124>
    creator = 'gpolo'
    dependencies = []
    files = ['12023']
    hgrepos = []
    issue_num = 4333
    keywords = ['patch']
    message_count = 3.0
    messages = ['75948', '112869', '180036']
    nosy_count = 3.0
    nosy_names = ['gpolo', 'asvetlov', 'serhiy.storchaka']
    pr_nums = []
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue4333'
    versions = ['Python 3.4']

    @gpolo
    Copy link
    Mannequin Author

    gpolo mannequin commented Nov 17, 2008

    Hi,

    I have changed the lib-tk/Dialog.py so it handles the cases where one
    might receive a tuple as a result containing a Tcl_Obj. I've also
    modified all the rest of it to make it "cleaner".

    It is b/w compatible although I dislike the usage of cnf, but I guess
    I'm too late to suggest this change even for py3k :/
    A "more complete" description of the changes is in
    http://svn.python.org/view?rev=67240&view=rev

    @gpolo gpolo mannequin added the topic-tkinter label Nov 17, 2008
    @BreamoreBoy
    Copy link
    Mannequin

    BreamoreBoy mannequin commented Aug 4, 2010

    This is already on svn as r67240 but has not got into the builds. Can someone please take a look, thanks.

    @BreamoreBoy BreamoreBoy mannequin added the type-feature A feature request or enhancement label Aug 4, 2010
    @serhiy-storchaka
    Copy link
    Member

    Can you please update the patch for the default branch tip? It looks too outdated.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @iritkatriel iritkatriel closed this as not planned Won't fix, can't repro, duplicate, stale Oct 4, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    topic-tkinter type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants