Add support for PEP 646 #87390

mrahtz · 2021-02-14T17:21:47Z

BPO	43224
Nosy	@gvanrossum, @serhiy-storchaka, @JelleZijlstra, @lysnikolaou, @pablogsal, @Fidget-Spinner, @mrahtz, @mrahtz, @AlexWaygood, @cdce8p
PRs	bpo-43224: Initial implementation of PEP 646 in typing.py #24527 bpo-43224: Draft implementation of PEP 646 #30398 bpo-43224: Implement PEP 646 grammar changes #31018 bpo-43224: Implement PEP 646 changes to genericaliasobject.c #31019 bpo-43224: Implement PEP 646 changes to typing.py #31021 bpo-43224: Implement substitution of unpacked TypeVarTuple #31800 bpo-43224: Work around substitution of unpacked TypeVarTuple #31804 bpo-43224: Implement substitution of unpacked TypeVarTuple in C #31828 bpo-43224: Add more tests for typevar substitution #31844 bpo-43224: Fix Tuple[()].__args__ #31845 bpo-43224: Add tests for TypeVarTuple substitution in Annotated #31846 bpo-43224: Add TypeVarTuple.__name__ #31954 bpo-43224: Unpack concrete tuple types into a sequence of types #32030 bpo-43224: Forbid TypeVar substitution with Unpack #32031 bpo-43224: Implement pickling of TypeVarTuples #32119 bpo-43224: Add tests for pickling and copying of unpacked native tuple #32159

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2021-02-14.17:21:47.204>
labels = ['interpreter-core', 'tests', 'library', '3.11']
title = 'Add support for PEP 646'
updated_at = <Date 2022-04-05.02:52:50.682>
user = 'https://github.com/mrahtz'

bugs.python.org fields:

activity = <Date 2022-04-05.02:52:50.682>
actor = 'JelleZijlstra'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)', 'Tests', 'Parser']
creation = <Date 2021-02-14.17:21:47.204>
creator = 'mrahtz'
dependencies = []
files = []
hgrepos = []
issue_num = 43224
keywords = ['patch']
message_count = 9.0
messages = ['414715', '414935', '414991', '415514', '416020', '416022', '416074', '416689', '416727']
nosy_count = 10.0
nosy_names = ['gvanrossum', 'serhiy.storchaka', 'JelleZijlstra', 'lys.nikolaou', 'pablogsal', 'kj', 'matthew.rahtz', 'mrahtz', 'AlexWaygood', 'cdce8p']
pr_nums = ['24527', '30398', '31018', '31019', '31021', '31800', '31804', '31828', '31844', '31845', '31846', '31954', '32030', '32031', '32119', '32159']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue43224'
versions = ['Python 3.11']

JelleZijlstra · 2022-03-08T04:03:37Z

New changeset 7a793a3 by Matthew Rahtz in branch 'main':
bpo-43224: Implement PEP-646 changes to typing.py (GH-31021)
7a793a3

serhiy-storchaka · 2022-03-11T19:44:16Z

New changeset 5b1b9ea by Serhiy Storchaka in branch 'main':
bpo-43224: Implement substitution of unpacked TypeVarTuple (GH-31800)
5b1b9ea

Fidget-Spinner · 2022-03-12T12:20:17Z

New changeset af2277e by Matthew Rahtz in branch 'main':
bpo-43224: Implement PEP-646 changes to genericaliasobject.c (GH-31019)
af2277e

JelleZijlstra · 2022-03-18T17:56:49Z

New changeset 3a2b895 by Jelle Zijlstra in branch 'main':
bpo-43224: Add TypeVarTuple.__name__ (GH-31954)
3a2b895

mrahtz · 2022-03-25T22:16:13Z

Since things are piling up, here's a quick record of what I think the remaining tasks are: (in approximate order of priority)

Finish writing docs (is updating library/typing.html sufficient? bpo-47097: Add documentation for TypeVarTuple #32103)
Implement support for pickling of unpacked native tuples
Implement support and add tests for copy() of TypeVarTuple and unpacked tuple
Resolve the issue of how we implement type substitution (https://bugs.python.org/issue47006)

JelleZijlstra · 2022-03-25T22:34:24Z

Finish writing docs (is updating library/typing.html sufficient? bpo-47097: Add documentation for TypeVarTuple #32103)

We also need to add to the What's New for 3.11. I volunteered to do that for all the typing PEPs.

Implement support for pickling of unpacked native tuples

Linking your #76300

Implement support and add tests for copy() of TypeVarTuple and unpacked tuple

I believe this uses the same mechanism as pickling, so shouldn't need more work.

JelleZijlstra · 2022-03-26T16:55:56Z

New changeset e8e737b by Matthew Rahtz in branch 'main':
bpo-43224: Implement PEP-646 grammar changes (GH-31018)
e8e737b

mrahtz · 2022-04-04T18:09:27Z

Finish writing docs

Done once #32103 is merged.

Implement support for pickling of unpacked native tuples

Done once #32159 is merged.

Resolve the issue of how we implement type substitution (https://bugs.python.org/issue47006)

Will re-visit this now.

JelleZijlstra · 2022-04-05T02:52:51Z

New changeset 772d808 by Matthew Rahtz in branch 'main':
bpo-43224: typing: Add tests for pickling and copying of unpacked native tuple (GH-32159)
772d808

gvanrossum · 2022-04-11T18:45:59Z

@mrahtz @JelleZijlstra @serhiy-storchaka Is it okay if I unsubscribe from these conversations and let you all come up with a compromise? I feel that while we ought to have a policy formulated and mostly implemented by beta 1 (May 6), tweaks of both the policy and the implementation during the beta period until RC 1 (Aug/Sept?) should be allowable.

mrahtz · 2022-04-11T18:47:41Z

@gvanrossum Fine with me. Godspeed with the rest of your work for this release :)

mrahtz · 2022-04-20T20:17:35Z

Keeping track of things yet to do:

Decide on/implement type substitution behaviour (PEP 646: Decide on substitution behavior #91162)
Add tests for using * with things in typing.py (e.g. *Tuple[int]) now that the grammar PR has been merged (GH-87390: Add remaining tests for PEP 646 #98267)
Implement support for/add tests for typing.get_args and typing.get_origin on unpacked types (GH-87390: Add remaining tests for PEP 646 #98267)
Add some way of figure out whether a native tuple has been starred (gh-87390: Add __unpacked__ attribute to types.GenericAlias #92059)
Finish making the runtime produce the results that the substitution tests https://github.com/python/cpython/blob/main/Lib/test/test_typing.py#L581 say it should
Add substitution test for tuple[*Ts, T][str, *tuple[int, ...]] (GH-87390: Add remaining tests for PEP 646 #98267)
Fix TODOs in test_genericalias.py (GH-87390: Add remaining tests for PEP 646 #98267)

Decided against doing:

Disallow Unpack[Tuple] - I think it's simpler if we keep this valid, in accordance with the the general philosophy of "Keep the runtime lenient when it comes to typing"

…behaviour (#32341)

hauntsaninja · 2022-10-11T06:45:39Z

How much of the checklist above is still relevant?

mrahtz · 2022-10-11T18:39:27Z

Thanks for the reminder! From a quick look, some of the items in the checklist are definitely still relevant. I'll try and find some time for this soon.

Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>

Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>. (cherry picked from commit cb95cc2) Co-authored-by: Matthew Rahtz <matthew.rahtz@gmail.com>

Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>. Co-authored-by: Matthew Rahtz <matthew.rahtz@gmail.com> (cherry picked from commit cb95cc2)

AlexWaygood · 2023-04-10T13:34:42Z

Thanks for the reminder! From a quick look, some of the items in the checklist are definitely still relevant. I'll try and find some time for this soon.

Friendly ping on this -- are the unchecked items on the checklist still to do, or is this issue ~complete now? :)

mrahtz · 2023-04-10T14:32:55Z

Whoops, sorry - we finished #98267 last year but I completely forgot to update the checklist. I believe we can go ahead and close this now :) (though I can't seem to do this myself because the issue was created before the move to GitHub or something? Can you do it on your end?)

AlexWaygood · 2023-04-10T14:53:38Z

Whoops, sorry - we finished #98267 last year but I completely forgot to update the checklist. I believe we can go ahead and close this now :)

No worries -- great to hear!

Can you do it on your end?)

I sure can. Thanks for all the work you put into this, it was a marathon!

mrahtz mannequin added 3.10 only security fixes stdlib Python modules in the Lib dir labels Feb 14, 2021

mrahtz mannequin added tests Tests in the Lib/test dir interpreter-core (Objects, Python, Grammar, and Parser dirs) 3.11 only security fixes and removed 3.10 only security fixes labels Jan 4, 2022

mrahtz mannequin changed the title ~~Add support for PEP 646 (Variadic Generics) to typing.py~~ Add support for PEP 646 Jan 4, 2022

mrahtz mannequin added 3.11 only security fixes and removed 3.10 only security fixes labels Jan 4, 2022

mrahtz mannequin changed the title ~~Add support for PEP 646 (Variadic Generics) to typing.py~~ Add support for PEP 646 Jan 4, 2022

ezio-melotti transferred this issue from another repository Apr 10, 2022

AlexWaygood added topic-typing type-feature A feature request or enhancement labels Apr 13, 2022

JelleZijlstra pushed a commit that referenced this issue Apr 29, 2022

gh-87390: Add tests demonstrating current type variable substitution …

f665616

…behaviour (#32341)

JelleZijlstra added a commit to JelleZijlstra/cpython that referenced this issue Apr 29, 2022

pythongh-87390: Add __unpacked__ attribute to types.GenericAlias

63d2d80

JelleZijlstra mentioned this issue Apr 29, 2022

gh-87390: Add __unpacked__ attribute to types.GenericAlias #92059

Merged

JelleZijlstra added a commit that referenced this issue May 2, 2022

gh-87390: Add __unpacked__ attribute to types.GenericAlias (#92059)

ff88f7e

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue May 5, 2022

pythongh-87390: Fix starred tuple equality and pickling

5823b5a

serhiy-storchaka mentioned this issue May 5, 2022

gh-87390: Fix starred tuple equality and pickling (alt) #92337

Merged

serhiy-storchaka added a commit that referenced this issue May 5, 2022

gh-87390: Fix starred tuple equality and pickling (GH-92337)

1ed8d03

sobolevn mentioned this issue Sep 13, 2022

Tuple[...] is allowed since 3.11+ (gh-31021) #96792

Closed

mrahtz mentioned this issue Oct 14, 2022

GH-87390: Add remaining tests for PEP 646 #98267

Merged

JelleZijlstra pushed a commit that referenced this issue Oct 25, 2022

GH-87390: Add remaining tests for PEP 646 (#98267)

cb95cc2

Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>

bedevere-bot mentioned this issue Oct 25, 2022

[3.11] GH-87390: Add remaining tests for PEP 646 (GH-98267) #98667

Merged

AlexWaygood closed this as completed Apr 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for PEP 646 #87390

Add support for PEP 646 #87390

mrahtz mannequin commented Feb 14, 2021

JelleZijlstra commented Mar 8, 2022

serhiy-storchaka commented Mar 11, 2022

Fidget-Spinner commented Mar 12, 2022

JelleZijlstra commented Mar 18, 2022

mrahtz mannequin commented Mar 25, 2022

JelleZijlstra commented Mar 25, 2022

JelleZijlstra commented Mar 26, 2022

mrahtz mannequin commented Apr 4, 2022

JelleZijlstra commented Apr 5, 2022

gvanrossum commented Apr 11, 2022

mrahtz commented Apr 11, 2022

mrahtz commented Apr 20, 2022 •

edited

hauntsaninja commented Oct 11, 2022

mrahtz commented Oct 11, 2022

AlexWaygood commented Apr 10, 2023

mrahtz commented Apr 10, 2023 •

edited

AlexWaygood commented Apr 10, 2023

Add support for PEP 646 #87390

Add support for PEP 646 #87390

Comments

mrahtz mannequin commented Feb 14, 2021

JelleZijlstra commented Mar 8, 2022

serhiy-storchaka commented Mar 11, 2022

Fidget-Spinner commented Mar 12, 2022

JelleZijlstra commented Mar 18, 2022

mrahtz mannequin commented Mar 25, 2022

JelleZijlstra commented Mar 25, 2022

JelleZijlstra commented Mar 26, 2022

mrahtz mannequin commented Apr 4, 2022

JelleZijlstra commented Apr 5, 2022

gvanrossum commented Apr 11, 2022

mrahtz commented Apr 11, 2022

mrahtz commented Apr 20, 2022 • edited

hauntsaninja commented Oct 11, 2022

mrahtz commented Oct 11, 2022

AlexWaygood commented Apr 10, 2023

mrahtz commented Apr 10, 2023 • edited

AlexWaygood commented Apr 10, 2023

mrahtz commented Apr 20, 2022 •

edited

mrahtz commented Apr 10, 2023 •

edited