Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of @asyncio.coroutine in Python 3.11 #87382

Closed
illia-v mannequin opened this issue Feb 13, 2021 · 5 comments
Closed

Removal of @asyncio.coroutine in Python 3.11 #87382

illia-v mannequin opened this issue Feb 13, 2021 · 5 comments
Labels
3.11 only security fixes topic-asyncio

Comments

@illia-v
Copy link
Mannequin

illia-v mannequin commented Feb 13, 2021

BPO 43216
Nosy @vstinner, @asvetlov, @1st1, @graingert, @aeros, @felixxm, @illia-v, @kamilturek, @kumaraditya303
PRs
  • bpo-43216: Remove @asyncio.coroutine #26369
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2022-02-11.11:47:33.862>
created_at = <Date 2021-02-13.16:47:55.238>
labels = ['3.11', 'expert-asyncio']
title = 'Removal of @asyncio.coroutine in Python 3.11'
updated_at = <Date 2022-02-11.11:47:33.861>
user = 'https://github.com/illia-v'

    bugs.python.org fields:

    activity = <Date 2022-02-11.11:47:33.861>
actor = 'asvetlov'
assignee = 'none'
closed = True
closed_date = <Date 2022-02-11.11:47:33.862>
closer = 'asvetlov'
components = ['asyncio']
creation = <Date 2021-02-13.16:47:55.238>
creator = 'illia-v'
dependencies = []
files = []
hgrepos = []
issue_num = 43216
keywords = ['patch']
message_count = 5.0
messages = ['386927', '392093', '396814', '413059', '413060']
nosy_count = 9.0
nosy_names = ['vstinner', 'asvetlov', 'yselivanov', 'graingert', 'aeros', 'felixxm', 'illia-v', 'kamilturek', 'kumaraditya']
pr_nums = ['26369']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue43216'
versions = ['Python 3.11']
    @illia-v
    Copy link
    Mannequin Author

    illia-v mannequin commented Feb 13, 2021

    It looks like @asyncio.coroutine was scheduled to be removed in Python 3.10.

    Is it still relevant?

    https://bugs.python.org/issue36921
    https://docs.python.org/3.10/library/asyncio-task.html#asyncio.coroutine

    @illia-v illia-v mannequin added 3.10 only security fixes topic-asyncio labels Feb 13, 2021
    @vstinner
    Copy link
    Member

    I suggest to wait for Python 3.11 to remove it. See the thread on python-dev:
    https://mail.python.org/archives/list/python-dev@python.org/thread/PLSLFTJXY2JUIRGJARBER4SRUWDXX2AQ/

    @vstinner vstinner added 3.11 only security fixes and removed 3.10 only security fixes labels Apr 27, 2021
    @vstinner vstinner changed the title Removal of @asyncio.coroutine in Python 3.10 Removal of @asyncio.coroutine in Python 3.11 Apr 27, 2021
    @vstinner vstinner added 3.11 only security fixes and removed 3.10 only security fixes labels Apr 27, 2021
    @vstinner vstinner changed the title Removal of @asyncio.coroutine in Python 3.10 Removal of @asyncio.coroutine in Python 3.11 Apr 27, 2021
    @vstinner
    Copy link
    Member

    vstinner commented Jul 1, 2021

    New changeset a1092f6 by Illia Volochii in branch 'main':
    bpo-43216: Remove @asyncio.coroutine (GH-26369)
    a1092f6

    @kumaraditya303
    Copy link
    Contributor

    Can this be closed now?

    @asvetlov
    Copy link
    Contributor

    Closed.
    Thanks for the reminder!

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @yan12125 yan12125 mentioned this issue Sep 13, 2022
    Closed
    @rytilahti rytilahti mentioned this issue Oct 24, 2022
    Closed
    @mikeckennedy mikeckennedy mentioned this issue Oct 25, 2022
    Closed
    danigm added a commit to danigm/pook that referenced this issue Jan 12, 2023
    @danigm
    Remove asyncio.coroutine usage
    d779482 
    The asyncio.coroutine doesn't exist in Python 3.11 and future versions:
python/cpython#87382

See h2non#84
    @danigm danigm mentioned this issue Jan 12, 2023
    Merged
    h2non pushed a commit to h2non/pook that referenced this issue Jan 12, 2023
    @danigm
    Fix Py3.11 compatibility (#85)
    3f2b818 
    * Remove asyncio.coroutine usage

The asyncio.coroutine doesn't exist in Python 3.11 and future versions:
python/cpython#87382

See #84

* Add python 3.11 to tests

* lint: fix lint issue mock_test.py
    @pschmitt pschmitt mentioned this issue Jun 7, 2023
    Merged
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.11 only security fixes topic-asyncio
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @vstinner @asvetlov @kumaraditya303