Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webbrowser to support "gio open <URL>" #87303

Open
doko42 opened this issue Feb 5, 2021 · 10 comments
Open

webbrowser to support "gio open <URL>" #87303

doko42 opened this issue Feb 5, 2021 · 10 comments
Labels
3.11 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@doko42
Copy link
Member

doko42 commented Feb 5, 2021

BPO 43137
Nosy @doko42, @tiran, @smcv, @pablogsal, @miss-islington
PRs
  • bpo-43137: webbrowser: Replace gvfs-open and gnome-open with "gio open" #29154
  • bpo-43137: Revert "webbrowser: Don't run gvfs-open on GNOME" #30417
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2021-02-05.12:26:34.132>
labels = ['type-feature', 'library', '3.11']
title = 'webbrowser to support "gio open <URL>"'
updated_at = <Date 2022-01-05.11:54:53.277>
user = 'https://github.com/doko42'

    bugs.python.org fields:

    activity = <Date 2022-01-05.11:54:53.277>
actor = 'pablogsal'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2021-02-05.12:26:34.132>
creator = 'doko'
dependencies = []
files = []
hgrepos = []
issue_num = 43137
keywords = ['patch', '3.11regression']
message_count = 10.0
messages = ['386526', '407019', '407056', '407074', '407982', '409721', '409754', '409755', '409756', '409757']
nosy_count = 5.0
nosy_names = ['doko', 'christian.heimes', 'smcv', 'pablogsal', 'miss-islington']
pr_nums = ['29154', '30417']
priority = None
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue43137'
versions = ['Python 3.11']
    @doko42
    Copy link
    Member Author

    doko42 commented Feb 5, 2021

    [forwarded from https://bugs.debian.org/969776]

    """
    rust-webbrowser tries to open URLs via "gvfs-open $URL" and
    "gnome-open $URL". Both are obsolete; the replacement is "gio open $URL",
    using the gio(1) tool from the libglib2.0-bin package.

    The gvfs-open tool was superseded by gio(1) in 2015, and removed from
    upstream GNOME in 2018. The version in Debian is currently a
    Debian-specific patch, which we would like to remove before Debian 11.

    The gnome-open tool was superseded by gvfs-open in 2008, ceased to be
    part of GNOME releases after about 2011, most recently appeared in a
    Debian stable release as part of Debian 9, and was finally removed from
    Debian in 2019.
    """

    The current list of browser could need some cleanup, e.g.:

    • remove "The Netscape and old Mozilla browsers"
    • remove grail?
    • remove gvfs-open
    • gnome-open?
    • can't find galeon anymore, but epiphany

    @doko42 doko42 added 3.10 only security fixes stdlib Python modules in the Lib dir labels Feb 5, 2021
    @miss-islington
    Copy link
    Contributor

    New changeset 97dcab7 by Simon McVittie in branch 'main':
    bpo-43137: webbrowser: Replace gvfs-open and gnome-open with "gio open" (GH-29154)
    97dcab7

    @tiran
    Copy link
    Member

    tiran commented Nov 26, 2021

    gio is not available on older distros. For example I could not find it in Xenial with libglib2.0-bin 2.48.2-0ubuntu4.8. I suggest that you keep the fallbacks or seek agreement that we no longer support old distros without gio.

    @tiran tiran added 3.11 only security fixes release-blocker type-feature A feature request or enhancement and removed 3.10 only security fixes labels Nov 26, 2021
    @pablogsal
    Copy link
    Member

    The next 3.10 and 3.11 releases are very soon so unfortunately if this is not fixed by then I will need to revert PR29154

    @pablogsal
    Copy link
    Member

    Christian, this is going into 3.11.0a3 unfortunately. I will make this a blocker for future alphas, so please, take any action that you think is required.

    @pablogsal
    Copy link
    Member

    If this is not fixed by this week, I will be forced to revert the PR

    @smcv
    Copy link
    Mannequin

    smcv mannequin commented Jan 5, 2022

    I've opened #30417, is that what you want?

    I am not a regular CPython developer, so I don't have a good way to assess which reviewers speak for the project and which reviewers are only offering a personal opinion.

    @pablogsal
    Copy link
    Member

    > I am not a regular CPython developer, so I don't have a good way to assess which reviewers speak for the project and which reviewers are only offering a personal opinion.

    In this webpage (bpo) core developers have a little python logo close to their name (as myself).

    In GitHub, you can sometimes tell by hovering over the profile or checking the core dev log in the devguide: https://devguide.python.org/developers/

    @pablogsal
    Copy link
    Member

    New changeset dd50316 by Simon McVittie in branch 'main':
    bpo-43137: Revert "webbrowser: Don't run gvfs-open on GNOME" (GH-30417)
    dd50316

    @pablogsal
    Copy link
    Member

    I am removing the "release blocker" tag.

    Simon, thanks a lot for both PRs. I am sorry that we needed to revert your original work, but unfortunately it was blocking a release and we are forced to act in this case. PLease, work together with Christian and Matthias to make a version of the patch that works in all supported platforms.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @DBJim DBJim mentioned this issue Mar 21, 2023
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.11 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    4 participants
    @tiran @doko42 @pablogsal @miss-islington