Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use io.IncrementalNewlineDecoder for doctest newline conversion #87215

Closed
pdonis mannequin opened this issue Jan 28, 2021 · 4 comments
Closed

Use io.IncrementalNewlineDecoder for doctest newline conversion #87215

pdonis mannequin opened this issue Jan 28, 2021 · 4 comments
Labels
3.10 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@pdonis
Copy link
Mannequin

pdonis mannequin commented Jan 28, 2021

BPO 43049
Nosy @pdonis, @merwok, @zware
PRs
  • bpo-43049: Use io.IncrementalNewlineDecoder for doctest newline conversion #24359
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2021-03-02.17:08:19.122>
created_at = <Date 2021-01-28.02:10:04.826>
labels = ['type-feature', 'library', '3.10']
title = 'Use io.IncrementalNewlineDecoder for doctest newline conversion'
updated_at = <Date 2021-03-03.00:45:29.104>
user = 'https://github.com/pdonis'

    bugs.python.org fields:

    activity = <Date 2021-03-03.00:45:29.104>
actor = 'pdonis'
assignee = 'none'
closed = True
closed_date = <Date 2021-03-02.17:08:19.122>
closer = 'zach.ware'
components = ['Library (Lib)']
creation = <Date 2021-01-28.02:10:04.826>
creator = 'pdonis'
dependencies = []
files = []
hgrepos = []
issue_num = 43049
keywords = ['patch']
message_count = 4.0
messages = ['385830', '387939', '387941', '387988']
nosy_count = 3.0
nosy_names = ['pdonis', 'eric.araujo', 'zach.ware']
pr_nums = ['24359']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue43049'
versions = ['Python 3.10']
    @pdonis
    Copy link
    Mannequin Author

    pdonis mannequin commented Jan 28, 2021

    This is a follow-up to bpo-1812:

    https://bugs.python.org/issue1812

    It was suggested in the discussion on that issue that the newline conversion in doctest that was corrected in that issue could be done using already defined resources in the io module instead of by a custom function. This issue is to provide an issue number for my pull request on github to do that: the io module provides the IncrementalNewlineDecoder object that does exactly what is needed.

    @pdonis pdonis mannequin added tests Tests in the Lib/test dir 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes 3.10 only security fixes type-feature A feature request or enhancement labels Jan 28, 2021
    @zware
    Copy link
    Member

    zware commented Mar 2, 2021

    New changeset b36349a by Peter Donis in branch 'master':
    bpo-43049: Use io.IncrementalNewlineDecoder for doctest newline conversion (GH-24359)
    b36349a

    @zware
    Copy link
    Member

    zware commented Mar 2, 2021

    Thanks for the patch!

    @zware zware added stdlib Python modules in the Lib dir and removed tests Tests in the Lib/test dir 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes labels Mar 2, 2021
    @zware zware closed this as completed Mar 2, 2021
    @zware zware removed the 3.9 only security fixes label Mar 2, 2021
    @zware zware closed this as completed Mar 2, 2021
    @pdonis
    Copy link
    Mannequin Author

    pdonis mannequin commented Mar 3, 2021

    Thanks for merging!

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.10 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @zware