Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

classmethod change in 3.9 needs better documentation #86998

Closed
iritkatriel opened this issue Jan 5, 2021 · 2 comments
Closed

classmethod change in 3.9 needs better documentation #86998

iritkatriel opened this issue Jan 5, 2021 · 2 comments
Labels
3.9 only security fixes 3.10 only security fixes docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error

Comments

@iritkatriel
Copy link
Member

BPO 42832
Nosy @iritkatriel

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2021-01-05.15:07:33.392>
labels = ['type-bug', '3.9', '3.10', 'docs']
title = 'classmethod change in 3.9 needs better documentation'
updated_at = <Date 2021-01-05.15:07:33.392>
user = 'https://github.com/iritkatriel'

bugs.python.org fields:

activity = <Date 2021-01-05.15:07:33.392>
actor = 'iritkatriel'
assignee = 'docs@python'
closed = False
closed_date = None
closer = None
components = ['Documentation']
creation = <Date 2021-01-05.15:07:33.392>
creator = 'iritkatriel'
dependencies = []
files = []
hgrepos = []
issue_num = 42832
keywords = []
message_count = 1.0
messages = ['384404']
nosy_count = 2.0
nosy_names = ['docs@python', 'iritkatriel']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue42832'
versions = ['Python 3.9', 'Python 3.10']

@iritkatriel
Copy link
Member Author

The change in bpo-19072 broke our code where a decorator assumes that __get__ is only called for instance methods.

It might be worth adding this to What's new in 3.9.

Also in the documentation:
https://docs.python.org/3/library/functions.html#classmethod
It implies that before 3.9 it was not possible to wrap, but it was possible, it just behaved differently.

@iritkatriel iritkatriel added 3.9 only security fixes 3.10 only security fixes labels Jan 5, 2021
@iritkatriel iritkatriel added docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error 3.9 only security fixes 3.10 only security fixes labels Jan 5, 2021
@iritkatriel iritkatriel added docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error labels Jan 5, 2021
@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
@iritkatriel
Copy link
Member Author

I don't know how to document this further, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.9 only security fixes 3.10 only security fixes docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

1 participant