Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefined behavior in Objects/genericaliasobject.c #86980

Closed
ZackerySpytz mannequin opened this issue Jan 3, 2021 · 3 comments
Closed

Undefined behavior in Objects/genericaliasobject.c #86980

ZackerySpytz mannequin opened this issue Jan 3, 2021 · 3 comments
Labels
3.10 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@ZackerySpytz
Copy link
Mannequin

ZackerySpytz mannequin commented Jan 3, 2021

BPO 42814
Nosy @vstinner, @ZackerySpytz
PRs
  • bpo-42814: Fix undefined behavior in Objects/genericaliasobject.c #24073
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2021-01-03.12:22:16.026>
created_at = <Date 2021-01-03.11:40:24.596>
labels = ['interpreter-core', '3.10']
title = 'Undefined behavior in Objects/genericaliasobject.c'
updated_at = <Date 2021-01-03.12:22:16.025>
user = 'https://github.com/ZackerySpytz'

    bugs.python.org fields:

    activity = <Date 2021-01-03.12:22:16.025>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2021-01-03.12:22:16.026>
closer = 'vstinner'
components = ['Interpreter Core']
creation = <Date 2021-01-03.11:40:24.596>
creator = 'ZackerySpytz'
dependencies = []
files = []
hgrepos = []
issue_num = 42814
keywords = ['patch']
message_count = 3.0
messages = ['384261', '384266', '384267']
nosy_count = 2.0
nosy_names = ['vstinner', 'ZackerySpytz']
pr_nums = ['24073']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue42814'
versions = ['Python 3.10']
    @ZackerySpytz
    Copy link
    Mannequin Author

    ZackerySpytz mannequin commented Jan 3, 2021

    In is_typing_name(), va_end() is not always called before the function returns. It is undefined behavior to call va_start() without also calling va_end().

    @ZackerySpytz ZackerySpytz mannequin added 3.10 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Jan 3, 2021
    @vstinner
    Copy link
    Member

    vstinner commented Jan 3, 2021

    New changeset 5d3553b by Zackery Spytz in branch 'master':
    bpo-42814: Fix undefined behavior in Objects/genericaliasobject.c (GH-24073)
    5d3553b

    @vstinner
    Copy link
    Member

    vstinner commented Jan 3, 2021

    Thanks for the fix!

    @vstinner vstinner closed this as completed Jan 3, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.10 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs)
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @vstinner