Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PyType_Type.tp_vectorcall for type(obj) performance #86974

Closed
sweeneyde opened this issue Jan 2, 2021 · 3 comments
Closed

Add PyType_Type.tp_vectorcall for type(obj) performance #86974

sweeneyde opened this issue Jan 2, 2021 · 3 comments
Labels
3.10 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage

Comments

@sweeneyde
Copy link
Member

BPO 42808
Nosy @serhiy-storchaka, @corona10, @sweeneyde
PRs
  • bpo-42808: Add PyType_Type.tp_vectorcall for type(obj) performance #24058
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2021-02-22.02:59:49.751>
created_at = <Date 2021-01-02.10:00:06.743>
labels = ['interpreter-core', '3.10', 'performance']
title = 'Add PyType_Type.tp_vectorcall for type(obj) performance'
updated_at = <Date 2021-02-22.02:59:49.751>
user = 'https://github.com/sweeneyde'

    bugs.python.org fields:

    activity = <Date 2021-02-22.02:59:49.751>
actor = 'corona10'
assignee = 'none'
closed = True
closed_date = <Date 2021-02-22.02:59:49.751>
closer = 'corona10'
components = ['Interpreter Core']
creation = <Date 2021-01-02.10:00:06.743>
creator = 'Dennis Sweeney'
dependencies = []
files = []
hgrepos = []
issue_num = 42808
keywords = ['patch']
message_count = 3.0
messages = ['384218', '387488', '387489']
nosy_count = 3.0
nosy_names = ['serhiy.storchaka', 'corona10', 'Dennis Sweeney']
pr_nums = ['24058']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'performance'
url = 'https://bugs.python.org/issue42808'
versions = ['Python 3.10']
    @sweeneyde
    Copy link
    Member Author

    # common case
    .\python.bat -m pyperf timeit "type(17)"
    Master: 49.9 ns +- 1.8 ns ---> PR: 33.3 ns +- 1.4 ns

    # uncommon case
    .\python.bat -m pyperf timeit "type('A', (object, ), {})"
    Master: 5.14 us +- 0.04 us ---> PR: 5.43 us +- 0.06 us

    @sweeneyde sweeneyde added 3.10 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage labels Jan 2, 2021
    @corona10
    Copy link
    Member

    New changeset b19855b by Dennis Sweeney in branch 'master':
    bpo-42808: Add PyType_Type.tp_vectorcall for type(obj) performance (GH-24058)
    b19855b

    @corona10
    Copy link
    Member

    Thank you Dennis!

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.10 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @corona10 @sweeneyde