New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module 'parser' fails to build #48529
Comments
With a clean checkout of the py3k source it fails to build the Parser This appears to be related to the movement of the symbol Because of this the module now requires Parser\metagrammar.c to get The patch modifies setup.py to add the required file and modifies (This fails on a clean trunk build in the same way as well - which My gut feeling is that my modification to setup.py for the module is |
bah I *am* a idiot, bpo-4288 and Christian's comments point out that I Will modify patch to use the correct grammar file &c. (and maybe one day I might actually say something sensible to do with |
As Christian said in bpo-4288: this links in a separate of metagrammar.c, |
a new patch that will use the grammar definition from Python/graminit.c
This has expanded the patch somewhat to include changes to:
All of which makes me think that the change to make the symbol "public" Will look at this under my Cygwin environment tomorrow. (I have run a |
That patch is too complicated. We already have meta_grammar and |
As a style guide remark: drop the parentheses around the expression in |
Martin: Looking at it I agree with you 100% - the patch is too complicated for My personal preference is to try to hide such data structures - but |
I can confirm this problem in 3.0rc3 on Cygwin. If I could get some |
I think the parser module should call one of the existing functions. |
Attempting to export and use Py_meta_grammar() gives me a broken module, This patch, which exports _PyParser_Grammar, is very simple and the test I will gladly take guidance on this patch. |
This problem also occurs when building the 2.6.1 parser module on Cygwin The error from 'make' is building 'parser' extension I was able to work around the error and build a parser module that gcc -shared -Wl,--enable-auto-image-base i.e. by including Python/graminit.o in the explicit object files to load. I have also confirmed that applying the parser-grammar.patch from bpo-4288 |
Here's the patch I used for the Cygwin Ports 2.6 and 3.0 packages. It's |
I have now committed 2.6.1-parsermodule.patch as r68523, r68524, r68525, |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: