Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take into acount a Tcl interpreter when compare variables and fonts #86925

Closed
serhiy-storchaka opened this issue Dec 27, 2020 · 4 comments
Closed

Take into acount a Tcl interpreter when compare variables and fonts #86925

serhiy-storchaka opened this issue Dec 27, 2020 · 4 comments
Labels
3.8 only security fixes 3.9 only security fixes 3.10 only security fixes stdlib Python modules in the Lib dir topic-tkinter type-bug An unexpected behavior, bug, or error

Comments

@serhiy-storchaka
Copy link
Member

BPO 42759
Nosy @serhiy-storchaka, @miss-islington
PRs
  • bpo-42759: Fix equality comparison of Variable and Font in Tkinter #23968
  • [3.9] bpo-42759: Fix equality comparison of Variable and Font in Tkinter (GH-23968) #23991
  • [3.8] bpo-42759: Fix equality comparison of Variable and Font in Tkinter (GH-23968) #24026
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2021-01-01.20:50:36.527>
created_at = <Date 2020-12-27.20:16:59.270>
labels = ['type-bug', 'expert-tkinter', '3.9', '3.10', '3.8', 'library']
title = 'Take into acount a Tcl interpreter when compare variables and fonts'
updated_at = <Date 2021-01-01.20:50:36.527>
user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2021-01-01.20:50:36.527>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2021-01-01.20:50:36.527>
closer = 'serhiy.storchaka'
components = ['Library (Lib)', 'Tkinter']
creation = <Date 2020-12-27.20:16:59.270>
creator = 'serhiy.storchaka'
dependencies = []
files = []
hgrepos = []
issue_num = 42759
keywords = ['patch']
message_count = 4.0
messages = ['383860', '383976', '383979', '384187']
nosy_count = 2.0
nosy_names = ['serhiy.storchaka', 'miss-islington']
pr_nums = ['23968', '23991', '24026']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue42759'
versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']
    @serhiy-storchaka
    Copy link
    Member Author

    Currently instances of tkinter.Variable and tkinter.font.Font are considered equal when they have the same name even if they belong to different Tcl interpreters. But Tcl interpreters are isolated, and variables and fonts in different interpreters refer to different things.

    There is note in the docstring of tkinter.Variable.__eq__ about taking into account master. The following PR fixes this omission.

    @serhiy-storchaka serhiy-storchaka added 3.8 only security fixes 3.9 only security fixes 3.10 only security fixes stdlib Python modules in the Lib dir topic-tkinter type-bug An unexpected behavior, bug, or error labels Dec 27, 2020
    @serhiy-storchaka
    Copy link
    Member Author

    New changeset 1df56bc by Serhiy Storchaka in branch 'master':
    bpo-42759: Fix equality comparison of Variable and Font in Tkinter (GH-23968)
    1df56bc

    @miss-islington
    Copy link
    Contributor

    New changeset 578caaf by Miss Islington (bot) in branch '3.9':
    bpo-42759: Fix equality comparison of Variable and Font in Tkinter (GH-23968)
    578caaf

    @serhiy-storchaka
    Copy link
    Member Author

    New changeset e3a9adb by Serhiy Storchaka in branch '3.8':
    [3.8] bpo-42759: Fix equality comparison of Variable and Font in Tkinter (GH-23968) (GH-24026)
    e3a9adb

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes 3.9 only security fixes 3.10 only security fixes stdlib Python modules in the Lib dir topic-tkinter type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @serhiy-storchaka @miss-islington