Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed test_new_curses_panel in test_curses #86860

Closed
serhiy-storchaka opened this issue Dec 20, 2020 · 3 comments
Closed

Failed test_new_curses_panel in test_curses #86860

serhiy-storchaka opened this issue Dec 20, 2020 · 3 comments
Labels
3.10 only security fixes

Comments

@serhiy-storchaka
Copy link
Member

BPO 42694
Nosy @vstinner, @serhiy-storchaka, @koubaa
PRs
  • bpo-42694: Cannot create _curses_panel.panel #23948
  • bpo-1635741 port _curses_panel to multi-phase init (PEP 489) #21986
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-12-26.01:18:28.307>
created_at = <Date 2020-12-20.21:10:00.930>
labels = ['3.10']
title = 'Failed test_new_curses_panel in test_curses'
updated_at = <Date 2020-12-26.01:18:28.307>
user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2020-12-26.01:18:28.307>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2020-12-26.01:18:28.307>
closer = 'vstinner'
components = []
creation = <Date 2020-12-20.21:10:00.930>
creator = 'serhiy.storchaka'
dependencies = []
files = []
hgrepos = []
issue_num = 42694
keywords = ['patch']
message_count = 3.0
messages = ['383453', '383784', '383788']
nosy_count = 3.0
nosy_names = ['vstinner', 'serhiy.storchaka', 'koubaa']
pr_nums = ['23948', '21986']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue42694'
versions = ['Python 3.10']
    @serhiy-storchaka
    Copy link
    Member Author

    ======================================================================
    FAIL: test_new_curses_panel (test.test_curses.TestCurses)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
  File "/home/serhiy/py/cpython/Lib/test/test_curses.py", line 425, in test_new_curses_panel
    self.assertRaises(TypeError, type(panel))
AssertionError: TypeError not raised by panel

    The regression was introduced in 1baf030 (bpo-1635741). It can lead to crash because creation of non-initialized object is allowed now. See bpo-23815 for details.

    @serhiy-storchaka serhiy-storchaka added the 3.10 only security fixes label Dec 20, 2020
    @vstinner
    Copy link
    Member

    I can reproduce the issue with the command:

    ./python -m test -u all test_curses

    I wrote PR 23948 to fix the regression.

    Note: "./python -m test test_curses" doesn't fail since the test is skipped.

    @vstinner
    Copy link
    Member

    New changeset 993e88c by Victor Stinner in branch 'master':
    bpo-42694: Prevent creating _curses_panel.panel (GH-23948)
    993e88c

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.10 only security fixes
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @vstinner @serhiy-storchaka